diff options
author | Takashi Iwai <tiwai@suse.de> | 2013-10-30 13:42:13 -0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2013-10-30 13:42:13 -0400 |
commit | c4a4ddaefbef3c5135c3167bd5e067859d71e84c (patch) | |
tree | 1c44a7de360774a272495593d2bb67853380da82 /sound | |
parent | 6fc16e58adf50c0f1e4478538983fb5ff6f453d4 (diff) | |
parent | 8723b795aaa0c5f0b9db2099af575f5e089a63f1 (diff) |
Merge tag 'asoc-fix-v3.12-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into for-linus
ASoC: Fixes for v3.12
A few of the Coverity fixes from Takashi, one of which (the wm_hubs one)
is particularly noticable.
Diffstat (limited to 'sound')
-rw-r--r-- | sound/soc/codecs/wm_hubs.c | 1 | ||||
-rw-r--r-- | sound/soc/soc-dapm.c | 4 |
2 files changed, 4 insertions, 1 deletions
diff --git a/sound/soc/codecs/wm_hubs.c b/sound/soc/codecs/wm_hubs.c index 8b50e5958de5..01daf655e20b 100644 --- a/sound/soc/codecs/wm_hubs.c +++ b/sound/soc/codecs/wm_hubs.c | |||
@@ -530,6 +530,7 @@ static int hp_supply_event(struct snd_soc_dapm_widget *w, | |||
530 | hubs->hp_startup_mode); | 530 | hubs->hp_startup_mode); |
531 | break; | 531 | break; |
532 | } | 532 | } |
533 | break; | ||
533 | 534 | ||
534 | case SND_SOC_DAPM_PRE_PMD: | 535 | case SND_SOC_DAPM_PRE_PMD: |
535 | snd_soc_update_bits(codec, WM8993_CHARGE_PUMP_1, | 536 | snd_soc_update_bits(codec, WM8993_CHARGE_PUMP_1, |
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index c17c14c394df..b2949aed1ac2 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c | |||
@@ -1949,7 +1949,7 @@ static ssize_t dapm_widget_power_read_file(struct file *file, | |||
1949 | w->active ? "active" : "inactive"); | 1949 | w->active ? "active" : "inactive"); |
1950 | 1950 | ||
1951 | list_for_each_entry(p, &w->sources, list_sink) { | 1951 | list_for_each_entry(p, &w->sources, list_sink) { |
1952 | if (p->connected && !p->connected(w, p->sink)) | 1952 | if (p->connected && !p->connected(w, p->source)) |
1953 | continue; | 1953 | continue; |
1954 | 1954 | ||
1955 | if (p->connect) | 1955 | if (p->connect) |
@@ -3495,6 +3495,7 @@ int snd_soc_dapm_new_dai_widgets(struct snd_soc_dapm_context *dapm, | |||
3495 | if (!w) { | 3495 | if (!w) { |
3496 | dev_err(dapm->dev, "ASoC: Failed to create %s widget\n", | 3496 | dev_err(dapm->dev, "ASoC: Failed to create %s widget\n", |
3497 | dai->driver->playback.stream_name); | 3497 | dai->driver->playback.stream_name); |
3498 | return -ENOMEM; | ||
3498 | } | 3499 | } |
3499 | 3500 | ||
3500 | w->priv = dai; | 3501 | w->priv = dai; |
@@ -3513,6 +3514,7 @@ int snd_soc_dapm_new_dai_widgets(struct snd_soc_dapm_context *dapm, | |||
3513 | if (!w) { | 3514 | if (!w) { |
3514 | dev_err(dapm->dev, "ASoC: Failed to create %s widget\n", | 3515 | dev_err(dapm->dev, "ASoC: Failed to create %s widget\n", |
3515 | dai->driver->capture.stream_name); | 3516 | dai->driver->capture.stream_name); |
3517 | return -ENOMEM; | ||
3516 | } | 3518 | } |
3517 | 3519 | ||
3518 | w->priv = dai; | 3520 | w->priv = dai; |