diff options
author | Tim Gardner <tim.gardner@canonical.com> | 2014-04-09 13:30:44 -0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2014-04-09 15:07:38 -0400 |
commit | a5065eb6da55b226661456e6a7435f605df98111 (patch) | |
tree | 46c95c1584bf3491b0dc451f7e53e29e6adda74a /sound | |
parent | 50487c3a4a96d91e25d43d63262773f14961d9de (diff) |
ALSA: usb-audio: Suppress repetitive debug messages from retire_playback_urb()
BugLink: http://bugs.launchpad.net/bugs/1305133
Malfunctioning or slow devices can cause a flood of dmesg SPAM.
I've ignored checkpatch.pl complaints about the use of printk_ratelimit() in favour
of prior art in sound/usb/pcm.c.
WARNING: Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit
+ if (printk_ratelimit() &&
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Eldad Zack <eldad@fogrefinery.com>
Cc: Daniel Mack <zonque@gmail.com>
Cc: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
-rw-r--r-- | sound/usb/pcm.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c index 49de5c1284f6..131336d40492 100644 --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c | |||
@@ -1501,7 +1501,8 @@ static void retire_playback_urb(struct snd_usb_substream *subs, | |||
1501 | * The error should be lower than 2ms since the estimate relies | 1501 | * The error should be lower than 2ms since the estimate relies |
1502 | * on two reads of a counter updated every ms. | 1502 | * on two reads of a counter updated every ms. |
1503 | */ | 1503 | */ |
1504 | if (abs(est_delay - subs->last_delay) * 1000 > runtime->rate * 2) | 1504 | if (printk_ratelimit() && |
1505 | abs(est_delay - subs->last_delay) * 1000 > runtime->rate * 2) | ||
1505 | dev_dbg(&subs->dev->dev, | 1506 | dev_dbg(&subs->dev->dev, |
1506 | "delay: estimated %d, actual %d\n", | 1507 | "delay: estimated %d, actual %d\n", |
1507 | est_delay, subs->last_delay); | 1508 | est_delay, subs->last_delay); |