diff options
author | Lars-Peter Clausen <lars@metafoo.de> | 2013-07-24 09:27:35 -0400 |
---|---|---|
committer | Mark Brown <broonie@linaro.org> | 2013-07-24 09:55:04 -0400 |
commit | 56a678344273fd63f8ade26876283a2586a9bf3a (patch) | |
tree | 6a0f652d408b91b7f70b43b098f6c19c9da3b4aa /sound | |
parent | 3b2f64d00c46e1e4e9bd0bb9bb12619adac27a4b (diff) |
ASoC: dapm: Fix return value of snd_soc_dapm_put_{volsw,enum_virt}()
The ALSA core expect the put callback of a control to return 1 if the value of
the control changed and 0 if it did not. Both snd_soc_dapm_put_volsw() and
snd_soc_dapm_put_enum_virt() currently always returns 0. For both functions we
already have a 'change' variable which either contains 1 or 0 depending on
whether the value has changed or not, so just return that.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'sound')
-rw-r--r-- | sound/soc/soc-dapm.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index b94190820e8c..bd16010441cc 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c | |||
@@ -2733,7 +2733,7 @@ int snd_soc_dapm_put_volsw(struct snd_kcontrol *kcontrol, | |||
2733 | } | 2733 | } |
2734 | 2734 | ||
2735 | mutex_unlock(&card->dapm_mutex); | 2735 | mutex_unlock(&card->dapm_mutex); |
2736 | return 0; | 2736 | return change; |
2737 | } | 2737 | } |
2738 | EXPORT_SYMBOL_GPL(snd_soc_dapm_put_volsw); | 2738 | EXPORT_SYMBOL_GPL(snd_soc_dapm_put_volsw); |
2739 | 2739 | ||
@@ -2861,7 +2861,6 @@ int snd_soc_dapm_put_enum_virt(struct snd_kcontrol *kcontrol, | |||
2861 | struct soc_enum *e = | 2861 | struct soc_enum *e = |
2862 | (struct soc_enum *)kcontrol->private_value; | 2862 | (struct soc_enum *)kcontrol->private_value; |
2863 | int change; | 2863 | int change; |
2864 | int ret = 0; | ||
2865 | int wi; | 2864 | int wi; |
2866 | 2865 | ||
2867 | if (ucontrol->value.enumerated.item[0] >= e->max) | 2866 | if (ucontrol->value.enumerated.item[0] >= e->max) |
@@ -2881,7 +2880,7 @@ int snd_soc_dapm_put_enum_virt(struct snd_kcontrol *kcontrol, | |||
2881 | } | 2880 | } |
2882 | 2881 | ||
2883 | mutex_unlock(&card->dapm_mutex); | 2882 | mutex_unlock(&card->dapm_mutex); |
2884 | return ret; | 2883 | return change; |
2885 | } | 2884 | } |
2886 | EXPORT_SYMBOL_GPL(snd_soc_dapm_put_enum_virt); | 2885 | EXPORT_SYMBOL_GPL(snd_soc_dapm_put_enum_virt); |
2887 | 2886 | ||