diff options
author | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2009-10-28 11:47:48 -0400 |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2009-10-29 08:55:56 -0400 |
commit | 26d95b6e300c4847be6ec8bfe817dbd531e94d9a (patch) | |
tree | bf5e2377f4b06c88988fd815e107795d54d13984 /sound | |
parent | 2845fa13e5cbe708ece7fafe29c91f32c66e4f59 (diff) |
ASoC: Minor SMDK64xx WM8580 cleanups
Fix up some comments, remove all enable_pin() calls (edge widgets
are all enabled by default) and mark the microphone as disabled by
default since it requires a resistor fit to connect it.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'sound')
-rw-r--r-- | sound/soc/s3c24xx/smdk64xx_wm8580.c | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/sound/soc/s3c24xx/smdk64xx_wm8580.c b/sound/soc/s3c24xx/smdk64xx_wm8580.c index 482aaf10eff6..cb8a9161b643 100644 --- a/sound/soc/s3c24xx/smdk64xx_wm8580.c +++ b/sound/soc/s3c24xx/smdk64xx_wm8580.c | |||
@@ -103,7 +103,7 @@ static int smdk64xx_hw_params(struct snd_pcm_substream *substream, | |||
103 | if (ret < 0) | 103 | if (ret < 0) |
104 | return ret; | 104 | return ret; |
105 | 105 | ||
106 | /* Set WM8580 to drive MCLK from it's PLLA */ | 106 | /* Set WM8580 to drive MCLK from its PLLA */ |
107 | ret = snd_soc_dai_set_clkdiv(codec_dai, WM8580_MCLK, | 107 | ret = snd_soc_dai_set_clkdiv(codec_dai, WM8580_MCLK, |
108 | WM8580_CLKSRC_PLLA); | 108 | WM8580_CLKSRC_PLLA); |
109 | if (ret < 0) | 109 | if (ret < 0) |
@@ -115,7 +115,6 @@ static int smdk64xx_hw_params(struct snd_pcm_substream *substream, | |||
115 | if (ret < 0) | 115 | if (ret < 0) |
116 | return ret; | 116 | return ret; |
117 | 117 | ||
118 | /* Assuming the CODEC driver evaluates it's rfs too from this call */ | ||
119 | ret = snd_soc_dai_set_pll(codec_dai, 0, WM8580_PLLA, | 118 | ret = snd_soc_dai_set_pll(codec_dai, 0, WM8580_PLLA, |
120 | SMDK64XX_WM8580_FREQ, pll_out); | 119 | SMDK64XX_WM8580_FREQ, pll_out); |
121 | if (ret < 0) | 120 | if (ret < 0) |
@@ -186,9 +185,10 @@ static int smdk64xx_wm8580_init_paiftx(struct snd_soc_codec *codec) | |||
186 | /* Set up PAIFTX audio path */ | 185 | /* Set up PAIFTX audio path */ |
187 | snd_soc_dapm_add_routes(codec, audio_map_tx, ARRAY_SIZE(audio_map_tx)); | 186 | snd_soc_dapm_add_routes(codec, audio_map_tx, ARRAY_SIZE(audio_map_tx)); |
188 | 187 | ||
189 | /* All enabled by default */ | 188 | /* Enabling the microphone requires the fitting of a 0R |
190 | snd_soc_dapm_enable_pin(codec, "MicIn"); | 189 | * resistor to connect the line from the microphone jack. |
191 | snd_soc_dapm_enable_pin(codec, "LineIn"); | 190 | */ |
191 | snd_soc_dapm_disable_pin(codec, "MicIn"); | ||
192 | 192 | ||
193 | /* signal a DAPM event */ | 193 | /* signal a DAPM event */ |
194 | snd_soc_dapm_sync(codec); | 194 | snd_soc_dapm_sync(codec); |
@@ -205,11 +205,6 @@ static int smdk64xx_wm8580_init_paifrx(struct snd_soc_codec *codec) | |||
205 | /* Set up PAIFRX audio path */ | 205 | /* Set up PAIFRX audio path */ |
206 | snd_soc_dapm_add_routes(codec, audio_map_rx, ARRAY_SIZE(audio_map_rx)); | 206 | snd_soc_dapm_add_routes(codec, audio_map_rx, ARRAY_SIZE(audio_map_rx)); |
207 | 207 | ||
208 | /* All enabled by default */ | ||
209 | snd_soc_dapm_enable_pin(codec, "Front-L/R"); | ||
210 | snd_soc_dapm_enable_pin(codec, "Center/Sub"); | ||
211 | snd_soc_dapm_enable_pin(codec, "Rear-L/R"); | ||
212 | |||
213 | /* signal a DAPM event */ | 208 | /* signal a DAPM event */ |
214 | snd_soc_dapm_sync(codec); | 209 | snd_soc_dapm_sync(codec); |
215 | 210 | ||