diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2010-05-29 18:31:57 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-05-29 18:31:57 -0400 |
commit | 52b0ace7dfe8f70350218017a95d7cab1eb41fbb (patch) | |
tree | e474f8e2c5ac1712e1e1155b879420dde4aa3922 /sound | |
parent | 24010e460454ec0d2f4f0213b667b4349cbdb8e1 (diff) | |
parent | d6695f09ea30de712662fcf8dd0e8c4d4306a15a (diff) |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6: (26 commits)
ALSA: snd-usb-caiaq: Bump version number to 1.3.21
ALSA: Revert "ALSA: snd-usb-caiaq: Set default input mode of A4DJ"
ALSA: snd-usb-caiaq: Simplify single case to an 'if'
ALSA: snd-usb-caiaq: Restore 'Control vinyl' input mode on A4DJ
ALSA: hda: Use LPIB for a Shuttle device
ALSA: hda: Add support for another Lenovo ThinkPad Edge in conexant codec
ALSA: hda: Use LPIB for Sony VPCS11V9E
ALSA: usb-audio: fix feature unit parser for UAC2
ALSA: asihpi - Minor code cleanup
ALSA: asihpi - Add support for new ASI8800 family
ALSA: asihpi - Fix bug preventing outstream_write preload from happening
ALSA: asihpi - Fix imbalanced lock path in hw_message
ALSA: asihpi - Remove support for old ASI8800 family
ALSA: asihpi - Add hd radio blend functions
ALSA: asihpi - Remove unused io map functions
ALSA: usb-audio: add support for UAC2 pitch control
ALSA: usb-audio: parse UAC2 endpoint descriptors correctly
ALSA: usb-audio: fix return values
ALSA: usb-audio: parse more format descriptors with structs
sound: Add missing spin_unlock
...
Diffstat (limited to 'sound')
-rw-r--r-- | sound/mips/au1x00.c | 1 | ||||
-rw-r--r-- | sound/oss/dmasound/dmasound_atari.c | 5 | ||||
-rw-r--r-- | sound/pci/asihpi/hpi.h | 8 | ||||
-rw-r--r-- | sound/pci/asihpi/hpi6000.c | 6 | ||||
-rw-r--r-- | sound/pci/asihpi/hpi6205.c | 21 | ||||
-rw-r--r-- | sound/pci/asihpi/hpi_internal.h | 5 | ||||
-rw-r--r-- | sound/pci/asihpi/hpicmn.c | 38 | ||||
-rw-r--r-- | sound/pci/asihpi/hpifunc.c | 17 | ||||
-rw-r--r-- | sound/pci/asihpi/hpios.c | 23 | ||||
-rw-r--r-- | sound/pci/asihpi/hpios.h | 9 | ||||
-rw-r--r-- | sound/pci/hda/hda_intel.c | 2 | ||||
-rw-r--r-- | sound/pci/hda/patch_conexant.c | 2 | ||||
-rw-r--r-- | sound/soc/codecs/wm8350.c | 4 | ||||
-rw-r--r-- | sound/soc/codecs/wm8400.c | 18 | ||||
-rw-r--r-- | sound/soc/codecs/wm8990.c | 18 | ||||
-rw-r--r-- | sound/soc/imx/imx-pcm-dma-mx2.c | 7 | ||||
-rw-r--r-- | sound/soc/sh/siu_dai.c | 2 | ||||
-rw-r--r-- | sound/usb/caiaq/control.c | 36 | ||||
-rw-r--r-- | sound/usb/caiaq/device.c | 8 | ||||
-rw-r--r-- | sound/usb/endpoint.c | 64 | ||||
-rw-r--r-- | sound/usb/format.c | 24 | ||||
-rw-r--r-- | sound/usb/format.h | 7 | ||||
-rw-r--r-- | sound/usb/mixer.c | 2 | ||||
-rw-r--r-- | sound/usb/pcm.c | 37 |
24 files changed, 184 insertions, 180 deletions
diff --git a/sound/mips/au1x00.c b/sound/mips/au1x00.c index 3e763d6a5d67..446cf9748664 100644 --- a/sound/mips/au1x00.c +++ b/sound/mips/au1x00.c | |||
@@ -516,6 +516,7 @@ get the interrupt driven case to work efficiently */ | |||
516 | break; | 516 | break; |
517 | if (i == 0x5000) { | 517 | if (i == 0x5000) { |
518 | printk(KERN_ERR "au1000 AC97: AC97 command read timeout\n"); | 518 | printk(KERN_ERR "au1000 AC97: AC97 command read timeout\n"); |
519 | spin_unlock(&au1000->ac97_lock); | ||
519 | return 0; | 520 | return 0; |
520 | } | 521 | } |
521 | 522 | ||
diff --git a/sound/oss/dmasound/dmasound_atari.c b/sound/oss/dmasound/dmasound_atari.c index 1f4774123064..13c214466d3b 100644 --- a/sound/oss/dmasound/dmasound_atari.c +++ b/sound/oss/dmasound/dmasound_atari.c | |||
@@ -1277,7 +1277,7 @@ static irqreturn_t AtaInterrupt(int irq, void *dummy) | |||
1277 | * (almost) like on the TT. | 1277 | * (almost) like on the TT. |
1278 | */ | 1278 | */ |
1279 | write_sq_ignore_int = 0; | 1279 | write_sq_ignore_int = 0; |
1280 | return IRQ_HANDLED; | 1280 | goto out; |
1281 | } | 1281 | } |
1282 | 1282 | ||
1283 | if (!write_sq.active) { | 1283 | if (!write_sq.active) { |
@@ -1285,7 +1285,7 @@ static irqreturn_t AtaInterrupt(int irq, void *dummy) | |||
1285 | * the sq variables, so better don't do anything here. | 1285 | * the sq variables, so better don't do anything here. |
1286 | */ | 1286 | */ |
1287 | WAKE_UP(write_sq.sync_queue); | 1287 | WAKE_UP(write_sq.sync_queue); |
1288 | return IRQ_HANDLED; | 1288 | goto out; |
1289 | } | 1289 | } |
1290 | 1290 | ||
1291 | /* Probably ;) one frame is finished. Well, in fact it may be that a | 1291 | /* Probably ;) one frame is finished. Well, in fact it may be that a |
@@ -1322,6 +1322,7 @@ static irqreturn_t AtaInterrupt(int irq, void *dummy) | |||
1322 | /* We are not playing after AtaPlay(), so there | 1322 | /* We are not playing after AtaPlay(), so there |
1323 | is nothing to play any more. Wake up a process | 1323 | is nothing to play any more. Wake up a process |
1324 | waiting for audio output to drain. */ | 1324 | waiting for audio output to drain. */ |
1325 | out: | ||
1325 | spin_unlock(&dmasound.lock); | 1326 | spin_unlock(&dmasound.lock); |
1326 | return IRQ_HANDLED; | 1327 | return IRQ_HANDLED; |
1327 | } | 1328 | } |
diff --git a/sound/pci/asihpi/hpi.h b/sound/pci/asihpi/hpi.h index 99400de6c075..0173bbe62b67 100644 --- a/sound/pci/asihpi/hpi.h +++ b/sound/pci/asihpi/hpi.h | |||
@@ -50,7 +50,7 @@ i.e 3.05.02 is a development version | |||
50 | #define HPI_VER_RELEASE(v) ((int)(v & 0xFF)) | 50 | #define HPI_VER_RELEASE(v) ((int)(v & 0xFF)) |
51 | 51 | ||
52 | /* Use single digits for versions less that 10 to avoid octal. */ | 52 | /* Use single digits for versions less that 10 to avoid octal. */ |
53 | #define HPI_VER HPI_VERSION_CONSTRUCTOR(4L, 3, 18) | 53 | #define HPI_VER HPI_VERSION_CONSTRUCTOR(4L, 3, 25) |
54 | 54 | ||
55 | /* Library version as documented in hpi-api-versions.txt */ | 55 | /* Library version as documented in hpi-api-versions.txt */ |
56 | #define HPI_LIB_VER HPI_VERSION_CONSTRUCTOR(9, 0, 0) | 56 | #define HPI_LIB_VER HPI_VERSION_CONSTRUCTOR(9, 0, 0) |
@@ -1632,6 +1632,12 @@ u16 hpi_tuner_get_hd_radio_sdk_version(const struct hpi_hsubsys *ph_subsys, | |||
1632 | u16 hpi_tuner_get_hd_radio_signal_quality(const struct hpi_hsubsys *ph_subsys, | 1632 | u16 hpi_tuner_get_hd_radio_signal_quality(const struct hpi_hsubsys *ph_subsys, |
1633 | u32 h_control, u32 *pquality); | 1633 | u32 h_control, u32 *pquality); |
1634 | 1634 | ||
1635 | u16 hpi_tuner_get_hd_radio_signal_blend(const struct hpi_hsubsys *ph_subsys, | ||
1636 | u32 h_control, u32 *pblend); | ||
1637 | |||
1638 | u16 hpi_tuner_set_hd_radio_signal_blend(const struct hpi_hsubsys *ph_subsys, | ||
1639 | u32 h_control, const u32 blend); | ||
1640 | |||
1635 | /****************************/ | 1641 | /****************************/ |
1636 | /* PADs control */ | 1642 | /* PADs control */ |
1637 | /****************************/ | 1643 | /****************************/ |
diff --git a/sound/pci/asihpi/hpi6000.c b/sound/pci/asihpi/hpi6000.c index 839ecb2e4b64..12dab5e4892c 100644 --- a/sound/pci/asihpi/hpi6000.c +++ b/sound/pci/asihpi/hpi6000.c | |||
@@ -691,9 +691,6 @@ static short hpi6000_adapter_boot_load_dsp(struct hpi_adapter_obj *pao, | |||
691 | case 0x6200: | 691 | case 0x6200: |
692 | boot_load_family = HPI_ADAPTER_FAMILY_ASI(0x6200); | 692 | boot_load_family = HPI_ADAPTER_FAMILY_ASI(0x6200); |
693 | break; | 693 | break; |
694 | case 0x8800: | ||
695 | boot_load_family = HPI_ADAPTER_FAMILY_ASI(0x8800); | ||
696 | break; | ||
697 | default: | 694 | default: |
698 | return HPI6000_ERROR_UNHANDLED_SUBSYS_ID; | 695 | return HPI6000_ERROR_UNHANDLED_SUBSYS_ID; |
699 | } | 696 | } |
@@ -1775,7 +1772,6 @@ static void hw_message(struct hpi_adapter_obj *pao, struct hpi_message *phm, | |||
1775 | u16 error = 0; | 1772 | u16 error = 0; |
1776 | u16 dsp_index = 0; | 1773 | u16 dsp_index = 0; |
1777 | u16 num_dsp = ((struct hpi_hw_obj *)pao->priv)->num_dsp; | 1774 | u16 num_dsp = ((struct hpi_hw_obj *)pao->priv)->num_dsp; |
1778 | hpios_dsplock_lock(pao); | ||
1779 | 1775 | ||
1780 | if (num_dsp < 2) | 1776 | if (num_dsp < 2) |
1781 | dsp_index = 0; | 1777 | dsp_index = 0; |
@@ -1796,6 +1792,8 @@ static void hw_message(struct hpi_adapter_obj *pao, struct hpi_message *phm, | |||
1796 | } | 1792 | } |
1797 | } | 1793 | } |
1798 | } | 1794 | } |
1795 | |||
1796 | hpios_dsplock_lock(pao); | ||
1799 | error = hpi6000_message_response_sequence(pao, dsp_index, phm, phr); | 1797 | error = hpi6000_message_response_sequence(pao, dsp_index, phm, phr); |
1800 | 1798 | ||
1801 | /* maybe an error response */ | 1799 | /* maybe an error response */ |
diff --git a/sound/pci/asihpi/hpi6205.c b/sound/pci/asihpi/hpi6205.c index 5e88c1fc2b9e..e89991ea3543 100644 --- a/sound/pci/asihpi/hpi6205.c +++ b/sound/pci/asihpi/hpi6205.c | |||
@@ -966,23 +966,16 @@ static void outstream_write(struct hpi_adapter_obj *pao, | |||
966 | status = &interface->outstream_host_buffer_status[phm->obj_index]; | 966 | status = &interface->outstream_host_buffer_status[phm->obj_index]; |
967 | 967 | ||
968 | if (phw->flag_outstream_just_reset[phm->obj_index]) { | 968 | if (phw->flag_outstream_just_reset[phm->obj_index]) { |
969 | /* Format can only change after reset. Must tell DSP. */ | ||
970 | u16 function = phm->function; | ||
971 | phw->flag_outstream_just_reset[phm->obj_index] = 0; | ||
972 | phm->function = HPI_OSTREAM_SET_FORMAT; | ||
973 | hw_message(pao, phm, phr); /* send the format to the DSP */ | ||
974 | phm->function = function; | ||
975 | if (phr->error) | ||
976 | return; | ||
977 | } | ||
978 | #if 1 | ||
979 | if (phw->flag_outstream_just_reset[phm->obj_index]) { | ||
980 | /* First OutStremWrite() call following reset will write data to the | 969 | /* First OutStremWrite() call following reset will write data to the |
981 | adapter's buffers, reducing delay before stream can start | 970 | adapter's buffers, reducing delay before stream can start. The DSP |
971 | takes care of setting the stream data format using format information | ||
972 | embedded in phm. | ||
982 | */ | 973 | */ |
983 | int partial_write = 0; | 974 | int partial_write = 0; |
984 | unsigned int original_size = 0; | 975 | unsigned int original_size = 0; |
985 | 976 | ||
977 | phw->flag_outstream_just_reset[phm->obj_index] = 0; | ||
978 | |||
986 | /* Send the first buffer to the DSP the old way. */ | 979 | /* Send the first buffer to the DSP the old way. */ |
987 | /* Limit size of first transfer - */ | 980 | /* Limit size of first transfer - */ |
988 | /* expect that this will not usually be triggered. */ | 981 | /* expect that this will not usually be triggered. */ |
@@ -1012,7 +1005,6 @@ static void outstream_write(struct hpi_adapter_obj *pao, | |||
1012 | original_size - HPI6205_SIZEOF_DATA; | 1005 | original_size - HPI6205_SIZEOF_DATA; |
1013 | phm->u.d.u.data.pb_data += HPI6205_SIZEOF_DATA; | 1006 | phm->u.d.u.data.pb_data += HPI6205_SIZEOF_DATA; |
1014 | } | 1007 | } |
1015 | #endif | ||
1016 | 1008 | ||
1017 | space_available = outstream_get_space_available(status); | 1009 | space_available = outstream_get_space_available(status); |
1018 | if (space_available < (long)phm->u.d.u.data.data_size) { | 1010 | if (space_available < (long)phm->u.d.u.data.data_size) { |
@@ -1369,6 +1361,9 @@ static u16 adapter_boot_load_dsp(struct hpi_adapter_obj *pao, | |||
1369 | case HPI_ADAPTER_FAMILY_ASI(0x6500): | 1361 | case HPI_ADAPTER_FAMILY_ASI(0x6500): |
1370 | firmware_id = HPI_ADAPTER_FAMILY_ASI(0x6600); | 1362 | firmware_id = HPI_ADAPTER_FAMILY_ASI(0x6600); |
1371 | break; | 1363 | break; |
1364 | case HPI_ADAPTER_FAMILY_ASI(0x8800): | ||
1365 | firmware_id = HPI_ADAPTER_FAMILY_ASI(0x8900); | ||
1366 | break; | ||
1372 | } | 1367 | } |
1373 | boot_code_id[1] = firmware_id; | 1368 | boot_code_id[1] = firmware_id; |
1374 | 1369 | ||
diff --git a/sound/pci/asihpi/hpi_internal.h b/sound/pci/asihpi/hpi_internal.h index f1cd6f1a0d44..fdd0ce02aa68 100644 --- a/sound/pci/asihpi/hpi_internal.h +++ b/sound/pci/asihpi/hpi_internal.h | |||
@@ -232,6 +232,8 @@ enum HPI_BUSES { | |||
232 | #define HPI_TUNER_HDRADIO_SDK_VERSION HPI_CTL_ATTR(TUNER, 13) | 232 | #define HPI_TUNER_HDRADIO_SDK_VERSION HPI_CTL_ATTR(TUNER, 13) |
233 | /** HD Radio DSP firmware version. */ | 233 | /** HD Radio DSP firmware version. */ |
234 | #define HPI_TUNER_HDRADIO_DSP_VERSION HPI_CTL_ATTR(TUNER, 14) | 234 | #define HPI_TUNER_HDRADIO_DSP_VERSION HPI_CTL_ATTR(TUNER, 14) |
235 | /** HD Radio signal blend (force analog, or automatic). */ | ||
236 | #define HPI_TUNER_HDRADIO_BLEND HPI_CTL_ATTR(TUNER, 15) | ||
235 | 237 | ||
236 | /** \} */ | 238 | /** \} */ |
237 | 239 | ||
@@ -478,8 +480,10 @@ Threshold is a -ve number in units of dB/100, | |||
478 | 480 | ||
479 | /** First 2 hex digits define the adapter family */ | 481 | /** First 2 hex digits define the adapter family */ |
480 | #define HPI_ADAPTER_FAMILY_MASK 0xff00 | 482 | #define HPI_ADAPTER_FAMILY_MASK 0xff00 |
483 | #define HPI_MODULE_FAMILY_MASK 0xfff0 | ||
481 | 484 | ||
482 | #define HPI_ADAPTER_FAMILY_ASI(f) (f & HPI_ADAPTER_FAMILY_MASK) | 485 | #define HPI_ADAPTER_FAMILY_ASI(f) (f & HPI_ADAPTER_FAMILY_MASK) |
486 | #define HPI_MODULE_FAMILY_ASI(f) (f & HPI_MODULE_FAMILY_MASK) | ||
483 | #define HPI_ADAPTER_ASI(f) (f) | 487 | #define HPI_ADAPTER_ASI(f) (f) |
484 | 488 | ||
485 | /******************************************* message types */ | 489 | /******************************************* message types */ |
@@ -970,6 +974,7 @@ struct hpi_control_union_msg { | |||
970 | u32 mode; | 974 | u32 mode; |
971 | u32 value; | 975 | u32 value; |
972 | } mode; | 976 | } mode; |
977 | u32 blend; | ||
973 | } tuner; | 978 | } tuner; |
974 | } u; | 979 | } u; |
975 | }; | 980 | }; |
diff --git a/sound/pci/asihpi/hpicmn.c b/sound/pci/asihpi/hpicmn.c index 565102cae4f8..fcd64539d9ef 100644 --- a/sound/pci/asihpi/hpicmn.c +++ b/sound/pci/asihpi/hpicmn.c | |||
@@ -347,20 +347,15 @@ short hpi_check_control_cache(struct hpi_control_cache *p_cache, | |||
347 | found = 0; | 347 | found = 0; |
348 | break; | 348 | break; |
349 | case HPI_CONTROL_TUNER: | 349 | case HPI_CONTROL_TUNER: |
350 | { | 350 | if (phm->u.c.attribute == HPI_TUNER_FREQ) |
351 | struct hpi_control_cache_single *pCT = | 351 | phr->u.c.param1 = pC->u.t.freq_ink_hz; |
352 | (struct hpi_control_cache_single *)pI; | 352 | else if (phm->u.c.attribute == HPI_TUNER_BAND) |
353 | if (phm->u.c.attribute == HPI_TUNER_FREQ) | 353 | phr->u.c.param1 = pC->u.t.band; |
354 | phr->u.c.param1 = pCT->u.t.freq_ink_hz; | 354 | else if ((phm->u.c.attribute == HPI_TUNER_LEVEL) |
355 | else if (phm->u.c.attribute == HPI_TUNER_BAND) | 355 | && (phm->u.c.param1 == HPI_TUNER_LEVEL_AVERAGE)) |
356 | phr->u.c.param1 = pCT->u.t.band; | 356 | phr->u.c.param1 = pC->u.t.level; |
357 | else if ((phm->u.c.attribute == HPI_TUNER_LEVEL) | 357 | else |
358 | && (phm->u.c.param1 == | 358 | found = 0; |
359 | HPI_TUNER_LEVEL_AVERAGE)) | ||
360 | phr->u.c.param1 = pCT->u.t.level; | ||
361 | else | ||
362 | found = 0; | ||
363 | } | ||
364 | break; | 359 | break; |
365 | case HPI_CONTROL_AESEBU_RECEIVER: | 360 | case HPI_CONTROL_AESEBU_RECEIVER: |
366 | if (phm->u.c.attribute == HPI_AESEBURX_ERRORSTATUS) | 361 | if (phm->u.c.attribute == HPI_AESEBURX_ERRORSTATUS) |
@@ -503,6 +498,9 @@ void hpi_sync_control_cache(struct hpi_control_cache *p_cache, | |||
503 | struct hpi_control_cache_single *pC; | 498 | struct hpi_control_cache_single *pC; |
504 | struct hpi_control_cache_info *pI; | 499 | struct hpi_control_cache_info *pI; |
505 | 500 | ||
501 | if (phr->error) | ||
502 | return; | ||
503 | |||
506 | if (!find_control(phm, p_cache, &pI, &control_index)) | 504 | if (!find_control(phm, p_cache, &pI, &control_index)) |
507 | return; | 505 | return; |
508 | 506 | ||
@@ -520,8 +518,6 @@ void hpi_sync_control_cache(struct hpi_control_cache *p_cache, | |||
520 | break; | 518 | break; |
521 | case HPI_CONTROL_MULTIPLEXER: | 519 | case HPI_CONTROL_MULTIPLEXER: |
522 | /* mux does not return its setting on Set command. */ | 520 | /* mux does not return its setting on Set command. */ |
523 | if (phr->error) | ||
524 | return; | ||
525 | if (phm->u.c.attribute == HPI_MULTIPLEXER_SOURCE) { | 521 | if (phm->u.c.attribute == HPI_MULTIPLEXER_SOURCE) { |
526 | pC->u.x.source_node_type = (u16)phm->u.c.param1; | 522 | pC->u.x.source_node_type = (u16)phm->u.c.param1; |
527 | pC->u.x.source_node_index = (u16)phm->u.c.param2; | 523 | pC->u.x.source_node_index = (u16)phm->u.c.param2; |
@@ -529,8 +525,6 @@ void hpi_sync_control_cache(struct hpi_control_cache *p_cache, | |||
529 | break; | 525 | break; |
530 | case HPI_CONTROL_CHANNEL_MODE: | 526 | case HPI_CONTROL_CHANNEL_MODE: |
531 | /* mode does not return its setting on Set command. */ | 527 | /* mode does not return its setting on Set command. */ |
532 | if (phr->error) | ||
533 | return; | ||
534 | if (phm->u.c.attribute == HPI_CHANNEL_MODE_MODE) | 528 | if (phm->u.c.attribute == HPI_CHANNEL_MODE_MODE) |
535 | pC->u.m.mode = (u16)phm->u.c.param1; | 529 | pC->u.m.mode = (u16)phm->u.c.param1; |
536 | break; | 530 | break; |
@@ -545,20 +539,14 @@ void hpi_sync_control_cache(struct hpi_control_cache *p_cache, | |||
545 | pC->u.phantom_power.state = (u16)phm->u.c.param1; | 539 | pC->u.phantom_power.state = (u16)phm->u.c.param1; |
546 | break; | 540 | break; |
547 | case HPI_CONTROL_AESEBU_TRANSMITTER: | 541 | case HPI_CONTROL_AESEBU_TRANSMITTER: |
548 | if (phr->error) | ||
549 | return; | ||
550 | if (phm->u.c.attribute == HPI_AESEBUTX_FORMAT) | 542 | if (phm->u.c.attribute == HPI_AESEBUTX_FORMAT) |
551 | pC->u.aes3tx.format = phm->u.c.param1; | 543 | pC->u.aes3tx.format = phm->u.c.param1; |
552 | break; | 544 | break; |
553 | case HPI_CONTROL_AESEBU_RECEIVER: | 545 | case HPI_CONTROL_AESEBU_RECEIVER: |
554 | if (phr->error) | ||
555 | return; | ||
556 | if (phm->u.c.attribute == HPI_AESEBURX_FORMAT) | 546 | if (phm->u.c.attribute == HPI_AESEBURX_FORMAT) |
557 | pC->u.aes3rx.source = phm->u.c.param1; | 547 | pC->u.aes3rx.source = phm->u.c.param1; |
558 | break; | 548 | break; |
559 | case HPI_CONTROL_SAMPLECLOCK: | 549 | case HPI_CONTROL_SAMPLECLOCK: |
560 | if (phr->error) | ||
561 | return; | ||
562 | if (phm->u.c.attribute == HPI_SAMPLECLOCK_SOURCE) | 550 | if (phm->u.c.attribute == HPI_SAMPLECLOCK_SOURCE) |
563 | pC->u.clk.source = (u16)phm->u.c.param1; | 551 | pC->u.clk.source = (u16)phm->u.c.param1; |
564 | else if (phm->u.c.attribute == HPI_SAMPLECLOCK_SOURCE_INDEX) | 552 | else if (phm->u.c.attribute == HPI_SAMPLECLOCK_SOURCE_INDEX) |
@@ -590,7 +578,7 @@ struct hpi_control_cache *hpi_alloc_control_cache(const u32 | |||
590 | 578 | ||
591 | void hpi_free_control_cache(struct hpi_control_cache *p_cache) | 579 | void hpi_free_control_cache(struct hpi_control_cache *p_cache) |
592 | { | 580 | { |
593 | if ((p_cache->init) && (p_cache->p_info)) { | 581 | if (p_cache->init) { |
594 | kfree(p_cache->p_info); | 582 | kfree(p_cache->p_info); |
595 | p_cache->p_info = NULL; | 583 | p_cache->p_info = NULL; |
596 | p_cache->init = 0; | 584 | p_cache->init = 0; |
diff --git a/sound/pci/asihpi/hpifunc.c b/sound/pci/asihpi/hpifunc.c index eda26b312324..298eef3e20e9 100644 --- a/sound/pci/asihpi/hpifunc.c +++ b/sound/pci/asihpi/hpifunc.c | |||
@@ -2946,6 +2946,20 @@ u16 hpi_tuner_get_hd_radio_signal_quality(const struct hpi_hsubsys *ph_subsys, | |||
2946 | HPI_TUNER_HDRADIO_SIGNAL_QUALITY, 0, 0, pquality, NULL); | 2946 | HPI_TUNER_HDRADIO_SIGNAL_QUALITY, 0, 0, pquality, NULL); |
2947 | } | 2947 | } |
2948 | 2948 | ||
2949 | u16 hpi_tuner_get_hd_radio_signal_blend(const struct hpi_hsubsys *ph_subsys, | ||
2950 | u32 h_control, u32 *pblend) | ||
2951 | { | ||
2952 | return hpi_control_param_get(ph_subsys, h_control, | ||
2953 | HPI_TUNER_HDRADIO_BLEND, 0, 0, pblend, NULL); | ||
2954 | } | ||
2955 | |||
2956 | u16 hpi_tuner_set_hd_radio_signal_blend(const struct hpi_hsubsys *ph_subsys, | ||
2957 | u32 h_control, const u32 blend) | ||
2958 | { | ||
2959 | return hpi_control_param_set(ph_subsys, h_control, | ||
2960 | HPI_TUNER_HDRADIO_BLEND, blend, 0); | ||
2961 | } | ||
2962 | |||
2949 | u16 hpi_tuner_getRDS(const struct hpi_hsubsys *ph_subsys, u32 h_control, | 2963 | u16 hpi_tuner_getRDS(const struct hpi_hsubsys *ph_subsys, u32 h_control, |
2950 | char *p_data) | 2964 | char *p_data) |
2951 | { | 2965 | { |
@@ -3266,8 +3280,7 @@ u16 hpi_entity_find_next(struct hpi_entity *container_entity, | |||
3266 | 3280 | ||
3267 | void hpi_entity_free(struct hpi_entity *entity) | 3281 | void hpi_entity_free(struct hpi_entity *entity) |
3268 | { | 3282 | { |
3269 | if (entity != NULL) | 3283 | kfree(entity); |
3270 | kfree(entity); | ||
3271 | } | 3284 | } |
3272 | 3285 | ||
3273 | static u16 hpi_entity_alloc_and_copy(struct hpi_entity *src, | 3286 | static u16 hpi_entity_alloc_and_copy(struct hpi_entity *src, |
diff --git a/sound/pci/asihpi/hpios.c b/sound/pci/asihpi/hpios.c index de615cfdb950..742ee12a9e17 100644 --- a/sound/pci/asihpi/hpios.c +++ b/sound/pci/asihpi/hpios.c | |||
@@ -89,26 +89,3 @@ u16 hpios_locked_mem_free(struct consistent_dma_area *p_mem_area) | |||
89 | void hpios_locked_mem_free_all(void) | 89 | void hpios_locked_mem_free_all(void) |
90 | { | 90 | { |
91 | } | 91 | } |
92 | |||
93 | void __iomem *hpios_map_io(struct pci_dev *pci_dev, int idx, | ||
94 | unsigned int length) | ||
95 | { | ||
96 | HPI_DEBUG_LOG(DEBUG, "mapping %d %s %08llx-%08llx %04llx len 0x%x\n", | ||
97 | idx, pci_dev->resource[idx].name, | ||
98 | (unsigned long long)pci_resource_start(pci_dev, idx), | ||
99 | (unsigned long long)pci_resource_end(pci_dev, idx), | ||
100 | (unsigned long long)pci_resource_flags(pci_dev, idx), length); | ||
101 | |||
102 | if (!(pci_resource_flags(pci_dev, idx) & IORESOURCE_MEM)) { | ||
103 | HPI_DEBUG_LOG(ERROR, "not an io memory resource\n"); | ||
104 | return NULL; | ||
105 | } | ||
106 | |||
107 | if (length > pci_resource_len(pci_dev, idx)) { | ||
108 | HPI_DEBUG_LOG(ERROR, "resource too small for requested %d \n", | ||
109 | length); | ||
110 | return NULL; | ||
111 | } | ||
112 | |||
113 | return ioremap(pci_resource_start(pci_dev, idx), length); | ||
114 | } | ||
diff --git a/sound/pci/asihpi/hpios.h b/sound/pci/asihpi/hpios.h index a62c3f1e5f09..370f39b43f85 100644 --- a/sound/pci/asihpi/hpios.h +++ b/sound/pci/asihpi/hpios.h | |||
@@ -166,13 +166,4 @@ struct hpi_adapter { | |||
166 | void __iomem *ap_remapped_mem_base[HPI_MAX_ADAPTER_MEM_SPACES]; | 166 | void __iomem *ap_remapped_mem_base[HPI_MAX_ADAPTER_MEM_SPACES]; |
167 | }; | 167 | }; |
168 | 168 | ||
169 | static inline void hpios_unmap_io(void __iomem *addr, | ||
170 | unsigned long size) | ||
171 | { | ||
172 | iounmap(addr); | ||
173 | } | ||
174 | |||
175 | void __iomem *hpios_map_io(struct pci_dev *pci_dev, int idx, | ||
176 | unsigned int length); | ||
177 | |||
178 | #endif | 169 | #endif |
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 77e22c2a8caa..dc79564fea30 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c | |||
@@ -2288,8 +2288,10 @@ static struct snd_pci_quirk position_fix_list[] __devinitdata = { | |||
2288 | SND_PCI_QUIRK(0x1028, 0x01f6, "Dell Latitude 131L", POS_FIX_LPIB), | 2288 | SND_PCI_QUIRK(0x1028, 0x01f6, "Dell Latitude 131L", POS_FIX_LPIB), |
2289 | SND_PCI_QUIRK(0x103c, 0x306d, "HP dv3", POS_FIX_LPIB), | 2289 | SND_PCI_QUIRK(0x103c, 0x306d, "HP dv3", POS_FIX_LPIB), |
2290 | SND_PCI_QUIRK(0x1043, 0x813d, "ASUS P5AD2", POS_FIX_LPIB), | 2290 | SND_PCI_QUIRK(0x1043, 0x813d, "ASUS P5AD2", POS_FIX_LPIB), |
2291 | SND_PCI_QUIRK(0x104d, 0x9069, "Sony VPCS11V9E", POS_FIX_LPIB), | ||
2291 | SND_PCI_QUIRK(0x1106, 0x3288, "ASUS M2V-MX SE", POS_FIX_LPIB), | 2292 | SND_PCI_QUIRK(0x1106, 0x3288, "ASUS M2V-MX SE", POS_FIX_LPIB), |
2292 | SND_PCI_QUIRK(0x1179, 0xff10, "Toshiba A100-259", POS_FIX_LPIB), | 2293 | SND_PCI_QUIRK(0x1179, 0xff10, "Toshiba A100-259", POS_FIX_LPIB), |
2294 | SND_PCI_QUIRK(0x1297, 0x3166, "Shuttle", POS_FIX_LPIB), | ||
2293 | SND_PCI_QUIRK(0x1458, 0xa022, "ga-ma770-ud3", POS_FIX_LPIB), | 2295 | SND_PCI_QUIRK(0x1458, 0xa022, "ga-ma770-ud3", POS_FIX_LPIB), |
2294 | SND_PCI_QUIRK(0x1462, 0x1002, "MSI Wind U115", POS_FIX_LPIB), | 2296 | SND_PCI_QUIRK(0x1462, 0x1002, "MSI Wind U115", POS_FIX_LPIB), |
2295 | SND_PCI_QUIRK(0x1565, 0x820f, "Biostar Microtech", POS_FIX_LPIB), | 2297 | SND_PCI_QUIRK(0x1565, 0x820f, "Biostar Microtech", POS_FIX_LPIB), |
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index e863649d31f5..2bf2cb5da956 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c | |||
@@ -2975,6 +2975,8 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = { | |||
2975 | SND_PCI_QUIRK(0x1179, 0xff50, "Toshiba Satellite P500-PSPGSC-01800T", CXT5066_OLPC_XO_1_5), | 2975 | SND_PCI_QUIRK(0x1179, 0xff50, "Toshiba Satellite P500-PSPGSC-01800T", CXT5066_OLPC_XO_1_5), |
2976 | SND_PCI_QUIRK(0x1179, 0xffe0, "Toshiba Satellite Pro T130-15F", CXT5066_OLPC_XO_1_5), | 2976 | SND_PCI_QUIRK(0x1179, 0xffe0, "Toshiba Satellite Pro T130-15F", CXT5066_OLPC_XO_1_5), |
2977 | SND_PCI_QUIRK(0x17aa, 0x21b2, "Thinkpad X100e", CXT5066_IDEAPAD), | 2977 | SND_PCI_QUIRK(0x17aa, 0x21b2, "Thinkpad X100e", CXT5066_IDEAPAD), |
2978 | SND_PCI_QUIRK(0x17aa, 0x21b3, "Thinkpad Edge 13 (197)", CXT5066_IDEAPAD), | ||
2979 | SND_PCI_QUIRK(0x17aa, 0x21b4, "Thinkpad Edge", CXT5066_IDEAPAD), | ||
2978 | SND_PCI_QUIRK(0x17aa, 0x3a0d, "ideapad", CXT5066_IDEAPAD), | 2980 | SND_PCI_QUIRK(0x17aa, 0x3a0d, "ideapad", CXT5066_IDEAPAD), |
2979 | SND_PCI_QUIRK(0x17aa, 0x215e, "Lenovo Thinkpad", CXT5066_THINKPAD), | 2981 | SND_PCI_QUIRK(0x17aa, 0x215e, "Lenovo Thinkpad", CXT5066_THINKPAD), |
2980 | {} | 2982 | {} |
diff --git a/sound/soc/codecs/wm8350.c b/sound/soc/codecs/wm8350.c index 8ae20208e7be..0221ca79b3ae 100644 --- a/sound/soc/codecs/wm8350.c +++ b/sound/soc/codecs/wm8350.c | |||
@@ -426,8 +426,8 @@ static const struct soc_enum wm8350_enum[] = { | |||
426 | SOC_ENUM_SINGLE(WM8350_INPUT_MIXER_VOLUME, 15, 2, wm8350_lr), | 426 | SOC_ENUM_SINGLE(WM8350_INPUT_MIXER_VOLUME, 15, 2, wm8350_lr), |
427 | }; | 427 | }; |
428 | 428 | ||
429 | static DECLARE_TLV_DB_LINEAR(pre_amp_tlv, -1200, 3525); | 429 | static DECLARE_TLV_DB_SCALE(pre_amp_tlv, -1200, 3525, 0); |
430 | static DECLARE_TLV_DB_LINEAR(out_pga_tlv, -5700, 600); | 430 | static DECLARE_TLV_DB_SCALE(out_pga_tlv, -5700, 600, 0); |
431 | static DECLARE_TLV_DB_SCALE(dac_pcm_tlv, -7163, 36, 1); | 431 | static DECLARE_TLV_DB_SCALE(dac_pcm_tlv, -7163, 36, 1); |
432 | static DECLARE_TLV_DB_SCALE(adc_pcm_tlv, -12700, 50, 1); | 432 | static DECLARE_TLV_DB_SCALE(adc_pcm_tlv, -12700, 50, 1); |
433 | static DECLARE_TLV_DB_SCALE(out_mix_tlv, -1500, 300, 1); | 433 | static DECLARE_TLV_DB_SCALE(out_mix_tlv, -1500, 300, 1); |
diff --git a/sound/soc/codecs/wm8400.c b/sound/soc/codecs/wm8400.c index 7f5d080536a0..8f294066b0ed 100644 --- a/sound/soc/codecs/wm8400.c +++ b/sound/soc/codecs/wm8400.c | |||
@@ -107,21 +107,21 @@ static void wm8400_codec_reset(struct snd_soc_codec *codec) | |||
107 | wm8400_reset_codec_reg_cache(wm8400->wm8400); | 107 | wm8400_reset_codec_reg_cache(wm8400->wm8400); |
108 | } | 108 | } |
109 | 109 | ||
110 | static const DECLARE_TLV_DB_LINEAR(rec_mix_tlv, -1500, 600); | 110 | static const DECLARE_TLV_DB_SCALE(rec_mix_tlv, -1500, 600, 0); |
111 | 111 | ||
112 | static const DECLARE_TLV_DB_LINEAR(in_pga_tlv, -1650, 3000); | 112 | static const DECLARE_TLV_DB_SCALE(in_pga_tlv, -1650, 3000, 0); |
113 | 113 | ||
114 | static const DECLARE_TLV_DB_LINEAR(out_mix_tlv, -2100, 0); | 114 | static const DECLARE_TLV_DB_SCALE(out_mix_tlv, -2100, 0, 0); |
115 | 115 | ||
116 | static const DECLARE_TLV_DB_LINEAR(out_pga_tlv, -7300, 600); | 116 | static const DECLARE_TLV_DB_SCALE(out_pga_tlv, -7300, 600, 0); |
117 | 117 | ||
118 | static const DECLARE_TLV_DB_LINEAR(out_omix_tlv, -600, 0); | 118 | static const DECLARE_TLV_DB_SCALE(out_omix_tlv, -600, 0, 0); |
119 | 119 | ||
120 | static const DECLARE_TLV_DB_LINEAR(out_dac_tlv, -7163, 0); | 120 | static const DECLARE_TLV_DB_SCALE(out_dac_tlv, -7163, 0, 0); |
121 | 121 | ||
122 | static const DECLARE_TLV_DB_LINEAR(in_adc_tlv, -7163, 1763); | 122 | static const DECLARE_TLV_DB_SCALE(in_adc_tlv, -7163, 1763, 0); |
123 | 123 | ||
124 | static const DECLARE_TLV_DB_LINEAR(out_sidetone_tlv, -3600, 0); | 124 | static const DECLARE_TLV_DB_SCALE(out_sidetone_tlv, -3600, 0, 0); |
125 | 125 | ||
126 | static int wm8400_outpga_put_volsw_vu(struct snd_kcontrol *kcontrol, | 126 | static int wm8400_outpga_put_volsw_vu(struct snd_kcontrol *kcontrol, |
127 | struct snd_ctl_elem_value *ucontrol) | 127 | struct snd_ctl_elem_value *ucontrol) |
@@ -440,7 +440,7 @@ static int outmixer_event (struct snd_soc_dapm_widget *w, | |||
440 | /* INMIX dB values */ | 440 | /* INMIX dB values */ |
441 | static const unsigned int in_mix_tlv[] = { | 441 | static const unsigned int in_mix_tlv[] = { |
442 | TLV_DB_RANGE_HEAD(1), | 442 | TLV_DB_RANGE_HEAD(1), |
443 | 0,7, TLV_DB_LINEAR_ITEM(-1200, 600), | 443 | 0,7, TLV_DB_SCALE_ITEM(-1200, 600, 0), |
444 | }; | 444 | }; |
445 | 445 | ||
446 | /* Left In PGA Connections */ | 446 | /* Left In PGA Connections */ |
diff --git a/sound/soc/codecs/wm8990.c b/sound/soc/codecs/wm8990.c index 7b536d923ea9..c018772cc430 100644 --- a/sound/soc/codecs/wm8990.c +++ b/sound/soc/codecs/wm8990.c | |||
@@ -111,21 +111,21 @@ static const u16 wm8990_reg[] = { | |||
111 | 111 | ||
112 | #define wm8990_reset(c) snd_soc_write(c, WM8990_RESET, 0) | 112 | #define wm8990_reset(c) snd_soc_write(c, WM8990_RESET, 0) |
113 | 113 | ||
114 | static const DECLARE_TLV_DB_LINEAR(rec_mix_tlv, -1500, 600); | 114 | static const DECLARE_TLV_DB_SCALE(rec_mix_tlv, -1500, 600, 0); |
115 | 115 | ||
116 | static const DECLARE_TLV_DB_LINEAR(in_pga_tlv, -1650, 3000); | 116 | static const DECLARE_TLV_DB_SCALE(in_pga_tlv, -1650, 3000, 0); |
117 | 117 | ||
118 | static const DECLARE_TLV_DB_LINEAR(out_mix_tlv, 0, -2100); | 118 | static const DECLARE_TLV_DB_SCALE(out_mix_tlv, 0, -2100, 0); |
119 | 119 | ||
120 | static const DECLARE_TLV_DB_LINEAR(out_pga_tlv, -7300, 600); | 120 | static const DECLARE_TLV_DB_SCALE(out_pga_tlv, -7300, 600, 0); |
121 | 121 | ||
122 | static const DECLARE_TLV_DB_LINEAR(out_omix_tlv, -600, 0); | 122 | static const DECLARE_TLV_DB_SCALE(out_omix_tlv, -600, 0, 0); |
123 | 123 | ||
124 | static const DECLARE_TLV_DB_LINEAR(out_dac_tlv, -7163, 0); | 124 | static const DECLARE_TLV_DB_SCALE(out_dac_tlv, -7163, 0, 0); |
125 | 125 | ||
126 | static const DECLARE_TLV_DB_LINEAR(in_adc_tlv, -7163, 1763); | 126 | static const DECLARE_TLV_DB_SCALE(in_adc_tlv, -7163, 1763, 0); |
127 | 127 | ||
128 | static const DECLARE_TLV_DB_LINEAR(out_sidetone_tlv, -3600, 0); | 128 | static const DECLARE_TLV_DB_SCALE(out_sidetone_tlv, -3600, 0, 0); |
129 | 129 | ||
130 | static int wm899x_outpga_put_volsw_vu(struct snd_kcontrol *kcontrol, | 130 | static int wm899x_outpga_put_volsw_vu(struct snd_kcontrol *kcontrol, |
131 | struct snd_ctl_elem_value *ucontrol) | 131 | struct snd_ctl_elem_value *ucontrol) |
@@ -451,7 +451,7 @@ static int outmixer_event(struct snd_soc_dapm_widget *w, | |||
451 | /* INMIX dB values */ | 451 | /* INMIX dB values */ |
452 | static const unsigned int in_mix_tlv[] = { | 452 | static const unsigned int in_mix_tlv[] = { |
453 | TLV_DB_RANGE_HEAD(1), | 453 | TLV_DB_RANGE_HEAD(1), |
454 | 0, 7, TLV_DB_LINEAR_ITEM(-1200, 600), | 454 | 0, 7, TLV_DB_SCALE_ITEM(-1200, 600, 0), |
455 | }; | 455 | }; |
456 | 456 | ||
457 | /* Left In PGA Connections */ | 457 | /* Left In PGA Connections */ |
diff --git a/sound/soc/imx/imx-pcm-dma-mx2.c b/sound/soc/imx/imx-pcm-dma-mx2.c index 2b31ac673ea4..05f19c9284f4 100644 --- a/sound/soc/imx/imx-pcm-dma-mx2.c +++ b/sound/soc/imx/imx-pcm-dma-mx2.c | |||
@@ -73,7 +73,8 @@ static void snd_imx_dma_err_callback(int channel, void *data, int err) | |||
73 | { | 73 | { |
74 | struct snd_pcm_substream *substream = data; | 74 | struct snd_pcm_substream *substream = data; |
75 | struct snd_soc_pcm_runtime *rtd = substream->private_data; | 75 | struct snd_soc_pcm_runtime *rtd = substream->private_data; |
76 | struct imx_pcm_dma_params *dma_params = rtd->dai->cpu_dai->dma_data; | 76 | struct imx_pcm_dma_params *dma_params = |
77 | snd_soc_dai_get_dma_data(rtd->dai->cpu_dai, substream); | ||
77 | struct snd_pcm_runtime *runtime = substream->runtime; | 78 | struct snd_pcm_runtime *runtime = substream->runtime; |
78 | struct imx_pcm_runtime_data *iprtd = runtime->private_data; | 79 | struct imx_pcm_runtime_data *iprtd = runtime->private_data; |
79 | int ret; | 80 | int ret; |
@@ -102,7 +103,7 @@ static int imx_ssi_dma_alloc(struct snd_pcm_substream *substream) | |||
102 | struct imx_pcm_runtime_data *iprtd = runtime->private_data; | 103 | struct imx_pcm_runtime_data *iprtd = runtime->private_data; |
103 | int ret; | 104 | int ret; |
104 | 105 | ||
105 | dma_params = snd_soc_get_dma_data(rtd->dai->cpu_dai, substream); | 106 | dma_params = snd_soc_dai_get_dma_data(rtd->dai->cpu_dai, substream); |
106 | 107 | ||
107 | iprtd->dma = imx_dma_request_by_prio(DRV_NAME, DMA_PRIO_HIGH); | 108 | iprtd->dma = imx_dma_request_by_prio(DRV_NAME, DMA_PRIO_HIGH); |
108 | if (iprtd->dma < 0) { | 109 | if (iprtd->dma < 0) { |
@@ -212,7 +213,7 @@ static int snd_imx_pcm_prepare(struct snd_pcm_substream *substream) | |||
212 | struct imx_pcm_runtime_data *iprtd = runtime->private_data; | 213 | struct imx_pcm_runtime_data *iprtd = runtime->private_data; |
213 | int err; | 214 | int err; |
214 | 215 | ||
215 | dma_params = snd_soc_get_dma_data(rtd->dai->cpu_dai, substream); | 216 | dma_params = snd_soc_dai_get_dma_data(rtd->dai->cpu_dai, substream); |
216 | 217 | ||
217 | iprtd->substream = substream; | 218 | iprtd->substream = substream; |
218 | iprtd->buf = (unsigned int *)substream->dma_buffer.area; | 219 | iprtd->buf = (unsigned int *)substream->dma_buffer.area; |
diff --git a/sound/soc/sh/siu_dai.c b/sound/soc/sh/siu_dai.c index d86ee1bfc03a..eeed5edd722b 100644 --- a/sound/soc/sh/siu_dai.c +++ b/sound/soc/sh/siu_dai.c | |||
@@ -588,6 +588,8 @@ static int siu_dai_prepare(struct snd_pcm_substream *substream, | |||
588 | ret = siu_dai_spbstart(port_info); | 588 | ret = siu_dai_spbstart(port_info); |
589 | if (ret < 0) | 589 | if (ret < 0) |
590 | goto fail; | 590 | goto fail; |
591 | } else { | ||
592 | ret = 0; | ||
591 | } | 593 | } |
592 | 594 | ||
593 | port_info->play_cap |= self; | 595 | port_info->play_cap |= self; |
diff --git a/sound/usb/caiaq/control.c b/sound/usb/caiaq/control.c index 36ed703a7416..91c804cd2782 100644 --- a/sound/usb/caiaq/control.c +++ b/sound/usb/caiaq/control.c | |||
@@ -42,21 +42,12 @@ static int control_info(struct snd_kcontrol *kcontrol, | |||
42 | 42 | ||
43 | switch (dev->chip.usb_id) { | 43 | switch (dev->chip.usb_id) { |
44 | case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO8DJ): | 44 | case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO8DJ): |
45 | if (pos == 0) { | ||
46 | /* current input mode of A8DJ */ | ||
47 | uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; | ||
48 | uinfo->value.integer.min = 0; | ||
49 | uinfo->value.integer.max = 2; | ||
50 | return 0; | ||
51 | } | ||
52 | break; | ||
53 | |||
54 | case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO4DJ): | 45 | case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO4DJ): |
55 | if (pos == 0) { | 46 | if (pos == 0) { |
56 | /* current input mode of A4DJ */ | 47 | /* current input mode of A8DJ and A4DJ */ |
57 | uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; | 48 | uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; |
58 | uinfo->value.integer.min = 0; | 49 | uinfo->value.integer.min = 0; |
59 | uinfo->value.integer.max = 1; | 50 | uinfo->value.integer.max = 2; |
60 | return 0; | 51 | return 0; |
61 | } | 52 | } |
62 | break; | 53 | break; |
@@ -86,14 +77,6 @@ static int control_get(struct snd_kcontrol *kcontrol, | |||
86 | struct snd_usb_caiaqdev *dev = caiaqdev(chip->card); | 77 | struct snd_usb_caiaqdev *dev = caiaqdev(chip->card); |
87 | int pos = kcontrol->private_value; | 78 | int pos = kcontrol->private_value; |
88 | 79 | ||
89 | if (dev->chip.usb_id == | ||
90 | USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO4DJ)) { | ||
91 | /* A4DJ has only one control */ | ||
92 | /* do not expose hardware input mode 0 */ | ||
93 | ucontrol->value.integer.value[0] = dev->control_state[0] - 1; | ||
94 | return 0; | ||
95 | } | ||
96 | |||
97 | if (pos & CNT_INTVAL) | 80 | if (pos & CNT_INTVAL) |
98 | ucontrol->value.integer.value[0] | 81 | ucontrol->value.integer.value[0] |
99 | = dev->control_state[pos & ~CNT_INTVAL]; | 82 | = dev->control_state[pos & ~CNT_INTVAL]; |
@@ -112,20 +95,9 @@ static int control_put(struct snd_kcontrol *kcontrol, | |||
112 | int pos = kcontrol->private_value; | 95 | int pos = kcontrol->private_value; |
113 | unsigned char cmd = EP1_CMD_WRITE_IO; | 96 | unsigned char cmd = EP1_CMD_WRITE_IO; |
114 | 97 | ||
115 | switch (dev->chip.usb_id) { | 98 | if (dev->chip.usb_id == |
116 | case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO4DJ): { | 99 | USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_TRAKTORKONTROLX1)) |
117 | /* A4DJ has only one control */ | ||
118 | /* do not expose hardware input mode 0 */ | ||
119 | dev->control_state[0] = ucontrol->value.integer.value[0] + 1; | ||
120 | snd_usb_caiaq_send_command(dev, EP1_CMD_WRITE_IO, | ||
121 | dev->control_state, sizeof(dev->control_state)); | ||
122 | return 1; | ||
123 | } | ||
124 | |||
125 | case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_TRAKTORKONTROLX1): | ||
126 | cmd = EP1_CMD_DIMM_LEDS; | 100 | cmd = EP1_CMD_DIMM_LEDS; |
127 | break; | ||
128 | } | ||
129 | 101 | ||
130 | if (pos & CNT_INTVAL) { | 102 | if (pos & CNT_INTVAL) { |
131 | dev->control_state[pos & ~CNT_INTVAL] | 103 | dev->control_state[pos & ~CNT_INTVAL] |
diff --git a/sound/usb/caiaq/device.c b/sound/usb/caiaq/device.c index 805271827675..cdfb856bddd2 100644 --- a/sound/usb/caiaq/device.c +++ b/sound/usb/caiaq/device.c | |||
@@ -36,7 +36,7 @@ | |||
36 | #include "input.h" | 36 | #include "input.h" |
37 | 37 | ||
38 | MODULE_AUTHOR("Daniel Mack <daniel@caiaq.de>"); | 38 | MODULE_AUTHOR("Daniel Mack <daniel@caiaq.de>"); |
39 | MODULE_DESCRIPTION("caiaq USB audio, version 1.3.20"); | 39 | MODULE_DESCRIPTION("caiaq USB audio, version 1.3.21"); |
40 | MODULE_LICENSE("GPL"); | 40 | MODULE_LICENSE("GPL"); |
41 | MODULE_SUPPORTED_DEVICE("{{Native Instruments, RigKontrol2}," | 41 | MODULE_SUPPORTED_DEVICE("{{Native Instruments, RigKontrol2}," |
42 | "{Native Instruments, RigKontrol3}," | 42 | "{Native Instruments, RigKontrol3}," |
@@ -320,12 +320,6 @@ static void __devinit setup_card(struct snd_usb_caiaqdev *dev) | |||
320 | } | 320 | } |
321 | 321 | ||
322 | break; | 322 | break; |
323 | case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO4DJ): | ||
324 | /* Audio 4 DJ - default input mode to phono */ | ||
325 | dev->control_state[0] = 2; | ||
326 | snd_usb_caiaq_send_command(dev, EP1_CMD_WRITE_IO, | ||
327 | dev->control_state, 1); | ||
328 | break; | ||
329 | } | 323 | } |
330 | 324 | ||
331 | if (dev->spec.num_analog_audio_out + | 325 | if (dev->spec.num_analog_audio_out + |
diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c index ef07a6d0dd5f..28ee1ce3971a 100644 --- a/sound/usb/endpoint.c +++ b/sound/usb/endpoint.c | |||
@@ -149,6 +149,47 @@ int snd_usb_add_audio_endpoint(struct snd_usb_audio *chip, int stream, struct au | |||
149 | return 0; | 149 | return 0; |
150 | } | 150 | } |
151 | 151 | ||
152 | static int parse_uac_endpoint_attributes(struct snd_usb_audio *chip, | ||
153 | struct usb_host_interface *alts, | ||
154 | int protocol, int iface_no) | ||
155 | { | ||
156 | /* parsed with a v1 header here. that's ok as we only look at the | ||
157 | * header first which is the same for both versions */ | ||
158 | struct uac_iso_endpoint_descriptor *csep; | ||
159 | struct usb_interface_descriptor *altsd = get_iface_desc(alts); | ||
160 | int attributes = 0; | ||
161 | |||
162 | csep = snd_usb_find_desc(alts->endpoint[0].extra, alts->endpoint[0].extralen, NULL, USB_DT_CS_ENDPOINT); | ||
163 | |||
164 | /* Creamware Noah has this descriptor after the 2nd endpoint */ | ||
165 | if (!csep && altsd->bNumEndpoints >= 2) | ||
166 | csep = snd_usb_find_desc(alts->endpoint[1].extra, alts->endpoint[1].extralen, NULL, USB_DT_CS_ENDPOINT); | ||
167 | |||
168 | if (!csep || csep->bLength < 7 || | ||
169 | csep->bDescriptorSubtype != UAC_EP_GENERAL) { | ||
170 | snd_printk(KERN_WARNING "%d:%u:%d : no or invalid" | ||
171 | " class specific endpoint descriptor\n", | ||
172 | chip->dev->devnum, iface_no, | ||
173 | altsd->bAlternateSetting); | ||
174 | return 0; | ||
175 | } | ||
176 | |||
177 | if (protocol == UAC_VERSION_1) { | ||
178 | attributes = csep->bmAttributes; | ||
179 | } else { | ||
180 | struct uac2_iso_endpoint_descriptor *csep2 = | ||
181 | (struct uac2_iso_endpoint_descriptor *) csep; | ||
182 | |||
183 | attributes = csep->bmAttributes & UAC_EP_CS_ATTR_FILL_MAX; | ||
184 | |||
185 | /* emulate the endpoint attributes of a v1 device */ | ||
186 | if (csep2->bmControls & UAC2_CONTROL_PITCH) | ||
187 | attributes |= UAC_EP_CS_ATTR_PITCH_CONTROL; | ||
188 | } | ||
189 | |||
190 | return attributes; | ||
191 | } | ||
192 | |||
152 | int snd_usb_parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no) | 193 | int snd_usb_parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no) |
153 | { | 194 | { |
154 | struct usb_device *dev; | 195 | struct usb_device *dev; |
@@ -158,8 +199,8 @@ int snd_usb_parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no) | |||
158 | int i, altno, err, stream; | 199 | int i, altno, err, stream; |
159 | int format = 0, num_channels = 0; | 200 | int format = 0, num_channels = 0; |
160 | struct audioformat *fp = NULL; | 201 | struct audioformat *fp = NULL; |
161 | unsigned char *fmt, *csep; | ||
162 | int num, protocol; | 202 | int num, protocol; |
203 | struct uac_format_type_i_continuous_descriptor *fmt; | ||
163 | 204 | ||
164 | dev = chip->dev; | 205 | dev = chip->dev; |
165 | 206 | ||
@@ -256,8 +297,8 @@ int snd_usb_parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no) | |||
256 | dev->devnum, iface_no, altno); | 297 | dev->devnum, iface_no, altno); |
257 | continue; | 298 | continue; |
258 | } | 299 | } |
259 | if (((protocol == UAC_VERSION_1) && (fmt[0] < 8)) || | 300 | if (((protocol == UAC_VERSION_1) && (fmt->bLength < 8)) || |
260 | ((protocol == UAC_VERSION_2) && (fmt[0] != 6))) { | 301 | ((protocol == UAC_VERSION_2) && (fmt->bLength != 6))) { |
261 | snd_printk(KERN_ERR "%d:%u:%d : invalid UAC_FORMAT_TYPE desc\n", | 302 | snd_printk(KERN_ERR "%d:%u:%d : invalid UAC_FORMAT_TYPE desc\n", |
262 | dev->devnum, iface_no, altno); | 303 | dev->devnum, iface_no, altno); |
263 | continue; | 304 | continue; |
@@ -268,7 +309,9 @@ int snd_usb_parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no) | |||
268 | * with the previous one, except for a larger packet size, but | 309 | * with the previous one, except for a larger packet size, but |
269 | * is actually a mislabeled two-channel setting; ignore it. | 310 | * is actually a mislabeled two-channel setting; ignore it. |
270 | */ | 311 | */ |
271 | if (fmt[4] == 1 && fmt[5] == 2 && altno == 2 && num == 3 && | 312 | if (fmt->bNrChannels == 1 && |
313 | fmt->bSubframeSize == 2 && | ||
314 | altno == 2 && num == 3 && | ||
272 | fp && fp->altsetting == 1 && fp->channels == 1 && | 315 | fp && fp->altsetting == 1 && fp->channels == 1 && |
273 | fp->formats == SNDRV_PCM_FMTBIT_S16_LE && | 316 | fp->formats == SNDRV_PCM_FMTBIT_S16_LE && |
274 | protocol == UAC_VERSION_1 && | 317 | protocol == UAC_VERSION_1 && |
@@ -276,17 +319,6 @@ int snd_usb_parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no) | |||
276 | fp->maxpacksize * 2) | 319 | fp->maxpacksize * 2) |
277 | continue; | 320 | continue; |
278 | 321 | ||
279 | csep = snd_usb_find_desc(alts->endpoint[0].extra, alts->endpoint[0].extralen, NULL, USB_DT_CS_ENDPOINT); | ||
280 | /* Creamware Noah has this descriptor after the 2nd endpoint */ | ||
281 | if (!csep && altsd->bNumEndpoints >= 2) | ||
282 | csep = snd_usb_find_desc(alts->endpoint[1].extra, alts->endpoint[1].extralen, NULL, USB_DT_CS_ENDPOINT); | ||
283 | if (!csep || csep[0] < 7 || csep[2] != UAC_EP_GENERAL) { | ||
284 | snd_printk(KERN_WARNING "%d:%u:%d : no or invalid" | ||
285 | " class specific endpoint descriptor\n", | ||
286 | dev->devnum, iface_no, altno); | ||
287 | csep = NULL; | ||
288 | } | ||
289 | |||
290 | fp = kzalloc(sizeof(*fp), GFP_KERNEL); | 322 | fp = kzalloc(sizeof(*fp), GFP_KERNEL); |
291 | if (! fp) { | 323 | if (! fp) { |
292 | snd_printk(KERN_ERR "cannot malloc\n"); | 324 | snd_printk(KERN_ERR "cannot malloc\n"); |
@@ -305,7 +337,7 @@ int snd_usb_parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no) | |||
305 | if (snd_usb_get_speed(dev) == USB_SPEED_HIGH) | 337 | if (snd_usb_get_speed(dev) == USB_SPEED_HIGH) |
306 | fp->maxpacksize = (((fp->maxpacksize >> 11) & 3) + 1) | 338 | fp->maxpacksize = (((fp->maxpacksize >> 11) & 3) + 1) |
307 | * (fp->maxpacksize & 0x7ff); | 339 | * (fp->maxpacksize & 0x7ff); |
308 | fp->attributes = csep ? csep[3] : 0; | 340 | fp->attributes = parse_uac_endpoint_attributes(chip, alts, protocol, iface_no); |
309 | 341 | ||
310 | /* some quirks for attributes here */ | 342 | /* some quirks for attributes here */ |
311 | 343 | ||
diff --git a/sound/usb/format.c b/sound/usb/format.c index b87cf87c4e7b..fe29d61de19b 100644 --- a/sound/usb/format.c +++ b/sound/usb/format.c | |||
@@ -278,12 +278,11 @@ err: | |||
278 | * parse the format type I and III descriptors | 278 | * parse the format type I and III descriptors |
279 | */ | 279 | */ |
280 | static int parse_audio_format_i(struct snd_usb_audio *chip, | 280 | static int parse_audio_format_i(struct snd_usb_audio *chip, |
281 | struct audioformat *fp, | 281 | struct audioformat *fp, int format, |
282 | int format, void *_fmt, | 282 | struct uac_format_type_i_continuous_descriptor *fmt, |
283 | struct usb_host_interface *iface) | 283 | struct usb_host_interface *iface) |
284 | { | 284 | { |
285 | struct usb_interface_descriptor *altsd = get_iface_desc(iface); | 285 | struct usb_interface_descriptor *altsd = get_iface_desc(iface); |
286 | struct uac_format_type_i_discrete_descriptor *fmt = _fmt; | ||
287 | int protocol = altsd->bInterfaceProtocol; | 286 | int protocol = altsd->bInterfaceProtocol; |
288 | int pcm_format, ret; | 287 | int pcm_format, ret; |
289 | 288 | ||
@@ -320,7 +319,7 @@ static int parse_audio_format_i(struct snd_usb_audio *chip, | |||
320 | switch (protocol) { | 319 | switch (protocol) { |
321 | case UAC_VERSION_1: | 320 | case UAC_VERSION_1: |
322 | fp->channels = fmt->bNrChannels; | 321 | fp->channels = fmt->bNrChannels; |
323 | ret = parse_audio_format_rates_v1(chip, fp, _fmt, 7); | 322 | ret = parse_audio_format_rates_v1(chip, fp, (unsigned char *) fmt, 7); |
324 | break; | 323 | break; |
325 | case UAC_VERSION_2: | 324 | case UAC_VERSION_2: |
326 | /* fp->channels is already set in this case */ | 325 | /* fp->channels is already set in this case */ |
@@ -392,12 +391,12 @@ static int parse_audio_format_ii(struct snd_usb_audio *chip, | |||
392 | } | 391 | } |
393 | 392 | ||
394 | int snd_usb_parse_audio_format(struct snd_usb_audio *chip, struct audioformat *fp, | 393 | int snd_usb_parse_audio_format(struct snd_usb_audio *chip, struct audioformat *fp, |
395 | int format, unsigned char *fmt, int stream, | 394 | int format, struct uac_format_type_i_continuous_descriptor *fmt, |
396 | struct usb_host_interface *iface) | 395 | int stream, struct usb_host_interface *iface) |
397 | { | 396 | { |
398 | int err; | 397 | int err; |
399 | 398 | ||
400 | switch (fmt[3]) { | 399 | switch (fmt->bFormatType) { |
401 | case UAC_FORMAT_TYPE_I: | 400 | case UAC_FORMAT_TYPE_I: |
402 | case UAC_FORMAT_TYPE_III: | 401 | case UAC_FORMAT_TYPE_III: |
403 | err = parse_audio_format_i(chip, fp, format, fmt, iface); | 402 | err = parse_audio_format_i(chip, fp, format, fmt, iface); |
@@ -407,10 +406,11 @@ int snd_usb_parse_audio_format(struct snd_usb_audio *chip, struct audioformat *f | |||
407 | break; | 406 | break; |
408 | default: | 407 | default: |
409 | snd_printd(KERN_INFO "%d:%u:%d : format type %d is not supported yet\n", | 408 | snd_printd(KERN_INFO "%d:%u:%d : format type %d is not supported yet\n", |
410 | chip->dev->devnum, fp->iface, fp->altsetting, fmt[3]); | 409 | chip->dev->devnum, fp->iface, fp->altsetting, |
411 | return -1; | 410 | fmt->bFormatType); |
411 | return -ENOTSUPP; | ||
412 | } | 412 | } |
413 | fp->fmt_type = fmt[3]; | 413 | fp->fmt_type = fmt->bFormatType; |
414 | if (err < 0) | 414 | if (err < 0) |
415 | return err; | 415 | return err; |
416 | #if 1 | 416 | #if 1 |
@@ -421,10 +421,10 @@ int snd_usb_parse_audio_format(struct snd_usb_audio *chip, struct audioformat *f | |||
421 | if (chip->usb_id == USB_ID(0x041e, 0x3000) || | 421 | if (chip->usb_id == USB_ID(0x041e, 0x3000) || |
422 | chip->usb_id == USB_ID(0x041e, 0x3020) || | 422 | chip->usb_id == USB_ID(0x041e, 0x3020) || |
423 | chip->usb_id == USB_ID(0x041e, 0x3061)) { | 423 | chip->usb_id == USB_ID(0x041e, 0x3061)) { |
424 | if (fmt[3] == UAC_FORMAT_TYPE_I && | 424 | if (fmt->bFormatType == UAC_FORMAT_TYPE_I && |
425 | fp->rates != SNDRV_PCM_RATE_48000 && | 425 | fp->rates != SNDRV_PCM_RATE_48000 && |
426 | fp->rates != SNDRV_PCM_RATE_96000) | 426 | fp->rates != SNDRV_PCM_RATE_96000) |
427 | return -1; | 427 | return -ENOTSUPP; |
428 | } | 428 | } |
429 | #endif | 429 | #endif |
430 | return 0; | 430 | return 0; |
diff --git a/sound/usb/format.h b/sound/usb/format.h index 8298c4e8ddfa..387924f0af85 100644 --- a/sound/usb/format.h +++ b/sound/usb/format.h | |||
@@ -1,8 +1,9 @@ | |||
1 | #ifndef __USBAUDIO_FORMAT_H | 1 | #ifndef __USBAUDIO_FORMAT_H |
2 | #define __USBAUDIO_FORMAT_H | 2 | #define __USBAUDIO_FORMAT_H |
3 | 3 | ||
4 | int snd_usb_parse_audio_format(struct snd_usb_audio *chip, struct audioformat *fp, | 4 | int snd_usb_parse_audio_format(struct snd_usb_audio *chip, |
5 | int format, unsigned char *fmt, int stream, | 5 | struct audioformat *fp, int format, |
6 | struct usb_host_interface *iface); | 6 | struct uac_format_type_i_continuous_descriptor *fmt, |
7 | int stream, struct usb_host_interface *iface); | ||
7 | 8 | ||
8 | #endif /* __USBAUDIO_FORMAT_H */ | 9 | #endif /* __USBAUDIO_FORMAT_H */ |
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 97dd17655104..03ce971e0027 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c | |||
@@ -1126,7 +1126,7 @@ static int parse_audio_feature_unit(struct mixer_build *state, int unitid, void | |||
1126 | } else { | 1126 | } else { |
1127 | struct uac2_feature_unit_descriptor *ftr = _ftr; | 1127 | struct uac2_feature_unit_descriptor *ftr = _ftr; |
1128 | csize = 4; | 1128 | csize = 4; |
1129 | channels = (hdr->bLength - 6) / 4; | 1129 | channels = (hdr->bLength - 6) / 4 - 1; |
1130 | bmaControls = ftr->bmaControls; | 1130 | bmaControls = ftr->bmaControls; |
1131 | } | 1131 | } |
1132 | 1132 | ||
diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c index 2bf0d77d1768..056587de7be4 100644 --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c | |||
@@ -120,10 +120,6 @@ static int init_pitch_v1(struct snd_usb_audio *chip, int iface, | |||
120 | 120 | ||
121 | ep = get_endpoint(alts, 0)->bEndpointAddress; | 121 | ep = get_endpoint(alts, 0)->bEndpointAddress; |
122 | 122 | ||
123 | /* if endpoint doesn't have pitch control, bail out */ | ||
124 | if (!(fmt->attributes & UAC_EP_CS_ATTR_PITCH_CONTROL)) | ||
125 | return 0; | ||
126 | |||
127 | data[0] = 1; | 123 | data[0] = 1; |
128 | if ((err = snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0), UAC_SET_CUR, | 124 | if ((err = snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0), UAC_SET_CUR, |
129 | USB_TYPE_CLASS|USB_RECIP_ENDPOINT|USB_DIR_OUT, | 125 | USB_TYPE_CLASS|USB_RECIP_ENDPOINT|USB_DIR_OUT, |
@@ -137,8 +133,32 @@ static int init_pitch_v1(struct snd_usb_audio *chip, int iface, | |||
137 | return 0; | 133 | return 0; |
138 | } | 134 | } |
139 | 135 | ||
136 | static int init_pitch_v2(struct snd_usb_audio *chip, int iface, | ||
137 | struct usb_host_interface *alts, | ||
138 | struct audioformat *fmt) | ||
139 | { | ||
140 | struct usb_device *dev = chip->dev; | ||
141 | unsigned char data[1]; | ||
142 | unsigned int ep; | ||
143 | int err; | ||
144 | |||
145 | ep = get_endpoint(alts, 0)->bEndpointAddress; | ||
146 | |||
147 | data[0] = 1; | ||
148 | if ((err = snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0), UAC2_CS_CUR, | ||
149 | USB_TYPE_CLASS | USB_RECIP_ENDPOINT | USB_DIR_OUT, | ||
150 | UAC2_EP_CS_PITCH << 8, 0, | ||
151 | data, sizeof(data), 1000)) < 0) { | ||
152 | snd_printk(KERN_ERR "%d:%d:%d: cannot set enable PITCH (v2)\n", | ||
153 | dev->devnum, iface, fmt->altsetting); | ||
154 | return err; | ||
155 | } | ||
156 | |||
157 | return 0; | ||
158 | } | ||
159 | |||
140 | /* | 160 | /* |
141 | * initialize the picth control and sample rate | 161 | * initialize the pitch control and sample rate |
142 | */ | 162 | */ |
143 | int snd_usb_init_pitch(struct snd_usb_audio *chip, int iface, | 163 | int snd_usb_init_pitch(struct snd_usb_audio *chip, int iface, |
144 | struct usb_host_interface *alts, | 164 | struct usb_host_interface *alts, |
@@ -146,13 +166,16 @@ int snd_usb_init_pitch(struct snd_usb_audio *chip, int iface, | |||
146 | { | 166 | { |
147 | struct usb_interface_descriptor *altsd = get_iface_desc(alts); | 167 | struct usb_interface_descriptor *altsd = get_iface_desc(alts); |
148 | 168 | ||
169 | /* if endpoint doesn't have pitch control, bail out */ | ||
170 | if (!(fmt->attributes & UAC_EP_CS_ATTR_PITCH_CONTROL)) | ||
171 | return 0; | ||
172 | |||
149 | switch (altsd->bInterfaceProtocol) { | 173 | switch (altsd->bInterfaceProtocol) { |
150 | case UAC_VERSION_1: | 174 | case UAC_VERSION_1: |
151 | return init_pitch_v1(chip, iface, alts, fmt); | 175 | return init_pitch_v1(chip, iface, alts, fmt); |
152 | 176 | ||
153 | case UAC_VERSION_2: | 177 | case UAC_VERSION_2: |
154 | /* not implemented yet */ | 178 | return init_pitch_v2(chip, iface, alts, fmt); |
155 | return 0; | ||
156 | } | 179 | } |
157 | 180 | ||
158 | return -EINVAL; | 181 | return -EINVAL; |