diff options
author | Harvey Harrison <harvey.harrison@gmail.com> | 2008-02-29 05:59:26 -0500 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2008-04-24 06:00:19 -0400 |
commit | 3c9a3203ff9863fbe798030928f496347c2ed3bd (patch) | |
tree | 1a38d2c9dfab80828bbc8414463c53391aa6257b /sound | |
parent | 64ed0dfd1f42edb15f4d18c13d7696edbc2f7e4c (diff) |
[ALSA] sound: hda: missing includes of hda_patch.h
Move the array declaration to hda_codec.c where it is used and add includes
where the individual presets are declared.
Fixes the following sparse warnings:
sound/pci/hda/patch_realtek.c:13744:25: warning: symbol 'snd_hda_preset_realtek' was not declared. Should it be static?
sound/pci/hda/patch_cmedia.c:729:25: warning: symbol 'snd_hda_preset_cmedia' was not declared. Should it be static?
sound/pci/hda/patch_analog.c:3656:25: warning: symbol 'snd_hda_preset_analog' was not declared. Should it be static?
sound/pci/hda/patch_sigmatel.c:3995:25: warning: symbol 'snd_hda_preset_sigmatel' was not declared. Should it be static?
sound/pci/hda/patch_si3054.c:286:25: warning: symbol 'snd_hda_preset_si3054' was not declared. Should it be static?
sound/pci/hda/patch_atihdmi.c:156:25: warning: symbol 'snd_hda_preset_atihdmi' was not declared. Should it be static?
sound/pci/hda/patch_conexant.c:1721:25: warning: symbol 'snd_hda_preset_conexant' was not declared. Should it be static?
sound/pci/hda/patch_via.c:1962:25: warning: symbol 'snd_hda_preset_via' was not declared. Should it be static?
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
-rw-r--r-- | sound/pci/hda/hda_codec.c | 31 | ||||
-rw-r--r-- | sound/pci/hda/hda_patch.h | 28 | ||||
-rw-r--r-- | sound/pci/hda/patch_analog.c | 1 | ||||
-rw-r--r-- | sound/pci/hda/patch_atihdmi.c | 1 | ||||
-rw-r--r-- | sound/pci/hda/patch_cmedia.c | 1 | ||||
-rw-r--r-- | sound/pci/hda/patch_conexant.c | 1 | ||||
-rw-r--r-- | sound/pci/hda/patch_realtek.c | 1 | ||||
-rw-r--r-- | sound/pci/hda/patch_si3054.c | 2 | ||||
-rw-r--r-- | sound/pci/hda/patch_sigmatel.c | 1 | ||||
-rw-r--r-- | sound/pci/hda/patch_via.c | 2 |
10 files changed, 36 insertions, 33 deletions
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 8ab88d9ba3b5..e6bace83e7cf 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c | |||
@@ -31,6 +31,7 @@ | |||
31 | #include <sound/initval.h> | 31 | #include <sound/initval.h> |
32 | #include "hda_local.h" | 32 | #include "hda_local.h" |
33 | #include <sound/hda_hwdep.h> | 33 | #include <sound/hda_hwdep.h> |
34 | #include "hda_patch.h" /* codec presets */ | ||
34 | 35 | ||
35 | #ifdef CONFIG_SND_HDA_POWER_SAVE | 36 | #ifdef CONFIG_SND_HDA_POWER_SAVE |
36 | /* define this option here to hide as static */ | 37 | /* define this option here to hide as static */ |
@@ -68,9 +69,33 @@ static struct hda_vendor_id hda_vendor_ids[] = { | |||
68 | {} /* terminator */ | 69 | {} /* terminator */ |
69 | }; | 70 | }; |
70 | 71 | ||
71 | /* codec presets */ | 72 | static const struct hda_codec_preset *hda_preset_tables[] = { |
72 | #include "hda_patch.h" | 73 | #ifdef CONFIG_SND_HDA_CODEC_REALTEK |
73 | 74 | snd_hda_preset_realtek, | |
75 | #endif | ||
76 | #ifdef CONFIG_SND_HDA_CODEC_CMEDIA | ||
77 | snd_hda_preset_cmedia, | ||
78 | #endif | ||
79 | #ifdef CONFIG_SND_HDA_CODEC_ANALOG | ||
80 | snd_hda_preset_analog, | ||
81 | #endif | ||
82 | #ifdef CONFIG_SND_HDA_CODEC_SIGMATEL | ||
83 | snd_hda_preset_sigmatel, | ||
84 | #endif | ||
85 | #ifdef CONFIG_SND_HDA_CODEC_SI3054 | ||
86 | snd_hda_preset_si3054, | ||
87 | #endif | ||
88 | #ifdef CONFIG_SND_HDA_CODEC_ATIHDMI | ||
89 | snd_hda_preset_atihdmi, | ||
90 | #endif | ||
91 | #ifdef CONFIG_SND_HDA_CODEC_CONEXANT | ||
92 | snd_hda_preset_conexant, | ||
93 | #endif | ||
94 | #ifdef CONFIG_SND_HDA_CODEC_VIA | ||
95 | snd_hda_preset_via, | ||
96 | #endif | ||
97 | NULL | ||
98 | }; | ||
74 | 99 | ||
75 | #ifdef CONFIG_SND_HDA_POWER_SAVE | 100 | #ifdef CONFIG_SND_HDA_POWER_SAVE |
76 | static void hda_power_work(struct work_struct *work); | 101 | static void hda_power_work(struct work_struct *work); |
diff --git a/sound/pci/hda/hda_patch.h b/sound/pci/hda/hda_patch.h index f5c23bb16d7e..2fdf2358dbc2 100644 --- a/sound/pci/hda/hda_patch.h +++ b/sound/pci/hda/hda_patch.h | |||
@@ -18,31 +18,3 @@ extern struct hda_codec_preset snd_hda_preset_atihdmi[]; | |||
18 | extern struct hda_codec_preset snd_hda_preset_conexant[]; | 18 | extern struct hda_codec_preset snd_hda_preset_conexant[]; |
19 | /* VIA codecs */ | 19 | /* VIA codecs */ |
20 | extern struct hda_codec_preset snd_hda_preset_via[]; | 20 | extern struct hda_codec_preset snd_hda_preset_via[]; |
21 | |||
22 | static const struct hda_codec_preset *hda_preset_tables[] = { | ||
23 | #ifdef CONFIG_SND_HDA_CODEC_REALTEK | ||
24 | snd_hda_preset_realtek, | ||
25 | #endif | ||
26 | #ifdef CONFIG_SND_HDA_CODEC_CMEDIA | ||
27 | snd_hda_preset_cmedia, | ||
28 | #endif | ||
29 | #ifdef CONFIG_SND_HDA_CODEC_ANALOG | ||
30 | snd_hda_preset_analog, | ||
31 | #endif | ||
32 | #ifdef CONFIG_SND_HDA_CODEC_SIGMATEL | ||
33 | snd_hda_preset_sigmatel, | ||
34 | #endif | ||
35 | #ifdef CONFIG_SND_HDA_CODEC_SI3054 | ||
36 | snd_hda_preset_si3054, | ||
37 | #endif | ||
38 | #ifdef CONFIG_SND_HDA_CODEC_ATIHDMI | ||
39 | snd_hda_preset_atihdmi, | ||
40 | #endif | ||
41 | #ifdef CONFIG_SND_HDA_CODEC_CONEXANT | ||
42 | snd_hda_preset_conexant, | ||
43 | #endif | ||
44 | #ifdef CONFIG_SND_HDA_CODEC_VIA | ||
45 | snd_hda_preset_via, | ||
46 | #endif | ||
47 | NULL | ||
48 | }; | ||
diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c index 20446e320b2c..87db3c410a10 100644 --- a/sound/pci/hda/patch_analog.c +++ b/sound/pci/hda/patch_analog.c | |||
@@ -28,6 +28,7 @@ | |||
28 | #include <sound/core.h> | 28 | #include <sound/core.h> |
29 | #include "hda_codec.h" | 29 | #include "hda_codec.h" |
30 | #include "hda_local.h" | 30 | #include "hda_local.h" |
31 | #include "hda_patch.h" | ||
31 | 32 | ||
32 | struct ad198x_spec { | 33 | struct ad198x_spec { |
33 | struct snd_kcontrol_new *mixers[5]; | 34 | struct snd_kcontrol_new *mixers[5]; |
diff --git a/sound/pci/hda/patch_atihdmi.c b/sound/pci/hda/patch_atihdmi.c index 45a2e30cbf42..12272508b112 100644 --- a/sound/pci/hda/patch_atihdmi.c +++ b/sound/pci/hda/patch_atihdmi.c | |||
@@ -27,6 +27,7 @@ | |||
27 | #include <sound/core.h> | 27 | #include <sound/core.h> |
28 | #include "hda_codec.h" | 28 | #include "hda_codec.h" |
29 | #include "hda_local.h" | 29 | #include "hda_local.h" |
30 | #include "hda_patch.h" | ||
30 | 31 | ||
31 | struct atihdmi_spec { | 32 | struct atihdmi_spec { |
32 | struct hda_multi_out multiout; | 33 | struct hda_multi_out multiout; |
diff --git a/sound/pci/hda/patch_cmedia.c b/sound/pci/hda/patch_cmedia.c index 9794d4166ae4..1892c81f1d11 100644 --- a/sound/pci/hda/patch_cmedia.c +++ b/sound/pci/hda/patch_cmedia.c | |||
@@ -28,6 +28,7 @@ | |||
28 | #include <sound/core.h> | 28 | #include <sound/core.h> |
29 | #include "hda_codec.h" | 29 | #include "hda_codec.h" |
30 | #include "hda_local.h" | 30 | #include "hda_local.h" |
31 | #include "hda_patch.h" | ||
31 | #define NUM_PINS 11 | 32 | #define NUM_PINS 11 |
32 | 33 | ||
33 | 34 | ||
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 2bb9a58db9fa..e4fa9a35848f 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c | |||
@@ -27,6 +27,7 @@ | |||
27 | #include <sound/core.h> | 27 | #include <sound/core.h> |
28 | #include "hda_codec.h" | 28 | #include "hda_codec.h" |
29 | #include "hda_local.h" | 29 | #include "hda_local.h" |
30 | #include "hda_patch.h" | ||
30 | 31 | ||
31 | #define CXT_PIN_DIR_IN 0x00 | 32 | #define CXT_PIN_DIR_IN 0x00 |
32 | #define CXT_PIN_DIR_OUT 0x01 | 33 | #define CXT_PIN_DIR_OUT 0x01 |
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 2100ee480809..33c9505adbae 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c | |||
@@ -30,6 +30,7 @@ | |||
30 | #include <sound/core.h> | 30 | #include <sound/core.h> |
31 | #include "hda_codec.h" | 31 | #include "hda_codec.h" |
32 | #include "hda_local.h" | 32 | #include "hda_local.h" |
33 | #include "hda_patch.h" | ||
33 | 34 | ||
34 | #define ALC880_FRONT_EVENT 0x01 | 35 | #define ALC880_FRONT_EVENT 0x01 |
35 | #define ALC880_DCVOL_EVENT 0x02 | 36 | #define ALC880_DCVOL_EVENT 0x02 |
diff --git a/sound/pci/hda/patch_si3054.c b/sound/pci/hda/patch_si3054.c index 598ee2119bbe..9332b63e406c 100644 --- a/sound/pci/hda/patch_si3054.c +++ b/sound/pci/hda/patch_si3054.c | |||
@@ -28,7 +28,7 @@ | |||
28 | #include <sound/core.h> | 28 | #include <sound/core.h> |
29 | #include "hda_codec.h" | 29 | #include "hda_codec.h" |
30 | #include "hda_local.h" | 30 | #include "hda_local.h" |
31 | 31 | #include "hda_patch.h" | |
32 | 32 | ||
33 | /* si3054 verbs */ | 33 | /* si3054 verbs */ |
34 | #define SI3054_VERB_READ_NODE 0x900 | 34 | #define SI3054_VERB_READ_NODE 0x900 |
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index e1d61a035bab..47d3536a6576 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c | |||
@@ -32,6 +32,7 @@ | |||
32 | #include <sound/asoundef.h> | 32 | #include <sound/asoundef.h> |
33 | #include "hda_codec.h" | 33 | #include "hda_codec.h" |
34 | #include "hda_local.h" | 34 | #include "hda_local.h" |
35 | #include "hda_patch.h" | ||
35 | 36 | ||
36 | #define NUM_CONTROL_ALLOC 32 | 37 | #define NUM_CONTROL_ALLOC 32 |
37 | #define STAC_PWR_EVENT 0x20 | 38 | #define STAC_PWR_EVENT 0x20 |
diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c index 3515a3fb5d9d..09f1c25eb7e5 100644 --- a/sound/pci/hda/patch_via.c +++ b/sound/pci/hda/patch_via.c | |||
@@ -39,7 +39,7 @@ | |||
39 | #include <sound/core.h> | 39 | #include <sound/core.h> |
40 | #include "hda_codec.h" | 40 | #include "hda_codec.h" |
41 | #include "hda_local.h" | 41 | #include "hda_local.h" |
42 | 42 | #include "hda_patch.h" | |
43 | 43 | ||
44 | /* amp values */ | 44 | /* amp values */ |
45 | #define AMP_VAL_IDX_SHIFT 19 | 45 | #define AMP_VAL_IDX_SHIFT 19 |