diff options
author | Fabio Estevam <fabio.estevam@freescale.com> | 2014-04-30 08:50:40 -0400 |
---|---|---|
committer | Mark Brown <broonie@linaro.org> | 2014-04-30 23:36:06 -0400 |
commit | a0b148b4232472f5c046ace203b7856f51564d70 (patch) | |
tree | 834f89bc227088c21a5ae53781df3180ae26e74f /sound | |
parent | c9eaa447e77efe77b7fa4c953bd62de8297fd6c5 (diff) |
ASoC: wm8985: Use devm_regulator_bulk_get()
Using devm_regulator_bulk_get() can make the code cleaner and smaller as we
do not need to call regulator_bulk_free() in the error and remove paths.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'sound')
-rw-r--r-- | sound/soc/codecs/wm8985.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/sound/soc/codecs/wm8985.c b/sound/soc/codecs/wm8985.c index 5473dc969585..a36e01cbe0f5 100644 --- a/sound/soc/codecs/wm8985.c +++ b/sound/soc/codecs/wm8985.c | |||
@@ -984,7 +984,6 @@ static int wm8985_remove(struct snd_soc_codec *codec) | |||
984 | 984 | ||
985 | wm8985 = snd_soc_codec_get_drvdata(codec); | 985 | wm8985 = snd_soc_codec_get_drvdata(codec); |
986 | wm8985_set_bias_level(codec, SND_SOC_BIAS_OFF); | 986 | wm8985_set_bias_level(codec, SND_SOC_BIAS_OFF); |
987 | regulator_bulk_free(ARRAY_SIZE(wm8985->supplies), wm8985->supplies); | ||
988 | return 0; | 987 | return 0; |
989 | } | 988 | } |
990 | 989 | ||
@@ -999,7 +998,7 @@ static int wm8985_probe(struct snd_soc_codec *codec) | |||
999 | for (i = 0; i < ARRAY_SIZE(wm8985->supplies); i++) | 998 | for (i = 0; i < ARRAY_SIZE(wm8985->supplies); i++) |
1000 | wm8985->supplies[i].supply = wm8985_supply_names[i]; | 999 | wm8985->supplies[i].supply = wm8985_supply_names[i]; |
1001 | 1000 | ||
1002 | ret = regulator_bulk_get(codec->dev, ARRAY_SIZE(wm8985->supplies), | 1001 | ret = devm_regulator_bulk_get(codec->dev, ARRAY_SIZE(wm8985->supplies), |
1003 | wm8985->supplies); | 1002 | wm8985->supplies); |
1004 | if (ret) { | 1003 | if (ret) { |
1005 | dev_err(codec->dev, "Failed to request supplies: %d\n", ret); | 1004 | dev_err(codec->dev, "Failed to request supplies: %d\n", ret); |
@@ -1010,7 +1009,7 @@ static int wm8985_probe(struct snd_soc_codec *codec) | |||
1010 | wm8985->supplies); | 1009 | wm8985->supplies); |
1011 | if (ret) { | 1010 | if (ret) { |
1012 | dev_err(codec->dev, "Failed to enable supplies: %d\n", ret); | 1011 | dev_err(codec->dev, "Failed to enable supplies: %d\n", ret); |
1013 | goto err_reg_get; | 1012 | return ret; |
1014 | } | 1013 | } |
1015 | 1014 | ||
1016 | ret = wm8985_reset(codec); | 1015 | ret = wm8985_reset(codec); |
@@ -1032,8 +1031,6 @@ static int wm8985_probe(struct snd_soc_codec *codec) | |||
1032 | 1031 | ||
1033 | err_reg_enable: | 1032 | err_reg_enable: |
1034 | regulator_bulk_disable(ARRAY_SIZE(wm8985->supplies), wm8985->supplies); | 1033 | regulator_bulk_disable(ARRAY_SIZE(wm8985->supplies), wm8985->supplies); |
1035 | err_reg_get: | ||
1036 | regulator_bulk_free(ARRAY_SIZE(wm8985->supplies), wm8985->supplies); | ||
1037 | return ret; | 1034 | return ret; |
1038 | } | 1035 | } |
1039 | 1036 | ||