Merge remote-tracking branch 'asoc/topic/core' into asoc-next

5 files changed, 42 insertions, 20 deletions

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 45b72561c615..350b86458971 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -324,7 +324,7 @@ config SND_SOC_TLV320AIC23
         tristate
 
 config SND_SOC_TLV320AIC26
-        tristate "TI TLV320AIC26 Codec support" if SND_SOC_OF_SIMPLE
+        tristate
         depends on SPI
 
 config SND_SOC_TLV320AIC32X4
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index ff4b45a5d796..c70f9e072043 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -3908,7 +3908,7 @@ EXPORT_SYMBOL_GPL(snd_soc_unregister_dais);
  * @platform: platform to register
  */
 int snd_soc_register_platform(struct device *dev,
-                struct snd_soc_platform_driver *platform_drv)
+                const struct snd_soc_platform_driver *platform_drv)
 {
         struct snd_soc_platform *platform;
 
@@ -4024,8 +4024,8 @@ int snd_soc_register_codec(struct device *dev,
         /* create CODEC component name */
         codec->name = fmt_single_name(dev, &codec->id);
         if (codec->name == NULL) {
-                kfree(codec);
-                return -ENOMEM;
+                ret = -ENOMEM;
+                goto fail_codec;
         }
 
         if (codec_drv->compress_type)
@@ -4064,7 +4064,7 @@ int snd_soc_register_codec(struct device *dev,
                                                       reg_size, GFP_KERNEL);
                         if (!codec->reg_def_copy) {
                                 ret = -ENOMEM;
-                                goto fail;
+                                goto fail_codec_name;
                         }
                 }
         }
@@ -4088,18 +4088,22 @@ int snd_soc_register_codec(struct device *dev,
         mutex_unlock(&client_mutex);
 
         /* register any DAIs */
-        if (num_dai) {
-                ret = snd_soc_register_dais(dev, dai_drv, num_dai);
-                if (ret < 0)
-                        dev_err(codec->dev, "ASoC: Failed to regster"
-                                " DAIs: %d\n", ret);
+        ret = snd_soc_register_dais(dev, dai_drv, num_dai);
+        if (ret < 0) {
+                dev_err(codec->dev, "ASoC: Failed to regster DAIs: %d\n", ret);
+                goto fail_codec_name;
         }
 
         dev_dbg(codec->dev, "ASoC: Registered codec '%s'\n", codec->name);
         return 0;
 
-fail:
+fail_codec_name:
+        mutex_lock(&client_mutex);
+        list_del(&codec->list);
+        mutex_unlock(&client_mutex);
+
         kfree(codec->name);
+fail_codec:
         kfree(codec);
         return ret;
 }
@@ -4113,7 +4117,6 @@ EXPORT_SYMBOL_GPL(snd_soc_register_codec);
 void snd_soc_unregister_codec(struct device *dev)
 {
         struct snd_soc_codec *codec;
-        int i;
 
         list_for_each_entry(codec, &codec_list, list) {
                 if (dev == codec->dev)
@@ -4122,9 +4125,7 @@ void snd_soc_unregister_codec(struct device *dev)
         return;
 
 found:
-        if (codec->num_dai)
-                for (i = 0; i < codec->num_dai; i++)
-                        snd_soc_unregister_dai(dev);
+        snd_soc_unregister_dais(dev, codec->num_dai);
 
         mutex_lock(&client_mutex);
         list_del(&codec->list);
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index d6d9ba2e6916..33acd8b892dc 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3137,7 +3137,6 @@ snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm,
                 break;
         }
 
-        dapm->n_widgets++;
         w->dapm = dapm;
         w->codec = dapm->codec;
         w->platform = dapm->platform;
diff --git a/sound/soc/soc-io.c b/sound/soc/soc-io.c
index 29183ef2b93d..8ca9ecc5ac57 100644
--- a/sound/soc/soc-io.c
+++ b/sound/soc/soc-io.c
@@ -158,10 +158,7 @@ int snd_soc_codec_set_cache_io(struct snd_soc_codec *codec,
                 return -EINVAL;
         }
 
-        if (IS_ERR(codec->control_data))
-                return PTR_ERR(codec->control_data);
-
-        return 0;
+        return PTR_RET(codec->control_data);
 }
 EXPORT_SYMBOL_GPL(snd_soc_codec_set_cache_io);
 #else
diff --git a/sound/soc/soc-utils.c b/sound/soc/soc-utils.c
index fe4541df498c..4b3be6c3c91e 100644
--- a/sound/soc/soc-utils.c
+++ b/sound/soc/soc-utils.c
@@ -90,8 +90,33 @@ static struct snd_soc_platform_driver dummy_platform = {
 };
 
 static struct snd_soc_codec_driver dummy_codec;
+
+#define STUB_RATES      SNDRV_PCM_RATE_8000_192000
+#define STUB_FORMATS    (SNDRV_PCM_FMTBIT_S8 | \
+                        SNDRV_PCM_FMTBIT_U8 | \
+                        SNDRV_PCM_FMTBIT_S16_LE | \
+                        SNDRV_PCM_FMTBIT_U16_LE | \
+                        SNDRV_PCM_FMTBIT_S24_LE | \
+                        SNDRV_PCM_FMTBIT_U24_LE | \
+                        SNDRV_PCM_FMTBIT_S32_LE | \
+                        SNDRV_PCM_FMTBIT_U32_LE | \
+                        SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE)
 static struct snd_soc_dai_driver dummy_dai = {
         .name = "snd-soc-dummy-dai",
+        .playback = {
+                .stream_name    = "Playback",
+                .channels_min   = 1,
+                .channels_max   = 384,
+                .rates          = STUB_RATES,
+                .formats        = STUB_FORMATS,
+        },
+        .capture = {
+                .stream_name    = "Capture",
+                .channels_min   = 1,
+                .channels_max   = 384,
+                .rates = STUB_RATES,
+                .formats = STUB_FORMATS,
+         },
 };
 
 static int snd_soc_dummy_probe(struct platform_device *pdev)