diff options
author | Adrian Bunk <bunk@stusta.de> | 2005-05-23 04:29:53 -0400 |
---|---|---|
committer | Jaroslav Kysela <perex@suse.cz> | 2005-05-29 04:11:38 -0400 |
commit | 209ac85d76e4edf05779b4bd5c2a92b059e9ab4d (patch) | |
tree | bbed71e0eed26c7cf39cc4729906528a249b3b1d /sound | |
parent | 1baa705b75124df7cfe3d5d2706f794a14d26ad0 (diff) |
[ALSA] sound/isa/: cleanups
GUS Library
This patch contains the following possible cleanups:
- make needlesly global code static
- #if 0 the following unused global functions:
- gus/gus_volume.c: snd_gf1_gvol_to_lvol_raw
- gus/gus_volume.c: snd_gf1_calc_ramp_rate
- gus/gus_volume.c: snd_gf1_compute_vibrato
- gus/gus_volume.c: snd_gf1_compute_pitchbend
- gus/gus_volume.c: snd_gf1_compute_freq
- gus/gus_io.c: snd_gf1_i_adlib_write
- gus/gus_io.c: snd_gf1_i_write_addr
- gus/gus_io.c: snd_gf1_pokew
- gus/gus_io.c: snd_gf1_peekw
- gus/gus_io.c: snd_gf1_dram_setmem
- gus/gus_io.c: snd_gf1_print_global_registers
- gus/gus_io.c: snd_gf1_print_setup_registers
- gus/gus_io.c: snd_gf1_peek_print_block
- gus/gus_io.c: snd_gf1_print_setup_registers
- gus/gus_io.c: snd_gf1_peek_print_block
- #if 0 the following unused global variable:
- gus/gus_tables.h: snd_gf1_scale_table
- remove the following unneeded EXPORT_SYMBOL's:
- gus/gus_main.c: snd_gf1_i_write16
- gus/gus_main.c: snd_gf1_start
- gus/gus_main.c: snd_gf1_stop
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
-rw-r--r-- | sound/isa/gus/gus_io.c | 14 | ||||
-rw-r--r-- | sound/isa/gus/gus_main.c | 3 | ||||
-rw-r--r-- | sound/isa/gus/gus_mem.c | 12 | ||||
-rw-r--r-- | sound/isa/gus/gus_reset.c | 3 | ||||
-rw-r--r-- | sound/isa/gus/gus_synth.c | 3 | ||||
-rw-r--r-- | sound/isa/gus/gus_tables.h | 4 | ||||
-rw-r--r-- | sound/isa/gus/gus_volume.c | 8 |
7 files changed, 33 insertions, 14 deletions
diff --git a/sound/isa/gus/gus_io.c b/sound/isa/gus/gus_io.c index f0570f2bf75f..337b0e2a8a36 100644 --- a/sound/isa/gus/gus_io.c +++ b/sound/isa/gus/gus_io.c | |||
@@ -244,6 +244,8 @@ unsigned short snd_gf1_i_look16(snd_gus_card_t * gus, unsigned char reg) | |||
244 | return res; | 244 | return res; |
245 | } | 245 | } |
246 | 246 | ||
247 | #if 0 | ||
248 | |||
247 | void snd_gf1_i_adlib_write(snd_gus_card_t * gus, | 249 | void snd_gf1_i_adlib_write(snd_gus_card_t * gus, |
248 | unsigned char reg, | 250 | unsigned char reg, |
249 | unsigned char data) | 251 | unsigned char data) |
@@ -265,6 +267,8 @@ void snd_gf1_i_write_addr(snd_gus_card_t * gus, unsigned char reg, | |||
265 | spin_unlock_irqrestore(&gus->reg_lock, flags); | 267 | spin_unlock_irqrestore(&gus->reg_lock, flags); |
266 | } | 268 | } |
267 | 269 | ||
270 | #endif /* 0 */ | ||
271 | |||
268 | unsigned int snd_gf1_i_read_addr(snd_gus_card_t * gus, | 272 | unsigned int snd_gf1_i_read_addr(snd_gus_card_t * gus, |
269 | unsigned char reg, short w_16bit) | 273 | unsigned char reg, short w_16bit) |
270 | { | 274 | { |
@@ -329,6 +333,8 @@ unsigned char snd_gf1_peek(snd_gus_card_t * gus, unsigned int addr) | |||
329 | return res; | 333 | return res; |
330 | } | 334 | } |
331 | 335 | ||
336 | #if 0 | ||
337 | |||
332 | void snd_gf1_pokew(snd_gus_card_t * gus, unsigned int addr, unsigned short data) | 338 | void snd_gf1_pokew(snd_gus_card_t * gus, unsigned int addr, unsigned short data) |
333 | { | 339 | { |
334 | unsigned long flags; | 340 | unsigned long flags; |
@@ -405,9 +411,7 @@ void snd_gf1_dram_setmem(snd_gus_card_t * gus, unsigned int addr, | |||
405 | spin_unlock_irqrestore(&gus->reg_lock, flags); | 411 | spin_unlock_irqrestore(&gus->reg_lock, flags); |
406 | } | 412 | } |
407 | 413 | ||
408 | /* | 414 | #endif /* 0 */ |
409 | |||
410 | */ | ||
411 | 415 | ||
412 | void snd_gf1_select_active_voices(snd_gus_card_t * gus) | 416 | void snd_gf1_select_active_voices(snd_gus_card_t * gus) |
413 | { | 417 | { |
@@ -469,6 +473,8 @@ void snd_gf1_print_voice_registers(snd_gus_card_t * gus) | |||
469 | printk(" -%i- GF1 pan = 0x%x\n", voice, snd_gf1_i_read8(gus, 0x0c)); | 473 | printk(" -%i- GF1 pan = 0x%x\n", voice, snd_gf1_i_read8(gus, 0x0c)); |
470 | } | 474 | } |
471 | 475 | ||
476 | #if 0 | ||
477 | |||
472 | void snd_gf1_print_global_registers(snd_gus_card_t * gus) | 478 | void snd_gf1_print_global_registers(snd_gus_card_t * gus) |
473 | { | 479 | { |
474 | unsigned char global_mode = 0x00; | 480 | unsigned char global_mode = 0x00; |
@@ -528,4 +534,6 @@ void snd_gf1_peek_print_block(snd_gus_card_t * gus, unsigned int addr, int count | |||
528 | } | 534 | } |
529 | } | 535 | } |
530 | 536 | ||
537 | #endif /* 0 */ | ||
538 | |||
531 | #endif | 539 | #endif |
diff --git a/sound/isa/gus/gus_main.c b/sound/isa/gus/gus_main.c index 73f81c14f768..94bbd344be5e 100644 --- a/sound/isa/gus/gus_main.c +++ b/sound/isa/gus/gus_main.c | |||
@@ -459,7 +459,6 @@ EXPORT_SYMBOL(snd_gf1_write16); | |||
459 | EXPORT_SYMBOL(snd_gf1_look16); | 459 | EXPORT_SYMBOL(snd_gf1_look16); |
460 | EXPORT_SYMBOL(snd_gf1_i_write8); | 460 | EXPORT_SYMBOL(snd_gf1_i_write8); |
461 | EXPORT_SYMBOL(snd_gf1_i_look8); | 461 | EXPORT_SYMBOL(snd_gf1_i_look8); |
462 | EXPORT_SYMBOL(snd_gf1_i_write16); | ||
463 | EXPORT_SYMBOL(snd_gf1_i_look16); | 462 | EXPORT_SYMBOL(snd_gf1_i_look16); |
464 | EXPORT_SYMBOL(snd_gf1_dram_addr); | 463 | EXPORT_SYMBOL(snd_gf1_dram_addr); |
465 | EXPORT_SYMBOL(snd_gf1_write_addr); | 464 | EXPORT_SYMBOL(snd_gf1_write_addr); |
@@ -470,8 +469,6 @@ EXPORT_SYMBOL(snd_gf1_alloc_voice); | |||
470 | EXPORT_SYMBOL(snd_gf1_free_voice); | 469 | EXPORT_SYMBOL(snd_gf1_free_voice); |
471 | EXPORT_SYMBOL(snd_gf1_ctrl_stop); | 470 | EXPORT_SYMBOL(snd_gf1_ctrl_stop); |
472 | EXPORT_SYMBOL(snd_gf1_stop_voice); | 471 | EXPORT_SYMBOL(snd_gf1_stop_voice); |
473 | EXPORT_SYMBOL(snd_gf1_start); | ||
474 | EXPORT_SYMBOL(snd_gf1_stop); | ||
475 | /* gus_mixer.c */ | 472 | /* gus_mixer.c */ |
476 | EXPORT_SYMBOL(snd_gf1_new_mixer); | 473 | EXPORT_SYMBOL(snd_gf1_new_mixer); |
477 | /* gus_pcm.c */ | 474 | /* gus_pcm.c */ |
diff --git a/sound/isa/gus/gus_mem.c b/sound/isa/gus/gus_mem.c index bfc2b91001d5..609838e8ef67 100644 --- a/sound/isa/gus/gus_mem.c +++ b/sound/isa/gus/gus_mem.c | |||
@@ -39,8 +39,8 @@ void snd_gf1_mem_lock(snd_gf1_mem_t * alloc, int xup) | |||
39 | } | 39 | } |
40 | } | 40 | } |
41 | 41 | ||
42 | snd_gf1_mem_block_t *snd_gf1_mem_xalloc(snd_gf1_mem_t * alloc, | 42 | static snd_gf1_mem_block_t *snd_gf1_mem_xalloc(snd_gf1_mem_t * alloc, |
43 | snd_gf1_mem_block_t * block) | 43 | snd_gf1_mem_block_t * block) |
44 | { | 44 | { |
45 | snd_gf1_mem_block_t *pblock, *nblock; | 45 | snd_gf1_mem_block_t *pblock, *nblock; |
46 | 46 | ||
@@ -105,8 +105,8 @@ int snd_gf1_mem_xfree(snd_gf1_mem_t * alloc, snd_gf1_mem_block_t * block) | |||
105 | return 0; | 105 | return 0; |
106 | } | 106 | } |
107 | 107 | ||
108 | snd_gf1_mem_block_t *snd_gf1_mem_look(snd_gf1_mem_t * alloc, | 108 | static snd_gf1_mem_block_t *snd_gf1_mem_look(snd_gf1_mem_t * alloc, |
109 | unsigned int address) | 109 | unsigned int address) |
110 | { | 110 | { |
111 | snd_gf1_mem_block_t *block; | 111 | snd_gf1_mem_block_t *block; |
112 | 112 | ||
@@ -118,8 +118,8 @@ snd_gf1_mem_block_t *snd_gf1_mem_look(snd_gf1_mem_t * alloc, | |||
118 | return NULL; | 118 | return NULL; |
119 | } | 119 | } |
120 | 120 | ||
121 | snd_gf1_mem_block_t *snd_gf1_mem_share(snd_gf1_mem_t * alloc, | 121 | static snd_gf1_mem_block_t *snd_gf1_mem_share(snd_gf1_mem_t * alloc, |
122 | unsigned int *share_id) | 122 | unsigned int *share_id) |
123 | { | 123 | { |
124 | snd_gf1_mem_block_t *block; | 124 | snd_gf1_mem_block_t *block; |
125 | 125 | ||
diff --git a/sound/isa/gus/gus_reset.c b/sound/isa/gus/gus_reset.c index b4e66f6a10ae..ef687abc7070 100644 --- a/sound/isa/gus/gus_reset.c +++ b/sound/isa/gus/gus_reset.c | |||
@@ -161,7 +161,8 @@ void snd_gf1_stop_voice(snd_gus_card_t * gus, unsigned short voice) | |||
161 | #endif | 161 | #endif |
162 | } | 162 | } |
163 | 163 | ||
164 | void snd_gf1_clear_voices(snd_gus_card_t * gus, unsigned short v_min, unsigned short v_max) | 164 | static void snd_gf1_clear_voices(snd_gus_card_t * gus, unsigned short v_min, |
165 | unsigned short v_max) | ||
165 | { | 166 | { |
166 | unsigned long flags; | 167 | unsigned long flags; |
167 | unsigned int daddr; | 168 | unsigned int daddr; |
diff --git a/sound/isa/gus/gus_synth.c b/sound/isa/gus/gus_synth.c index 66552e6013a4..f51c386ee192 100644 --- a/sound/isa/gus/gus_synth.c +++ b/sound/isa/gus/gus_synth.c | |||
@@ -99,7 +99,8 @@ static void snd_gus_synth_free_private_instruments(snd_gus_port_t *p, int client | |||
99 | snd_seq_instr_list_free_cond(p->gus->gf1.ilist, &ifree, client, 0); | 99 | snd_seq_instr_list_free_cond(p->gus->gf1.ilist, &ifree, client, 0); |
100 | } | 100 | } |
101 | 101 | ||
102 | int snd_gus_synth_event_input(snd_seq_event_t *ev, int direct, void *private_data, int atomic, int hop) | 102 | static int snd_gus_synth_event_input(snd_seq_event_t *ev, int direct, |
103 | void *private_data, int atomic, int hop) | ||
103 | { | 104 | { |
104 | snd_gus_port_t * p = (snd_gus_port_t *) private_data; | 105 | snd_gus_port_t * p = (snd_gus_port_t *) private_data; |
105 | 106 | ||
diff --git a/sound/isa/gus/gus_tables.h b/sound/isa/gus/gus_tables.h index ed8e9d85ad31..4adf098d3269 100644 --- a/sound/isa/gus/gus_tables.h +++ b/sound/isa/gus/gus_tables.h | |||
@@ -23,6 +23,8 @@ | |||
23 | 23 | ||
24 | #ifdef __GUS_TABLES_ALLOC__ | 24 | #ifdef __GUS_TABLES_ALLOC__ |
25 | 25 | ||
26 | #if 0 | ||
27 | |||
26 | unsigned int snd_gf1_scale_table[SNDRV_GF1_SCALE_TABLE_SIZE] = | 28 | unsigned int snd_gf1_scale_table[SNDRV_GF1_SCALE_TABLE_SIZE] = |
27 | { | 29 | { |
28 | 8372, 8870, 9397, 9956, 10548, 11175, | 30 | 8372, 8870, 9397, 9956, 10548, 11175, |
@@ -49,6 +51,8 @@ unsigned int snd_gf1_scale_table[SNDRV_GF1_SCALE_TABLE_SIZE] = | |||
49 | 12123977, 12844906 | 51 | 12123977, 12844906 |
50 | }; | 52 | }; |
51 | 53 | ||
54 | #endif /* 0 */ | ||
55 | |||
52 | unsigned short snd_gf1_atten_table[SNDRV_GF1_ATTEN_TABLE_SIZE] = { | 56 | unsigned short snd_gf1_atten_table[SNDRV_GF1_ATTEN_TABLE_SIZE] = { |
53 | 4095 /* 0 */,1789 /* 1 */,1533 /* 2 */,1383 /* 3 */,1277 /* 4 */, | 57 | 4095 /* 0 */,1789 /* 1 */,1533 /* 2 */,1383 /* 3 */,1277 /* 4 */, |
54 | 1195 /* 5 */,1127 /* 6 */,1070 /* 7 */,1021 /* 8 */,978 /* 9 */, | 58 | 1195 /* 5 */,1127 /* 6 */,1070 /* 7 */,1021 /* 8 */,978 /* 9 */, |
diff --git a/sound/isa/gus/gus_volume.c b/sound/isa/gus/gus_volume.c index b72bcfb28617..3d36f6c8ee6a 100644 --- a/sound/isa/gus/gus_volume.c +++ b/sound/isa/gus/gus_volume.c | |||
@@ -55,6 +55,8 @@ unsigned short snd_gf1_lvol_to_gvol_raw(unsigned int vol) | |||
55 | return (e << 8) | m; | 55 | return (e << 8) | m; |
56 | } | 56 | } |
57 | 57 | ||
58 | #if 0 | ||
59 | |||
58 | unsigned int snd_gf1_gvol_to_lvol_raw(unsigned short gf1_vol) | 60 | unsigned int snd_gf1_gvol_to_lvol_raw(unsigned short gf1_vol) |
59 | { | 61 | { |
60 | unsigned int rvol; | 62 | unsigned int rvol; |
@@ -108,6 +110,8 @@ unsigned int snd_gf1_calc_ramp_rate(snd_gus_card_t * gus, | |||
108 | return (range << 6) | (increment & 0x3f); | 110 | return (range << 6) | (increment & 0x3f); |
109 | } | 111 | } |
110 | 112 | ||
113 | #endif /* 0 */ | ||
114 | |||
111 | unsigned short snd_gf1_translate_freq(snd_gus_card_t * gus, unsigned int freq16) | 115 | unsigned short snd_gf1_translate_freq(snd_gus_card_t * gus, unsigned int freq16) |
112 | { | 116 | { |
113 | freq16 >>= 3; | 117 | freq16 >>= 3; |
@@ -120,6 +124,8 @@ unsigned short snd_gf1_translate_freq(snd_gus_card_t * gus, unsigned int freq16) | |||
120 | return ((freq16 << 9) + (gus->gf1.playback_freq >> 1)) / gus->gf1.playback_freq; | 124 | return ((freq16 << 9) + (gus->gf1.playback_freq >> 1)) / gus->gf1.playback_freq; |
121 | } | 125 | } |
122 | 126 | ||
127 | #if 0 | ||
128 | |||
123 | short snd_gf1_compute_vibrato(short cents, unsigned short fc_register) | 129 | short snd_gf1_compute_vibrato(short cents, unsigned short fc_register) |
124 | { | 130 | { |
125 | static short vibrato_table[] = | 131 | static short vibrato_table[] = |
@@ -208,3 +214,5 @@ unsigned short snd_gf1_compute_freq(unsigned int freq, | |||
208 | } | 214 | } |
209 | return (unsigned short) fc; | 215 | return (unsigned short) fc; |
210 | } | 216 | } |
217 | |||
218 | #endif /* 0 */ | ||