Merge branch 'fix/pcm-jiffies-check' into fix/asoc

23 files changed, 453 insertions, 402 deletions

diff --git a/sound/usb/Kconfig b/sound/usb/Kconfig
index 4f0eac9bff1e..523aec188ccf 100644
--- a/sound/usb/Kconfig
+++ b/sound/usb/Kconfig
@@ -48,7 +48,10 @@ config SND_USB_CAIAQ
             * Native Instruments Kore Controller
             * Native Instruments Kore Controller 2
             * Native Instruments Audio Kontrol 1
+            * Native Instruments Audio 4 DJ
             * Native Instruments Audio 8 DJ
+            * Native Instruments Guitar Rig Session I/O
+            * Native Instruments Guitar Rig mobile
 
            To compile this driver as a module, choose M here: the module
            will be called snd-usb-caiaq.
diff --git a/sound/usb/caiaq/Makefile b/sound/usb/caiaq/Makefile
index 23dadd5a11cd..388999653aaa 100644
--- a/sound/usb/caiaq/Makefile
+++ b/sound/usb/caiaq/Makefile
@@ -1,4 +1,4 @@
-snd-usb-caiaq-y := caiaq-device.o caiaq-audio.o caiaq-midi.o caiaq-control.o
-snd-usb-caiaq-$(CONFIG_SND_USB_CAIAQ_INPUT) += caiaq-input.o
+snd-usb-caiaq-y := device.o audio.o midi.o control.o
+snd-usb-caiaq-$(CONFIG_SND_USB_CAIAQ_INPUT) += input.o
 
 obj-$(CONFIG_SND_USB_CAIAQ) += snd-usb-caiaq.o
diff --git a/sound/usb/caiaq/caiaq-audio.c b/sound/usb/caiaq/audio.c
index b3a603325835..b13ce767ac72 100644
--- a/sound/usb/caiaq/caiaq-audio.c
+++ b/sound/usb/caiaq/audio.c
@@ -16,20 +16,14 @@
  *   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
 */
 
+#include <linux/spinlock.h>
 #include <linux/init.h>
-#include <linux/module.h>
-#include <linux/moduleparam.h>
-#include <linux/interrupt.h>
 #include <linux/usb.h>
-#include <linux/spinlock.h>
 #include <sound/core.h>
-#include <sound/initval.h>
 #include <sound/pcm.h>
-#include <sound/rawmidi.h>
-#include <linux/input.h>
 
-#include "caiaq-device.h"
-#include "caiaq-audio.h"
+#include "device.h"
+#include "audio.h"
 
 #define N_URBS                  32
 #define CLOCK_DRIFT_TOLERANCE   5
@@ -114,6 +108,7 @@ static int stream_start(struct snd_usb_caiaqdev *dev)
         dev->output_panic = 0;
         dev->first_packet = 1;
         dev->streaming = 1;
+        dev->warned = 0;
 
         for (i = 0; i < N_URBS; i++) {
                 ret = usb_submit_urb(dev->data_urbs_in[i], GFP_ATOMIC);
@@ -200,11 +195,14 @@ static int snd_usb_caiaq_pcm_prepare(struct snd_pcm_substream *substream)
 
         debug("%s(%p)\n", __func__, substream);
         
-        if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+        if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+                dev->period_out_count[index] = BYTES_PER_SAMPLE + 1;
                 dev->audio_out_buf_pos[index] = BYTES_PER_SAMPLE + 1;
-        else
+        } else {
+                dev->period_in_count[index] = BYTES_PER_SAMPLE;
                 dev->audio_in_buf_pos[index] = BYTES_PER_SAMPLE;
-        
+        }
+
         if (dev->streaming)
                 return 0;
         
@@ -305,8 +303,7 @@ static void check_for_elapsed_periods(struct snd_usb_caiaqdev *dev,
                 if (!sub)
                         continue;
 
-                pb = frames_to_bytes(sub->runtime, 
-                                     sub->runtime->period_size);
+                pb = snd_pcm_lib_period_bytes(sub);
                 cnt = (sub->stream == SNDRV_PCM_STREAM_PLAYBACK) ?
                                         &dev->period_out_count[stream] :
                                         &dev->period_in_count[stream];
@@ -376,6 +373,9 @@ static void read_in_urb_mode2(struct snd_usb_caiaqdev *dev,
 
                 for (stream = 0; stream < dev->n_streams; stream++, i++) {
                         sub = dev->sub_capture[stream];
+                        if (dev->input_panic)
+                                usb_buf[i] = 0;
+
                         if (sub) {
                                 struct snd_pcm_runtime *rt = sub->runtime;
                                 char *audio_buf = rt->dma_area;
@@ -397,6 +397,9 @@ static void read_in_urb(struct snd_usb_caiaqdev *dev,
         if (!dev->streaming)
                 return;
 
+        if (iso->actual_length < dev->bpp)
+                return;
+
         switch (dev->spec.data_alignment) {
         case 0:
                 read_in_urb_mode0(dev, urb, iso);
@@ -406,10 +409,11 @@ static void read_in_urb(struct snd_usb_caiaqdev *dev,
                 break;
         }
 
-        if (dev->input_panic || dev->output_panic) {
+        if ((dev->input_panic || dev->output_panic) && !dev->warned) {
                 debug("streaming error detected %s %s\n", 
                                 dev->input_panic ? "(input)" : "",
                                 dev->output_panic ? "(output)" : "");
+                dev->warned = 1;
         }
 }
 
@@ -638,9 +642,10 @@ int snd_usb_caiaq_audio_init(struct snd_usb_caiaqdev *dev)
         case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AK1):
         case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_RIGKONTROL3):
         case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_SESSIONIO):
-                dev->samplerates |= SNDRV_PCM_RATE_88200;
+        case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_GUITARRIGMOBILE):
                 dev->samplerates |= SNDRV_PCM_RATE_192000;
-                break;
+                /* fall thru */
+        case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO4DJ):
         case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO8DJ):
                 dev->samplerates |= SNDRV_PCM_RATE_88200;
                 break;
diff --git a/sound/usb/caiaq/caiaq-audio.h b/sound/usb/caiaq/audio.h
index 8ab1f8d9529e..8ab1f8d9529e 100644
--- a/sound/usb/caiaq/caiaq-audio.h
+++ b/sound/usb/caiaq/audio.h
diff --git a/sound/usb/caiaq/caiaq-control.c b/sound/usb/caiaq/control.c
index ccd763dd7167..537102ba6b9d 100644
--- a/sound/usb/caiaq/caiaq-control.c
+++ b/sound/usb/caiaq/control.c
@@ -18,17 +18,13 @@
  */
 
 #include <linux/init.h>
-#include <linux/interrupt.h>
 #include <linux/usb.h>
+#include <sound/control.h>
 #include <sound/core.h>
-#include <sound/initval.h>
 #include <sound/pcm.h>
-#include <sound/rawmidi.h>
-#include <sound/control.h>
-#include <linux/input.h>
 
-#include "caiaq-device.h"
-#include "caiaq-control.h"
+#include "device.h"
+#include "control.h"
 
 #define CNT_INTVAL 0x10000
 
@@ -39,12 +35,12 @@ static int control_info(struct snd_kcontrol *kcontrol,
         struct snd_usb_caiaqdev *dev = caiaqdev(chip->card);
         int pos = kcontrol->private_value;
         int is_intval = pos & CNT_INTVAL;
+        unsigned int id = dev->chip.usb_id;
 
         uinfo->count = 1;
         pos &= ~CNT_INTVAL;
 
-        if (dev->chip.usb_id ==
-                USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO8DJ)
+        if (id == USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO8DJ)
                 && (pos == 0)) {
                 /* current input mode of A8DJ */
                 uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
@@ -53,6 +49,15 @@ static int control_info(struct snd_kcontrol *kcontrol,
                 return 0;
         }
 
+        if (id == USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO4DJ)
+                && (pos == 0)) {
+                /* current input mode of A4DJ */
+                uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
+                uinfo->value.integer.min = 0;
+                uinfo->value.integer.max = 1;
+                return 0;
+        }
+
         if (is_intval) {
                 uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
                 uinfo->value.integer.min = 0;
@@ -73,6 +78,14 @@ static int control_get(struct snd_kcontrol *kcontrol,
         struct snd_usb_caiaqdev *dev = caiaqdev(chip->card);
         int pos = kcontrol->private_value;
 
+        if (dev->chip.usb_id ==
+                USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO4DJ)) {
+                /* A4DJ has only one control */
+                /* do not expose hardware input mode 0 */
+                ucontrol->value.integer.value[0] = dev->control_state[0] - 1;
+                return 0;
+        }
+
         if (pos & CNT_INTVAL)
                 ucontrol->value.integer.value[0]
                         = dev->control_state[pos & ~CNT_INTVAL];
@@ -90,10 +103,20 @@ static int control_put(struct snd_kcontrol *kcontrol,
         struct snd_usb_caiaqdev *dev = caiaqdev(chip->card);
         int pos = kcontrol->private_value;
 
+        if (dev->chip.usb_id ==
+                USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO4DJ)) {
+                /* A4DJ has only one control */
+                /* do not expose hardware input mode 0 */
+                dev->control_state[0] = ucontrol->value.integer.value[0] + 1;
+                snd_usb_caiaq_send_command(dev, EP1_CMD_WRITE_IO,
+                                dev->control_state, sizeof(dev->control_state));
+                return 1;
+        }
+
         if (pos & CNT_INTVAL) {
                 dev->control_state[pos & ~CNT_INTVAL]
                         = ucontrol->value.integer.value[0];
-                snd_usb_caiaq_send_command(dev, EP1_CMD_DIMM_LEDS,
+                snd_usb_caiaq_send_command(dev, EP1_CMD_WRITE_IO,
                                 dev->control_state, sizeof(dev->control_state));
         } else {
                 if (ucontrol->value.integer.value[0])
@@ -243,10 +266,13 @@ static struct caiaq_controller a8dj_controller[] = {
         { "GND lift for TC Vinyl mode",         24 + 0          },
         { "GND lift for TC CD/Line mode",       24 + 1          },
         { "GND lift for phono mode",            24 + 2          },
-        { "GND lift for TC Vinyl mode",         24 + 3          },
         { "Software lock",                      40              }
 };
 
+static struct caiaq_controller a4dj_controller[] = {
+        { "Current input mode", 0 | CNT_INTVAL  }
+};
+
 static int __devinit add_controls(struct caiaq_controller *c, int num,
                                   struct snd_usb_caiaqdev *dev)
 {
@@ -295,6 +321,10 @@ int __devinit snd_usb_caiaq_control_init(struct snd_usb_caiaqdev *dev)
                 ret = add_controls(a8dj_controller,
                         ARRAY_SIZE(a8dj_controller), dev);
                 break;
+        case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO4DJ):
+                ret = add_controls(a4dj_controller,
+                        ARRAY_SIZE(a4dj_controller), dev);
+                break;
         }
 
         return ret;
diff --git a/sound/usb/caiaq/caiaq-control.h b/sound/usb/caiaq/control.h
index 2e7ab1aa4fb3..2e7ab1aa4fb3 100644
--- a/sound/usb/caiaq/caiaq-control.h
+++ b/sound/usb/caiaq/control.h
diff --git a/sound/usb/caiaq/caiaq-device.c b/sound/usb/caiaq/device.c
index 09aed2363cc9..515de1cd2a3e 100644
--- a/sound/usb/caiaq/caiaq-device.c
+++ b/sound/usb/caiaq/device.c
@@ -19,38 +19,33 @@
  *   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
 */
 
-#include <linux/init.h>
-#include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/interrupt.h>
+#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/usb.h>
-#include <linux/input.h>
-#include <linux/spinlock.h>
-#include <sound/core.h>
 #include <sound/initval.h>
+#include <sound/core.h>
 #include <sound/pcm.h>
-#include <sound/rawmidi.h>
-#include <sound/control.h>
-
-#include "caiaq-device.h"
-#include "caiaq-audio.h"
-#include "caiaq-midi.h"
-#include "caiaq-control.h"
 
-#ifdef CONFIG_SND_USB_CAIAQ_INPUT
-#include "caiaq-input.h"
-#endif
+#include "device.h"
+#include "audio.h"
+#include "midi.h"
+#include "control.h"
+#include "input.h"
 
 MODULE_AUTHOR("Daniel Mack <daniel@caiaq.de>");
-MODULE_DESCRIPTION("caiaq USB audio, version 1.3.10");
+MODULE_DESCRIPTION("caiaq USB audio, version 1.3.14");
 MODULE_LICENSE("GPL");
 MODULE_SUPPORTED_DEVICE("{{Native Instruments, RigKontrol2},"
                          "{Native Instruments, RigKontrol3},"
                          "{Native Instruments, Kore Controller},"
                          "{Native Instruments, Kore Controller 2},"
                          "{Native Instruments, Audio Kontrol 1},"
+                         "{Native Instruments, Audio 4 DJ},"
                          "{Native Instruments, Audio 8 DJ},"
-                         "{Native Instruments, Session I/O}}");
+                         "{Native Instruments, Session I/O},"
+                         "{Native Instruments, GuitarRig mobile}");
 
 static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX; /* Index 0-max */
 static char* id[SNDRV_CARDS] = SNDRV_DEFAULT_STR; /* Id for this card */
@@ -116,6 +111,16 @@ static struct usb_device_id snd_usb_id_table[] = {
                 .idVendor =     USB_VID_NATIVEINSTRUMENTS,
                 .idProduct =    USB_PID_SESSIONIO
         },
+        {
+                .match_flags =  USB_DEVICE_ID_MATCH_DEVICE,
+                .idVendor =     USB_VID_NATIVEINSTRUMENTS,
+                .idProduct =    USB_PID_GUITARRIGMOBILE
+        },
+        {
+                .match_flags =  USB_DEVICE_ID_MATCH_DEVICE,
+                .idVendor =     USB_VID_NATIVEINSTRUMENTS,
+                .idProduct =    USB_PID_AUDIO4DJ
+        },
         { /* terminator */ }
 };
 
@@ -239,6 +244,8 @@ int snd_usb_caiaq_set_audio_params (struct snd_usb_caiaqdev *dev,
                 
         if (dev->audio_parm_answer != 1) 
                 debug("unable to set the device's audio params\n");
+        else
+                dev->bpp = bpp;
 
         return dev->audio_parm_answer == 1 ? 0 : -EINVAL;
 }
@@ -300,6 +307,12 @@ static void __devinit setup_card(struct snd_usb_caiaqdev *dev)
                 }
 
                 break;
+        case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO4DJ):
+                /* Audio 4 DJ - default input mode to phono */
+                dev->control_state[0] = 2;
+                snd_usb_caiaq_send_command(dev, EP1_CMD_WRITE_IO,
+                        dev->control_state, 1);
+                break;
         }
         
         if (dev->spec.num_analog_audio_out +
diff --git a/sound/usb/caiaq/caiaq-device.h b/sound/usb/caiaq/device.h
index ab56e738c5fc..4cce1ad7493d 100644
--- a/sound/usb/caiaq/caiaq-device.h
+++ b/sound/usb/caiaq/device.h
@@ -10,8 +10,10 @@
 #define USB_PID_KORECONTROLLER  0x4711
 #define USB_PID_KORECONTROLLER2 0x4712
 #define USB_PID_AK1             0x0815
+#define USB_PID_AUDIO4DJ        0x0839
 #define USB_PID_AUDIO8DJ        0x1978
 #define USB_PID_SESSIONIO       0x1915
+#define USB_PID_GUITARRIGMOBILE 0x0d8d
 
 #define EP1_BUFSIZE 64
 #define CAIAQ_USB_STR_LEN 0xff
@@ -87,9 +89,9 @@ struct snd_usb_caiaqdev {
         int audio_out_buf_pos[MAX_STREAMS];
         int period_in_count[MAX_STREAMS];
         int period_out_count[MAX_STREAMS];
-        int input_panic, output_panic;
+        int input_panic, output_panic, warned;
         char *audio_in_buf, *audio_out_buf;
-        unsigned int samplerates;
+        unsigned int samplerates, bpp;
 
         struct snd_pcm_substream *sub_playback[MAX_STREAMS];
         struct snd_pcm_substream *sub_capture[MAX_STREAMS];
diff --git a/sound/usb/caiaq/caiaq-input.c b/sound/usb/caiaq/input.c
index f743847a5e5a..a48d309bd94c 100644
--- a/sound/usb/caiaq/caiaq-input.c
+++ b/sound/usb/caiaq/input.c
@@ -17,17 +17,12 @@
 */
 
 #include <linux/init.h>
-#include <linux/module.h>
-#include <linux/moduleparam.h>
-#include <linux/input.h>
 #include <linux/usb.h>
 #include <linux/usb/input.h>
-#include <linux/spinlock.h>
-#include <sound/core.h>
-#include <sound/rawmidi.h>
 #include <sound/pcm.h>
-#include "caiaq-device.h"
-#include "caiaq-input.h"
+
+#include "device.h"
+#include "input.h"
 
 static unsigned short keycode_ak1[] =  { KEY_C, KEY_B, KEY_A };
 static unsigned short keycode_rk2[] =  { KEY_1, KEY_2, KEY_3, KEY_4,
diff --git a/sound/usb/caiaq/caiaq-input.h b/sound/usb/caiaq/input.h
index ced535577864..ced535577864 100644
--- a/sound/usb/caiaq/caiaq-input.h
+++ b/sound/usb/caiaq/input.h
diff --git a/sound/usb/caiaq/caiaq-midi.c b/sound/usb/caiaq/midi.c
index f19fd360c936..8fa8cd88d763 100644
--- a/sound/usb/caiaq/caiaq-midi.c
+++ b/sound/usb/caiaq/midi.c
@@ -16,20 +16,13 @@
  *   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
 */
 
-#include <linux/init.h>
-#include <linux/module.h>
-#include <linux/moduleparam.h>
-#include <linux/interrupt.h>
 #include <linux/usb.h>
-#include <linux/input.h>
-#include <linux/spinlock.h>
-#include <sound/core.h>
 #include <sound/rawmidi.h>
+#include <sound/core.h>
 #include <sound/pcm.h>
 
-#include "caiaq-device.h"
-#include "caiaq-midi.h"
-
+#include "device.h"
+#include "midi.h"
 
 static int snd_usb_caiaq_midi_input_open(struct snd_rawmidi_substream *substream)
 {
diff --git a/sound/usb/caiaq/caiaq-midi.h b/sound/usb/caiaq/midi.h
index 9d16db027fc3..9d16db027fc3 100644
--- a/sound/usb/caiaq/caiaq-midi.h
+++ b/sound/usb/caiaq/midi.h
diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c
index eec32e1a3020..823296d7d578 100644
--- a/sound/usb/usbaudio.c
+++ b/sound/usb/usbaudio.c
@@ -107,7 +107,7 @@ MODULE_PARM_DESC(ignore_ctl_error,
 #define MAX_PACKS_HS    (MAX_PACKS * 8) /* in high speed mode */
 #define MAX_URBS        8
 #define SYNC_URBS       4       /* always four urbs for sync */
-#define MIN_PACKS_URB   1       /* minimum 1 packet per urb */
+#define MAX_QUEUE       24      /* try not to exceed this queue length, in ms */
 
 struct audioformat {
         struct list_head list;
@@ -121,6 +121,7 @@ struct audioformat {
         unsigned char attributes;       /* corresponding attributes of cs endpoint */
         unsigned char endpoint;         /* endpoint */
         unsigned char ep_attr;          /* endpoint attributes */
+        unsigned char datainterval;     /* log_2 of data packet interval */
         unsigned int maxpacksize;       /* max. packet size */
         unsigned int rates;             /* rate bitmasks */
         unsigned int rate_min, rate_max;        /* min/max rates */
@@ -170,7 +171,6 @@ struct snd_usb_substream {
         unsigned int curframesize;      /* current packet size in frames (for capture) */
         unsigned int fill_max: 1;       /* fill max packet size always */
         unsigned int fmt_type;          /* USB audio format type (1-3) */
-        unsigned int packs_per_ms;      /* packets per millisecond (for playback) */
 
         unsigned int running: 1;        /* running status */
 
@@ -525,7 +525,7 @@ static int snd_usb_audio_next_packet_size(struct snd_usb_substream *subs)
 /*
  * Prepare urb for streaming before playback starts or when paused.
  *
- * We don't have any data, so we send a frame of silence.
+ * We don't have any data, so we send silence.
  */
 static int prepare_nodata_playback_urb(struct snd_usb_substream *subs,
                                        struct snd_pcm_runtime *runtime,
@@ -537,13 +537,13 @@ static int prepare_nodata_playback_urb(struct snd_usb_substream *subs,
 
         offs = 0;
         urb->dev = ctx->subs->dev;
-        urb->number_of_packets = subs->packs_per_ms;
-        for (i = 0; i < subs->packs_per_ms; ++i) {
+        for (i = 0; i < ctx->packets; ++i) {
                 counts = snd_usb_audio_next_packet_size(subs);
                 urb->iso_frame_desc[i].offset = offs * stride;
                 urb->iso_frame_desc[i].length = counts * stride;
                 offs += counts;
         }
+        urb->number_of_packets = ctx->packets;
         urb->transfer_buffer_length = offs * stride;
         memset(urb->transfer_buffer,
                subs->cur_audiofmt->format == SNDRV_PCM_FORMAT_U8 ? 0x80 : 0,
@@ -607,9 +607,7 @@ static int prepare_playback_urb(struct snd_usb_substream *subs,
                                 break;
                         }
                 }
-                /* finish at the frame boundary at/after the period boundary */
-                if (period_elapsed &&
-                    (i & (subs->packs_per_ms - 1)) == subs->packs_per_ms - 1)
+                if (period_elapsed) /* finish at the period boundary */
                         break;
         }
         if (subs->hwptr_done + offs > runtime->buffer_size) {
@@ -1034,9 +1032,9 @@ static void release_substream_urbs(struct snd_usb_substream *subs, int force)
 static int init_substream_urbs(struct snd_usb_substream *subs, unsigned int period_bytes,
                                unsigned int rate, unsigned int frame_bits)
 {
-        unsigned int maxsize, n, i;
+        unsigned int maxsize, i;
         int is_playback = subs->direction == SNDRV_PCM_STREAM_PLAYBACK;
-        unsigned int npacks[MAX_URBS], urb_packs, total_packs, packs_per_ms;
+        unsigned int urb_packs, total_packs, packs_per_ms;
 
         /* calculate the frequency in 16.16 format */
         if (snd_usb_get_speed(subs->dev) == USB_SPEED_FULL)
@@ -1067,11 +1065,9 @@ static int init_substream_urbs(struct snd_usb_substream *subs, unsigned int peri
                 packs_per_ms = 8 >> subs->datainterval;
         else
                 packs_per_ms = 1;
-        subs->packs_per_ms = packs_per_ms;
 
         if (is_playback) {
-                urb_packs = nrpacks;
-                urb_packs = max(urb_packs, (unsigned int)MIN_PACKS_URB);
+                urb_packs = max(nrpacks, 1);
                 urb_packs = min(urb_packs, (unsigned int)MAX_PACKS);
         } else
                 urb_packs = 1;
@@ -1079,7 +1075,7 @@ static int init_substream_urbs(struct snd_usb_substream *subs, unsigned int peri
 
         /* decide how many packets to be used */
         if (is_playback) {
-                unsigned int minsize;
+                unsigned int minsize, maxpacks;
                 /* determine how small a packet can be */
                 minsize = (subs->freqn >> (16 - subs->datainterval))
                           * (frame_bits >> 3);
@@ -1088,13 +1084,17 @@ static int init_substream_urbs(struct snd_usb_substream *subs, unsigned int peri
                         minsize -= minsize >> 3;
                 minsize = max(minsize, 1u);
                 total_packs = (period_bytes + minsize - 1) / minsize;
-                /* round up to multiple of packs_per_ms */
-                total_packs = (total_packs + packs_per_ms - 1)
-                                & ~(packs_per_ms - 1);
                 /* we need at least two URBs for queueing */
-                if (total_packs < 2 * MIN_PACKS_URB * packs_per_ms)
-                        total_packs = 2 * MIN_PACKS_URB * packs_per_ms;
+                if (total_packs < 2) {
+                        total_packs = 2;
+                } else {
+                        /* and we don't want too long a queue either */
+                        maxpacks = max(MAX_QUEUE * packs_per_ms, urb_packs * 2);
+                        total_packs = min(total_packs, maxpacks);
+                }
         } else {
+                while (urb_packs > 1 && urb_packs * maxsize >= period_bytes)
+                        urb_packs >>= 1;
                 total_packs = MAX_URBS * urb_packs;
         }
         subs->nurbs = (total_packs + urb_packs - 1) / urb_packs;
@@ -1102,31 +1102,11 @@ static int init_substream_urbs(struct snd_usb_substream *subs, unsigned int peri
                 /* too much... */
                 subs->nurbs = MAX_URBS;
                 total_packs = MAX_URBS * urb_packs;
-        }
-        n = total_packs;
-        for (i = 0; i < subs->nurbs; i++) {
-                npacks[i] = n > urb_packs ? urb_packs : n;
-                n -= urb_packs;
-        }
-        if (subs->nurbs <= 1) {
+        } else if (subs->nurbs < 2) {
                 /* too little - we need at least two packets
                  * to ensure contiguous playback/capture
                  */
                 subs->nurbs = 2;
-                npacks[0] = (total_packs + 1) / 2;
-                npacks[1] = total_packs - npacks[0];
-        } else if (npacks[subs->nurbs-1] < MIN_PACKS_URB * packs_per_ms) {
-                /* the last packet is too small.. */
-                if (subs->nurbs > 2) {
-                        /* merge to the first one */
-                        npacks[0] += npacks[subs->nurbs - 1];
-                        subs->nurbs--;
-                } else {
-                        /* divide to two */
-                        subs->nurbs = 2;
-                        npacks[0] = (total_packs + 1) / 2;
-                        npacks[1] = total_packs - npacks[0];
-                }
         }
 
         /* allocate and initialize data urbs */
@@ -1134,7 +1114,8 @@ static int init_substream_urbs(struct snd_usb_substream *subs, unsigned int peri
                 struct snd_urb_ctx *u = &subs->dataurb[i];
                 u->index = i;
                 u->subs = subs;
-                u->packets = npacks[i];
+                u->packets = (i + 1) * total_packs / subs->nurbs
+                        - i * total_packs / subs->nurbs;
                 u->buffer_size = maxsize * u->packets;
                 if (subs->fmt_type == USB_FORMAT_TYPE_II)
                         u->packets++; /* for transfer delimiter */
@@ -1292,14 +1273,14 @@ static int init_usb_sample_rate(struct usb_device *dev, int iface,
                 if ((err = snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0), SET_CUR,
                                            USB_TYPE_CLASS|USB_RECIP_ENDPOINT|USB_DIR_OUT,
                                            SAMPLING_FREQ_CONTROL << 8, ep, data, 3, 1000)) < 0) {
-                        snd_printk(KERN_ERR "%d:%d:%d: cannot set freq %d to ep 0x%x\n",
+                        snd_printk(KERN_ERR "%d:%d:%d: cannot set freq %d to ep %#x\n",
                                    dev->devnum, iface, fmt->altsetting, rate, ep);
                         return err;
                 }
                 if ((err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), GET_CUR,
                                            USB_TYPE_CLASS|USB_RECIP_ENDPOINT|USB_DIR_IN,
                                            SAMPLING_FREQ_CONTROL << 8, ep, data, 3, 1000)) < 0) {
-                        snd_printk(KERN_WARNING "%d:%d:%d: cannot get freq at ep 0x%x\n",
+                        snd_printk(KERN_WARNING "%d:%d:%d: cannot get freq at ep %#x\n",
                                    dev->devnum, iface, fmt->altsetting, ep);
                         return 0; /* some devices don't support reading */
                 }
@@ -1365,12 +1346,7 @@ static int set_format(struct snd_usb_substream *subs, struct audioformat *fmt)
                 subs->datapipe = usb_sndisocpipe(dev, ep);
         else
                 subs->datapipe = usb_rcvisocpipe(dev, ep);
-        if (snd_usb_get_speed(subs->dev) == USB_SPEED_HIGH &&
-            get_endpoint(alts, 0)->bInterval >= 1 &&
-            get_endpoint(alts, 0)->bInterval <= 4)
-                subs->datainterval = get_endpoint(alts, 0)->bInterval - 1;
-        else
-                subs->datainterval = 0;
+        subs->datainterval = fmt->datainterval;
         subs->syncpipe = subs->syncinterval = 0;
         subs->maxpacksize = fmt->maxpacksize;
         subs->fill_max = 0;
@@ -1431,9 +1407,11 @@ static int set_format(struct snd_usb_substream *subs, struct audioformat *fmt)
         subs->cur_audiofmt = fmt;
 
 #if 0
-        printk("setting done: format = %d, rate = %d..%d, channels = %d\n",
+        printk(KERN_DEBUG
+               "setting done: format = %d, rate = %d..%d, channels = %d\n",
                fmt->format, fmt->rate_min, fmt->rate_max, fmt->channels);
-        printk("  datapipe = 0x%0x, syncpipe = 0x%0x\n",
+        printk(KERN_DEBUG
+               "  datapipe = 0x%0x, syncpipe = 0x%0x\n",
                subs->datapipe, subs->syncpipe);
 #endif
 
@@ -1468,7 +1446,7 @@ static int snd_usb_hw_params(struct snd_pcm_substream *substream,
         channels = params_channels(hw_params);
         fmt = find_format(subs, format, rate, channels);
         if (!fmt) {
-                snd_printd(KERN_DEBUG "cannot set format: format = 0x%x, rate = %d, channels = %d\n",
+                snd_printd(KERN_DEBUG "cannot set format: format = %#x, rate = %d, channels = %d\n",
                            format, rate, channels);
                 return -EINVAL;
         }
@@ -1581,11 +1559,15 @@ static struct snd_pcm_hardware snd_usb_hardware =
 #define hwc_debug(fmt, args...) /**/
 #endif
 
-static int hw_check_valid_format(struct snd_pcm_hw_params *params, struct audioformat *fp)
+static int hw_check_valid_format(struct snd_usb_substream *subs,
+                                 struct snd_pcm_hw_params *params,
+                                 struct audioformat *fp)
 {
         struct snd_interval *it = hw_param_interval(params, SNDRV_PCM_HW_PARAM_RATE);
         struct snd_interval *ct = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
         struct snd_mask *fmts = hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT);
+        struct snd_interval *pt = hw_param_interval(params, SNDRV_PCM_HW_PARAM_PERIOD_TIME);
+        unsigned int ptime;
 
         /* check the format */
         if (!snd_mask_test(fmts, fp->format)) {
@@ -1606,6 +1588,14 @@ static int hw_check_valid_format(struct snd_pcm_hw_params *params, struct audiof
                 hwc_debug("   > check: rate_max %d < min %d\n", fp->rate_max, it->min);
                 return 0;
         }
+        /* check whether the period time is >= the data packet interval */
+        if (snd_usb_get_speed(subs->dev) == USB_SPEED_HIGH) {
+                ptime = 125 * (1 << fp->datainterval);
+                if (ptime > pt->max || (ptime == pt->max && pt->openmax)) {
+                        hwc_debug("   > check: ptime %u > max %u\n", ptime, pt->max);
+                        return 0;
+                }
+        }
         return 1;
 }
 
@@ -1624,7 +1614,7 @@ static int hw_rule_rate(struct snd_pcm_hw_params *params,
         list_for_each(p, &subs->fmt_list) {
                 struct audioformat *fp;
                 fp = list_entry(p, struct audioformat, list);
-                if (!hw_check_valid_format(params, fp))
+                if (!hw_check_valid_format(subs, params, fp))
                         continue;
                 if (changed++) {
                         if (rmin > fp->rate_min)
@@ -1678,7 +1668,7 @@ static int hw_rule_channels(struct snd_pcm_hw_params *params,
         list_for_each(p, &subs->fmt_list) {
                 struct audioformat *fp;
                 fp = list_entry(p, struct audioformat, list);
-                if (!hw_check_valid_format(params, fp))
+                if (!hw_check_valid_format(subs, params, fp))
                         continue;
                 if (changed++) {
                         if (rmin > fp->channels)
@@ -1731,7 +1721,7 @@ static int hw_rule_format(struct snd_pcm_hw_params *params,
         list_for_each(p, &subs->fmt_list) {
                 struct audioformat *fp;
                 fp = list_entry(p, struct audioformat, list);
-                if (!hw_check_valid_format(params, fp))
+                if (!hw_check_valid_format(subs, params, fp))
                         continue;
                 fbits |= (1ULL << fp->format);
         }
@@ -1749,95 +1739,42 @@ static int hw_rule_format(struct snd_pcm_hw_params *params,
         return changed;
 }
 
-#define MAX_MASK        64
-
-/*
- * check whether the registered audio formats need special hw-constraints
- */
-static int check_hw_params_convention(struct snd_usb_substream *subs)
+static int hw_rule_period_time(struct snd_pcm_hw_params *params,
+                               struct snd_pcm_hw_rule *rule)
 {
-        int i;
-        u32 *channels;
-        u32 *rates;
-        u32 cmaster, rmaster;
-        u32 rate_min = 0, rate_max = 0;
-        struct list_head *p;
-        int err = 1;
-
-        channels = kcalloc(MAX_MASK, sizeof(u32), GFP_KERNEL);
-        rates = kcalloc(MAX_MASK, sizeof(u32), GFP_KERNEL);
-        if (!channels || !rates) {
-                err = -ENOMEM;
-                goto __out;
-        }
+        struct snd_usb_substream *subs = rule->private;
+        struct audioformat *fp;
+        struct snd_interval *it;
+        unsigned char min_datainterval;
+        unsigned int pmin;
+        int changed;
 
-        list_for_each(p, &subs->fmt_list) {
-                struct audioformat *f;
-                f = list_entry(p, struct audioformat, list);
-                /* unconventional channels? */
-                if (f->channels > 32)
-                        goto __out;
-                /* continuous rate min/max matches? */
-                if (f->rates & SNDRV_PCM_RATE_CONTINUOUS) {
-                        if (rate_min && f->rate_min != rate_min)
-                                goto __out;
-                        if (rate_max && f->rate_max != rate_max)
-                                goto __out;
-                        rate_min = f->rate_min;
-                        rate_max = f->rate_max;
-                }
-                /* combination of continuous rates and fixed rates? */
-                if (rates[f->format] & SNDRV_PCM_RATE_CONTINUOUS) {
-                        if (f->rates != rates[f->format])
-                                goto __out;
-                }
-                if (f->rates & SNDRV_PCM_RATE_CONTINUOUS) {
-                        if (rates[f->format] && rates[f->format] != f->rates)
-                                goto __out;
-                }
-                channels[f->format] |= (1 << f->channels);
-                rates[f->format] |= f->rates;
-                /* needs knot? */
-                if (f->rates & SNDRV_PCM_RATE_KNOT)
-                        goto __out;
-        }
-        /* check whether channels and rates match for all formats */
-        cmaster = rmaster = 0;
-        for (i = 0; i < MAX_MASK; i++) {
-                if (cmaster != channels[i] && cmaster && channels[i])
-                        goto __out;
-                if (rmaster != rates[i] && rmaster && rates[i])
-                        goto __out;
-                if (channels[i])
-                        cmaster = channels[i];
-                if (rates[i])
-                        rmaster = rates[i];
-        }
-        /* check whether channels match for all distinct rates */
-        memset(channels, 0, MAX_MASK * sizeof(u32));
-        list_for_each(p, &subs->fmt_list) {
-                struct audioformat *f;
-                f = list_entry(p, struct audioformat, list);
-                if (f->rates & SNDRV_PCM_RATE_CONTINUOUS)
+        it = hw_param_interval(params, SNDRV_PCM_HW_PARAM_PERIOD_TIME);
+        hwc_debug("hw_rule_period_time: (%u,%u)\n", it->min, it->max);
+        min_datainterval = 0xff;
+        list_for_each_entry(fp, &subs->fmt_list, list) {
+                if (!hw_check_valid_format(subs, params, fp))
                         continue;
-                for (i = 0; i < 32; i++) {
-                        if (f->rates & (1 << i))
-                                channels[i] |= (1 << f->channels);
-                }
+                min_datainterval = min(min_datainterval, fp->datainterval);
+        }
+        if (min_datainterval == 0xff) {
+                hwc_debug("  --> get emtpy\n");
+                it->empty = 1;
+                return -EINVAL;
         }
-        cmaster = 0;
-        for (i = 0; i < 32; i++) {
-                if (cmaster != channels[i] && cmaster && channels[i])
-                        goto __out;
-                if (channels[i])
-                        cmaster = channels[i];
+        pmin = 125 * (1 << min_datainterval);
+        changed = 0;
+        if (it->min < pmin) {
+                it->min = pmin;
+                it->openmin = 0;
+                changed = 1;
         }
-        err = 0;
-
- __out:
-        kfree(channels);
-        kfree(rates);
-        return err;
+        if (snd_interval_checkempty(it)) {
+                it->empty = 1;
+                return -EINVAL;
+        }
+        hwc_debug("  --> (%u,%u) (changed = %d)\n", it->min, it->max, changed);
+        return changed;
 }
 
 /*
@@ -1885,6 +1822,8 @@ static int snd_usb_pcm_check_knot(struct snd_pcm_runtime *runtime,
 static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substream *subs)
 {
         struct list_head *p;
+        unsigned int pt, ptmin;
+        int param_period_time_if_needed;
         int err;
 
         runtime->hw.formats = subs->formats;
@@ -1894,6 +1833,7 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre
         runtime->hw.channels_min = 256;
         runtime->hw.channels_max = 0;
         runtime->hw.rates = 0;
+        ptmin = UINT_MAX;
         /* check min/max rates and channels */
         list_for_each(p, &subs->fmt_list) {
                 struct audioformat *fp;
@@ -1912,42 +1852,54 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre
                         runtime->hw.period_bytes_min = runtime->hw.period_bytes_max =
                                 fp->frame_size;
                 }
+                pt = 125 * (1 << fp->datainterval);
+                ptmin = min(ptmin, pt);
         }
 
-        /* set the period time minimum 1ms */
-        /* FIXME: high-speed mode allows 125us minimum period, but many parts
-         * in the current code assume the 1ms period.
-         */
+        param_period_time_if_needed = SNDRV_PCM_HW_PARAM_PERIOD_TIME;
+        if (snd_usb_get_speed(subs->dev) != USB_SPEED_HIGH)
+                /* full speed devices have fixed data packet interval */
+                ptmin = 1000;
+        if (ptmin == 1000)
+                /* if period time doesn't go below 1 ms, no rules needed */
+                param_period_time_if_needed = -1;
         snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_PERIOD_TIME,
-                                     1000 * MIN_PACKS_URB,
-                                     /*(nrpacks * MAX_URBS) * 1000*/ UINT_MAX);
-
-        err = check_hw_params_convention(subs);
-        if (err < 0)
+                                     ptmin, UINT_MAX);
+
+        if ((err = snd_pcm_hw_rule_add(runtime, 0, SNDRV_PCM_HW_PARAM_RATE,
+                                       hw_rule_rate, subs,
+                                       SNDRV_PCM_HW_PARAM_FORMAT,
+                                       SNDRV_PCM_HW_PARAM_CHANNELS,
+                                       param_period_time_if_needed,
+                                       -1)) < 0)
                 return err;
-        else if (err) {
-                hwc_debug("setting extra hw constraints...\n");
-                if ((err = snd_pcm_hw_rule_add(runtime, 0, SNDRV_PCM_HW_PARAM_RATE,
-                                               hw_rule_rate, subs,
-                                               SNDRV_PCM_HW_PARAM_FORMAT,
-                                               SNDRV_PCM_HW_PARAM_CHANNELS,
-                                               -1)) < 0)
-                        return err;
-                if ((err = snd_pcm_hw_rule_add(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
-                                               hw_rule_channels, subs,
-                                               SNDRV_PCM_HW_PARAM_FORMAT,
-                                               SNDRV_PCM_HW_PARAM_RATE,
-                                               -1)) < 0)
-                        return err;
-                if ((err = snd_pcm_hw_rule_add(runtime, 0, SNDRV_PCM_HW_PARAM_FORMAT,
-                                               hw_rule_format, subs,
-                                               SNDRV_PCM_HW_PARAM_RATE,
-                                               SNDRV_PCM_HW_PARAM_CHANNELS,
-                                               -1)) < 0)
-                        return err;
-                if ((err = snd_usb_pcm_check_knot(runtime, subs)) < 0)
+        if ((err = snd_pcm_hw_rule_add(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
+                                       hw_rule_channels, subs,
+                                       SNDRV_PCM_HW_PARAM_FORMAT,
+                                       SNDRV_PCM_HW_PARAM_RATE,
+                                       param_period_time_if_needed,
+                                       -1)) < 0)
+                return err;
+        if ((err = snd_pcm_hw_rule_add(runtime, 0, SNDRV_PCM_HW_PARAM_FORMAT,
+                                       hw_rule_format, subs,
+                                       SNDRV_PCM_HW_PARAM_RATE,
+                                       SNDRV_PCM_HW_PARAM_CHANNELS,
+                                       param_period_time_if_needed,
+                                       -1)) < 0)
+                return err;
+        if (param_period_time_if_needed >= 0) {
+                err = snd_pcm_hw_rule_add(runtime, 0,
+                                          SNDRV_PCM_HW_PARAM_PERIOD_TIME,
+                                          hw_rule_period_time, subs,
+                                          SNDRV_PCM_HW_PARAM_FORMAT,
+                                          SNDRV_PCM_HW_PARAM_CHANNELS,
+                                          SNDRV_PCM_HW_PARAM_RATE,
+                                          -1);
+                if (err < 0)
                         return err;
         }
+        if ((err = snd_usb_pcm_check_knot(runtime, subs)) < 0)
+                return err;
         return 0;
 }
 
@@ -2160,7 +2112,8 @@ static void proc_dump_substream_formats(struct snd_usb_substream *subs, struct s
                 fp = list_entry(p, struct audioformat, list);
                 snd_iprintf(buffer, "  Interface %d\n", fp->iface);
                 snd_iprintf(buffer, "    Altset %d\n", fp->altsetting);
-                snd_iprintf(buffer, "    Format: 0x%x\n", fp->format);
+                snd_iprintf(buffer, "    Format: %#x (%d bits)\n",
+                            fp->format, snd_pcm_format_width(fp->format));
                 snd_iprintf(buffer, "    Channels: %d\n", fp->channels);
                 snd_iprintf(buffer, "    Endpoint: %d %s (%s)\n",
                             fp->endpoint & USB_ENDPOINT_NUMBER_MASK,
@@ -2179,8 +2132,11 @@ static void proc_dump_substream_formats(struct snd_usb_substream *subs, struct s
                         }
                         snd_iprintf(buffer, "\n");
                 }
+                if (snd_usb_get_speed(subs->dev) == USB_SPEED_HIGH)
+                        snd_iprintf(buffer, "    Data packet interval: %d us\n",
+                                    125 * (1 << fp->datainterval));
                 // snd_iprintf(buffer, "    Max Packet Size = %d\n", fp->maxpacksize);
-                // snd_iprintf(buffer, "    EP Attribute = 0x%x\n", fp->attributes);
+                // snd_iprintf(buffer, "    EP Attribute = %#x\n", fp->attributes);
         }
 }
 
@@ -2524,7 +2480,6 @@ static int parse_audio_format_rates(struct snd_usb_audio *chip, struct audioform
                  * build the rate table and bitmap flags
                  */
                 int r, idx;
-                unsigned int nonzero_rates = 0;
 
                 fp->rate_table = kmalloc(sizeof(int) * nr_rates, GFP_KERNEL);
                 if (fp->rate_table == NULL) {
@@ -2532,24 +2487,27 @@ static int parse_audio_format_rates(struct snd_usb_audio *chip, struct audioform
                         return -1;
                 }
 
-                fp->nr_rates = nr_rates;
-                fp->rate_min = fp->rate_max = combine_triple(&fmt[8]);
+                fp->nr_rates = 0;
+                fp->rate_min = fp->rate_max = 0;
                 for (r = 0, idx = offset + 1; r < nr_rates; r++, idx += 3) {
                         unsigned int rate = combine_triple(&fmt[idx]);
+                        if (!rate)
+                                continue;
                         /* C-Media CM6501 mislabels its 96 kHz altsetting */
                         if (rate == 48000 && nr_rates == 1 &&
-                            chip->usb_id == USB_ID(0x0d8c, 0x0201) &&
+                            (chip->usb_id == USB_ID(0x0d8c, 0x0201) ||
+                             chip->usb_id == USB_ID(0x0d8c, 0x0102)) &&
                             fp->altsetting == 5 && fp->maxpacksize == 392)
                                 rate = 96000;
-                        fp->rate_table[r] = rate;
-                        nonzero_rates |= rate;
-                        if (rate < fp->rate_min)
+                        fp->rate_table[fp->nr_rates] = rate;
+                        if (!fp->rate_min || rate < fp->rate_min)
                                 fp->rate_min = rate;
-                        else if (rate > fp->rate_max)
+                        if (!fp->rate_max || rate > fp->rate_max)
                                 fp->rate_max = rate;
                         fp->rates |= snd_pcm_rate_to_rate_bit(rate);
+                        fp->nr_rates++;
                 }
-                if (!nonzero_rates) {
+                if (!fp->nr_rates) {
                         hwc_debug("All rates were zero. Skipping format!\n");
                         return -1;
                 }
@@ -2619,7 +2577,7 @@ static int parse_audio_format_ii(struct snd_usb_audio *chip, struct audioformat
                 fp->format = SNDRV_PCM_FORMAT_MPEG;
                 break;
         default:
-                snd_printd(KERN_INFO "%d:%u:%d : unknown format tag 0x%x is detected.  processed as MPEG.\n",
+                snd_printd(KERN_INFO "%d:%u:%d : unknown format tag %#x is detected.  processed as MPEG.\n",
                            chip->dev->devnum, fp->iface, fp->altsetting, format);
                 fp->format = SNDRV_PCM_FORMAT_MPEG;
                 break;
@@ -2670,6 +2628,17 @@ static int parse_audio_format(struct snd_usb_audio *chip, struct audioformat *fp
         return 0;
 }
 
+static unsigned char parse_datainterval(struct snd_usb_audio *chip,
+                                        struct usb_host_interface *alts)
+{
+        if (snd_usb_get_speed(chip->dev) == USB_SPEED_HIGH &&
+            get_endpoint(alts, 0)->bInterval >= 1 &&
+            get_endpoint(alts, 0)->bInterval <= 4)
+                return get_endpoint(alts, 0)->bInterval - 1;
+        else
+                return 0;
+}
+
 static int audiophile_skip_setting_quirk(struct snd_usb_audio *chip,
                                          int iface, int altno);
 static int parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no)
@@ -2775,6 +2744,7 @@ static int parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no)
                 fp->altset_idx = i;
                 fp->endpoint = get_endpoint(alts, 0)->bEndpointAddress;
                 fp->ep_attr = get_endpoint(alts, 0)->bmAttributes;
+                fp->datainterval = parse_datainterval(chip, alts);
                 fp->maxpacksize = le16_to_cpu(get_endpoint(alts, 0)->wMaxPacketSize);
                 if (snd_usb_get_speed(dev) == USB_SPEED_HIGH)
                         fp->maxpacksize = (((fp->maxpacksize >> 11) & 3) + 1)
@@ -2817,7 +2787,7 @@ static int parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no)
                         continue;
                 }
 
-                snd_printdd(KERN_INFO "%d:%u:%d: add audio endpoint 0x%x\n", dev->devnum, iface_no, altno, fp->endpoint);
+                snd_printdd(KERN_INFO "%d:%u:%d: add audio endpoint %#x\n", dev->devnum, iface_no, altno, fp->endpoint);
                 err = add_audio_endpoint(chip, stream, fp);
                 if (err < 0) {
                         kfree(fp->rate_table);
@@ -2966,6 +2936,8 @@ static int create_fixed_stream_quirk(struct snd_usb_audio *chip,
                 return -EINVAL;
         }
         alts = &iface->altsetting[fp->altset_idx];
+        fp->datainterval = parse_datainterval(chip, alts);
+        fp->maxpacksize = le16_to_cpu(get_endpoint(alts, 0)->wMaxPacketSize);
         usb_set_interface(chip->dev, fp->iface, 0);
         init_usb_pitch(chip->dev, fp->iface, alts, fp);
         init_usb_sample_rate(chip->dev, fp->iface, alts, fp, fp->rate_max);
@@ -3059,6 +3031,7 @@ static int create_uaxx_quirk(struct snd_usb_audio *chip,
         fp->iface = altsd->bInterfaceNumber;
         fp->endpoint = get_endpoint(alts, 0)->bEndpointAddress;
         fp->ep_attr = get_endpoint(alts, 0)->bmAttributes;
+        fp->datainterval = 0;
         fp->maxpacksize = le16_to_cpu(get_endpoint(alts, 0)->wMaxPacketSize);
 
         switch (fp->maxpacksize) {
@@ -3126,6 +3099,7 @@ static int create_ua1000_quirk(struct snd_usb_audio *chip,
         fp->iface = altsd->bInterfaceNumber;
         fp->endpoint = get_endpoint(alts, 0)->bEndpointAddress;
         fp->ep_attr = get_endpoint(alts, 0)->bmAttributes;
+        fp->datainterval = parse_datainterval(chip, alts);
         fp->maxpacksize = le16_to_cpu(get_endpoint(alts, 0)->wMaxPacketSize);
         fp->rate_max = fp->rate_min = combine_triple(&alts->extra[8]);
 
@@ -3178,6 +3152,7 @@ static int create_ua101_quirk(struct snd_usb_audio *chip,
         fp->iface = altsd->bInterfaceNumber;
         fp->endpoint = get_endpoint(alts, 0)->bEndpointAddress;
         fp->ep_attr = get_endpoint(alts, 0)->bmAttributes;
+        fp->datainterval = parse_datainterval(chip, alts);
         fp->maxpacksize = le16_to_cpu(get_endpoint(alts, 0)->wMaxPacketSize);
         fp->rate_max = fp->rate_min = combine_triple(&alts->extra[15]);
 
@@ -3763,7 +3738,7 @@ static int usb_audio_resume(struct usb_interface *intf)
 
 static int __init snd_usb_audio_init(void)
 {
-        if (nrpacks < MIN_PACKS_URB || nrpacks > MAX_PACKS) {
+        if (nrpacks < 1 || nrpacks > MAX_PACKS) {
                 printk(KERN_WARNING "invalid nrpacks value.\n");
                 return -EINVAL;
         }
diff --git a/sound/usb/usbmidi.c b/sound/usb/usbmidi.c
index 320641ab5be7..26bad373fe65 100644
--- a/sound/usb/usbmidi.c
+++ b/sound/usb/usbmidi.c
@@ -1625,6 +1625,7 @@ static int snd_usbmidi_create_endpoints_midiman(struct snd_usb_midi* umidi,
         }
 
         ep_info.out_ep = get_endpoint(hostif, 2)->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK;
+        ep_info.out_interval = 0;
         ep_info.out_cables = endpoint->out_cables & 0x5555;
         err = snd_usbmidi_out_endpoint_create(umidi, &ep_info, &umidi->endpoints[0]);
         if (err < 0)
diff --git a/sound/usb/usbmixer.c b/sound/usb/usbmixer.c
index 00397c8a765b..ecb58e7a6245 100644
--- a/sound/usb/usbmixer.c
+++ b/sound/usb/usbmixer.c
@@ -66,6 +66,7 @@ static const struct rc_config {
         { USB_ID(0x041e, 0x3000), 0, 1, 2, 1,  18, 0x0013 }, /* Extigy       */
         { USB_ID(0x041e, 0x3020), 2, 1, 6, 6,  18, 0x0013 }, /* Audigy 2 NX  */
         { USB_ID(0x041e, 0x3040), 2, 2, 6, 6,  2,  0x6e91 }, /* Live! 24-bit */
+        { USB_ID(0x041e, 0x3048), 2, 2, 6, 6,  2,  0x6e91 }, /* Toshiba SB0500 */
 };
 
 struct usb_mixer_interface {
@@ -78,7 +79,6 @@ struct usb_mixer_interface {
 
         /* Sound Blaster remote control stuff */
         const struct rc_config *rc_cfg;
-        unsigned long rc_hwdep_open;
         u32 rc_code;
         wait_queue_head_t rc_waitq;
         struct urb *rc_urb;
@@ -110,6 +110,8 @@ struct mixer_build {
         const struct usbmix_selector_map *selector_map;
 };
 
+#define MAX_CHANNELS    10      /* max logical channels */
+
 struct usb_mixer_elem_info {
         struct usb_mixer_interface *mixer;
         struct usb_mixer_elem_info *next_id_elem; /* list of controls with same id */
@@ -120,6 +122,8 @@ struct usb_mixer_elem_info {
         int channels;
         int val_type;
         int min, max, res;
+        int cached;
+        int cache_val[MAX_CHANNELS];
         u8 initialized;
 };
 
@@ -181,8 +185,6 @@ enum {
         USB_PROC_DCR_RELEASE = 6,
 };
 
-#define MAX_CHANNELS    10      /* max logical channels */
-
 
 /*
  * manual mapping of mixer names
@@ -219,7 +221,10 @@ static int check_ignored_ctl(struct mixer_build *state, int unitid, int control)
         for (p = state->map; p->id; p++) {
                 if (p->id == unitid && ! p->name &&
                     (! control || ! p->control || control == p->control)) {
-                        // printk("ignored control %d:%d\n", unitid, control);
+                        /*
+                        printk(KERN_DEBUG "ignored control %d:%d\n",
+                               unitid, control);
+                        */
                         return 1;
                 }
         }
@@ -376,11 +381,35 @@ static int get_cur_ctl_value(struct usb_mixer_elem_info *cval, int validx, int *
 }
 
 /* channel = 0: master, 1 = first channel */
-static inline int get_cur_mix_value(struct usb_mixer_elem_info *cval, int channel, int *value)
+static inline int get_cur_mix_raw(struct usb_mixer_elem_info *cval,
+                                  int channel, int *value)
 {
         return get_ctl_value(cval, GET_CUR, (cval->control << 8) | channel, value);
 }
 
+static int get_cur_mix_value(struct usb_mixer_elem_info *cval,
+                             int channel, int index, int *value)
+{
+        int err;
+
+        if (cval->cached & (1 << channel)) {
+                *value = cval->cache_val[index];
+                return 0;
+        }
+        err = get_cur_mix_raw(cval, channel, value);
+        if (err < 0) {
+                if (!cval->mixer->ignore_ctl_error)
+                        snd_printd(KERN_ERR "cannot get current value for "
+                                   "control %d ch %d: err = %d\n",
+                                   cval->control, channel, err);
+                return err;
+        }
+        cval->cached |= 1 << channel;
+        cval->cache_val[index] = *value;
+        return 0;
+}
+
+
 /*
  * set a mixer value
  */
@@ -412,9 +441,17 @@ static int set_cur_ctl_value(struct usb_mixer_elem_info *cval, int validx, int v
         return set_ctl_value(cval, SET_CUR, validx, value);
 }
 
-static inline int set_cur_mix_value(struct usb_mixer_elem_info *cval, int channel, int value)
+static int set_cur_mix_value(struct usb_mixer_elem_info *cval, int channel,
+                             int index, int value)
 {
-        return set_ctl_value(cval, SET_CUR, (cval->control << 8) | channel, value);
+        int err;
+        err = set_ctl_value(cval, SET_CUR, (cval->control << 8) | channel,
+                            value);
+        if (err < 0)
+                return err;
+        cval->cached |= 1 << channel;
+        cval->cache_val[index] = value;
+        return 0;
 }
 
 /*
@@ -718,7 +755,7 @@ static int get_min_max(struct usb_mixer_elem_info *cval, int default_min)
                 if (cval->min + cval->res < cval->max) {
                         int last_valid_res = cval->res;
                         int saved, test, check;
-                        get_cur_mix_value(cval, minchn, &saved);
+                        get_cur_mix_raw(cval, minchn, &saved);
                         for (;;) {
                                 test = saved;
                                 if (test < cval->max)
@@ -726,8 +763,8 @@ static int get_min_max(struct usb_mixer_elem_info *cval, int default_min)
                                 else
                                         test -= cval->res;
                                 if (test < cval->min || test > cval->max ||
-                                    set_cur_mix_value(cval, minchn, test) ||
-                                    get_cur_mix_value(cval, minchn, &check)) {
+                                    set_cur_mix_value(cval, minchn, 0, test) ||
+                                    get_cur_mix_raw(cval, minchn, &check)) {
                                         cval->res = last_valid_res;
                                         break;
                                 }
@@ -735,7 +772,7 @@ static int get_min_max(struct usb_mixer_elem_info *cval, int default_min)
                                         break;
                                 cval->res *= 2;
                         }
-                        set_cur_mix_value(cval, minchn, saved);
+                        set_cur_mix_value(cval, minchn, 0, saved);
                 }
 
                 cval->initialized = 1;
@@ -775,35 +812,25 @@ static int mixer_ctl_feature_get(struct snd_kcontrol *kcontrol, struct snd_ctl_e
         struct usb_mixer_elem_info *cval = kcontrol->private_data;
         int c, cnt, val, err;
 
+        ucontrol->value.integer.value[0] = cval->min;
         if (cval->cmask) {
                 cnt = 0;
                 for (c = 0; c < MAX_CHANNELS; c++) {
-                        if (cval->cmask & (1 << c)) {
-                                err = get_cur_mix_value(cval, c + 1, &val);
-                                if (err < 0) {
-                                        if (cval->mixer->ignore_ctl_error) {
-                                                ucontrol->value.integer.value[0] = cval->min;
-                                                return 0;
-                                        }
-                                        snd_printd(KERN_ERR "cannot get current value for control %d ch %d: err = %d\n", cval->control, c + 1, err);
-                                        return err;
-                                }
-                                val = get_relative_value(cval, val);
-                                ucontrol->value.integer.value[cnt] = val;
-                                cnt++;
-                        }
+                        if (!(cval->cmask & (1 << c)))
+                                continue;
+                        err = get_cur_mix_value(cval, c + 1, cnt, &val);
+                        if (err < 0)
+                                return cval->mixer->ignore_ctl_error ? 0 : err;
+                        val = get_relative_value(cval, val);
+                        ucontrol->value.integer.value[cnt] = val;
+                        cnt++;
                 }
+                return 0;
         } else {
                 /* master channel */
-                err = get_cur_mix_value(cval, 0, &val);
-                if (err < 0) {
-                        if (cval->mixer->ignore_ctl_error) {
-                                ucontrol->value.integer.value[0] = cval->min;
-                                return 0;
-                        }
-                        snd_printd(KERN_ERR "cannot get current value for control %d master ch: err = %d\n", cval->control, err);
-                        return err;
-                }
+                err = get_cur_mix_value(cval, 0, 0, &val);
+                if (err < 0)
+                        return cval->mixer->ignore_ctl_error ? 0 : err;
                 val = get_relative_value(cval, val);
                 ucontrol->value.integer.value[0] = val;
         }
@@ -820,34 +847,28 @@ static int mixer_ctl_feature_put(struct snd_kcontrol *kcontrol, struct snd_ctl_e
         if (cval->cmask) {
                 cnt = 0;
                 for (c = 0; c < MAX_CHANNELS; c++) {
-                        if (cval->cmask & (1 << c)) {
-                                err = get_cur_mix_value(cval, c + 1, &oval);
-                                if (err < 0) {
-                                        if (cval->mixer->ignore_ctl_error)
-                                                return 0;
-                                        return err;
-                                }
-                                val = ucontrol->value.integer.value[cnt];
-                                val = get_abs_value(cval, val);
-                                if (oval != val) {
-                                        set_cur_mix_value(cval, c + 1, val);
-                                        changed = 1;
-                                }
-                                get_cur_mix_value(cval, c + 1, &val);
-                                cnt++;
+                        if (!(cval->cmask & (1 << c)))
+                                continue;
+                        err = get_cur_mix_value(cval, c + 1, cnt, &oval);
+                        if (err < 0)
+                                return cval->mixer->ignore_ctl_error ? 0 : err;
+                        val = ucontrol->value.integer.value[cnt];
+                        val = get_abs_value(cval, val);
+                        if (oval != val) {
+                                set_cur_mix_value(cval, c + 1, cnt, val);
+                                changed = 1;
                         }
+                        cnt++;
                 }
         } else {
                 /* master channel */
-                err = get_cur_mix_value(cval, 0, &oval);
-                if (err < 0 && cval->mixer->ignore_ctl_error)
-                        return 0;
+                err = get_cur_mix_value(cval, 0, 0, &oval);
                 if (err < 0)
-                        return err;
+                        return cval->mixer->ignore_ctl_error ? 0 : err;
                 val = ucontrol->value.integer.value[0];
                 val = get_abs_value(cval, val);
                 if (val != oval) {
-                        set_cur_mix_value(cval, 0, val);
+                        set_cur_mix_value(cval, 0, 0, val);
                         changed = 1;
                 }
         }
@@ -1706,7 +1727,8 @@ static void snd_usb_mixer_memory_change(struct usb_mixer_interface *mixer,
                 break;
         /* live24ext: 4 = line-in jack */
         case 3: /* hp-out jack (may actuate Mute) */
-                if (mixer->chip->usb_id == USB_ID(0x041e, 0x3040))
+                if (mixer->chip->usb_id == USB_ID(0x041e, 0x3040) ||
+                    mixer->chip->usb_id == USB_ID(0x041e, 0x3048))
                         snd_usb_mixer_notify_id(mixer, mixer->rc_cfg->mute_mixer_id);
                 break;
         default:
@@ -1797,24 +1819,6 @@ static void snd_usb_soundblaster_remote_complete(struct urb *urb)
         wake_up(&mixer->rc_waitq);
 }
 
-static int snd_usb_sbrc_hwdep_open(struct snd_hwdep *hw, struct file *file)
-{
-        struct usb_mixer_interface *mixer = hw->private_data;
-
-        if (test_and_set_bit(0, &mixer->rc_hwdep_open))
-                return -EBUSY;
-        return 0;
-}
-
-static int snd_usb_sbrc_hwdep_release(struct snd_hwdep *hw, struct file *file)
-{
-        struct usb_mixer_interface *mixer = hw->private_data;
-
-        clear_bit(0, &mixer->rc_hwdep_open);
-        smp_mb__after_clear_bit();
-        return 0;
-}
-
 static long snd_usb_sbrc_hwdep_read(struct snd_hwdep *hw, char __user *buf,
                                      long count, loff_t *offset)
 {
@@ -1867,9 +1871,8 @@ static int snd_usb_soundblaster_remote_init(struct usb_mixer_interface *mixer)
         hwdep->iface = SNDRV_HWDEP_IFACE_SB_RC;
         hwdep->private_data = mixer;
         hwdep->ops.read = snd_usb_sbrc_hwdep_read;
-        hwdep->ops.open = snd_usb_sbrc_hwdep_open;
-        hwdep->ops.release = snd_usb_sbrc_hwdep_release;
         hwdep->ops.poll = snd_usb_sbrc_hwdep_poll;
+        hwdep->exclusive = 1;
 
         mixer->rc_urb = usb_alloc_urb(0, GFP_KERNEL);
         if (!mixer->rc_urb)
@@ -1956,8 +1959,9 @@ static int snd_audigy2nx_controls_create(struct usb_mixer_interface *mixer)
         int i, err;
 
         for (i = 0; i < ARRAY_SIZE(snd_audigy2nx_controls); ++i) {
-                if (i > 1 &&  /* Live24ext has 2 LEDs only */
-                        mixer->chip->usb_id == USB_ID(0x041e, 0x3040))
+                if (i > 1 && /* Live24ext has 2 LEDs only */
+                        (mixer->chip->usb_id == USB_ID(0x041e, 0x3040) ||
+                         mixer->chip->usb_id == USB_ID(0x041e, 0x3048)))
                         break; 
                 err = snd_ctl_add(mixer->chip->card,
                                   snd_ctl_new1(&snd_audigy2nx_controls[i], mixer));
@@ -1994,7 +1998,8 @@ static void snd_audigy2nx_proc_read(struct snd_info_entry *entry,
         snd_iprintf(buffer, "%s jacks\n\n", mixer->chip->card->shortname);
         if (mixer->chip->usb_id == USB_ID(0x041e, 0x3020))
                 jacks = jacks_audigy2nx;
-        else if (mixer->chip->usb_id == USB_ID(0x041e, 0x3040))
+        else if (mixer->chip->usb_id == USB_ID(0x041e, 0x3040) ||
+                 mixer->chip->usb_id == USB_ID(0x041e, 0x3048))
                 jacks = jacks_live24ext;
         else
                 return;
@@ -2044,7 +2049,8 @@ int snd_usb_create_mixer(struct snd_usb_audio *chip, int ctrlif,
                 goto _error;
 
         if (mixer->chip->usb_id == USB_ID(0x041e, 0x3020) ||
-            mixer->chip->usb_id == USB_ID(0x041e, 0x3040)) {
+            mixer->chip->usb_id == USB_ID(0x041e, 0x3040) ||
+            mixer->chip->usb_id == USB_ID(0x041e, 0x3048)) {
                 struct snd_info_entry *entry;
 
                 if ((err = snd_audigy2nx_controls_create(mixer)) < 0)
diff --git a/sound/usb/usbmixer_maps.c b/sound/usb/usbmixer_maps.c
index d755be0ad811..3e5d66cf1f5a 100644
--- a/sound/usb/usbmixer_maps.c
+++ b/sound/usb/usbmixer_maps.c
@@ -261,6 +261,22 @@ static struct usbmix_name_map aureon_51_2_map[] = {
         {} /* terminator */
 };
 
+static struct usbmix_name_map scratch_live_map[] = {
+        /* 1: IT Line 1 (USB streaming) */
+        /* 2: OT Line 1 (Speaker) */
+        /* 3: IT Line 1 (Line connector) */
+        { 4, "Line 1 In" }, /* FU */
+        /* 5: OT Line 1 (USB streaming) */
+        /* 6: IT Line 2 (USB streaming) */
+        /* 7: OT Line 2 (Speaker) */
+        /* 8: IT Line 2 (Line connector) */
+        { 9, "Line 2 In" }, /* FU */
+        /* 10: OT Line 2 (USB streaming) */
+        /* 11: IT Mic (Line connector) */
+        /* 12: OT Mic (USB streaming) */
+        { 0 } /* terminator */
+};
+
 /*
  * Control map entries
  */
@@ -285,6 +301,11 @@ static struct usbmix_ctl_map usbmix_ctl_maps[] = {
                 .map = live24ext_map,
         },
         {
+                .id = USB_ID(0x041e, 0x3048),
+                .map = audigy2nx_map,
+                .selector_map = audigy2nx_selectors,
+        },
+        {
                 /* Hercules DJ Console (Windows Edition) */
                 .id = USB_ID(0x06f8, 0xb000),
                 .ignore_ctl_error = 1,
@@ -311,6 +332,11 @@ static struct usbmix_ctl_map usbmix_ctl_maps[] = {
                 .id = USB_ID(0x0ccd, 0x0028),
                 .map = aureon_51_2_map,
         },
+        {
+                .id = USB_ID(0x13e5, 0x0001),
+                .map = scratch_live_map,
+                .ignore_ctl_error = 1,
+        },
         { 0 } /* terminator */
 };
 
diff --git a/sound/usb/usbquirks.h b/sound/usb/usbquirks.h
index 92115755d98e..647ef5029651 100644
--- a/sound/usb/usbquirks.h
+++ b/sound/usb/usbquirks.h
@@ -39,6 +39,16 @@
         .idProduct = prod, \
         .bInterfaceClass = USB_CLASS_VENDOR_SPEC
 
+/* Creative/Toshiba Multimedia Center SB-0500 */
+{
+        USB_DEVICE(0x041e, 0x3048),
+        .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
+                .vendor_name = "Toshiba",
+                .product_name = "SB-0500",
+                .ifnum = QUIRK_NO_INTERFACE
+        }
+},
+
 /* Creative/E-Mu devices */
 {
         USB_DEVICE(0x041e, 0x3010),
@@ -128,6 +138,14 @@
         .bInterfaceClass = USB_CLASS_AUDIO,
         .bInterfaceSubClass = USB_SUBCLASS_AUDIO_CONTROL
 },
+{
+        USB_DEVICE(0x046d, 0x0990),
+        .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
+                .vendor_name = "Logitech, Inc.",
+                .product_name = "QuickCam Pro 9000",
+                .ifnum = QUIRK_NO_INTERFACE
+        }
+},
 
 /*
  * Yamaha devices
diff --git a/sound/usb/usx2y/us122l.c b/sound/usb/usx2y/us122l.c
index 98276aafefe6..a5aae9d67f31 100644
--- a/sound/usb/usx2y/us122l.c
+++ b/sound/usb/usx2y/us122l.c
@@ -349,14 +349,10 @@ static int usb_stream_hwdep_ioctl(struct snd_hwdep *hw, struct file *file,
         if (cmd != SNDRV_USB_STREAM_IOCTL_SET_PARAMS)
                 return -ENOTTY;
 
-        cfg = kmalloc(sizeof(*cfg), GFP_KERNEL);
-        if (!cfg)
-                return -ENOMEM;
+        cfg = memdup_user((void *)arg, sizeof(*cfg));
+        if (IS_ERR(cfg))
+                return PTR_ERR(cfg);
 
-        if (copy_from_user(cfg, (void *)arg, sizeof(*cfg))) {
-                err = -EFAULT;
-                goto free;
-        }
         if (cfg->version != USB_STREAM_INTERFACE_VERSION) {
                 err = -ENXIO;
                 goto free;
@@ -478,6 +474,14 @@ static bool us122l_create_card(struct snd_card *card)
         return true;
 }
 
+static void snd_us122l_free(struct snd_card *card)
+{
+        struct us122l   *us122l = US122L(card);
+        int             index = us122l->chip.index;
+        if (index >= 0  &&  index < SNDRV_CARDS)
+                snd_us122l_card_used[index] = 0;
+}
+
 static int usx2y_create_card(struct usb_device *device, struct snd_card **cardp)
 {
         int             dev;
@@ -494,7 +498,7 @@ static int usx2y_create_card(struct usb_device *device, struct snd_card **cardp)
         if (err < 0)
                 return err;
         snd_us122l_card_used[US122L(card)->chip.index = dev] = 1;
-
+        card->private_free = snd_us122l_free;
         US122L(card)->chip.dev = device;
         US122L(card)->chip.card = card;
         mutex_init(&US122L(card)->mutex);
@@ -588,7 +592,7 @@ static void snd_us122l_disconnect(struct usb_interface *intf)
         }
 
         usb_put_intf(intf);
-        usb_put_dev(US122L(card)->chip.dev);
+        usb_put_dev(us122l->chip.dev);
 
         while (atomic_read(&us122l->mmap_count))
                 msleep(500);
diff --git a/sound/usb/usx2y/usX2Yhwdep.c b/sound/usb/usx2y/usX2Yhwdep.c
index 1558a5c4094f..f3d8f71265dd 100644
--- a/sound/usb/usx2y/usX2Yhwdep.c
+++ b/sound/usb/usx2y/usX2Yhwdep.c
@@ -30,9 +30,6 @@
 #include "usbusx2y.h"
 #include "usX2Yhwdep.h"
 
-int usX2Y_hwdep_pcm_new(struct snd_card *card);
-
-
 static int snd_us428ctls_vm_fault(struct vm_area_struct *area,
                                   struct vm_fault *vmf)
 {
@@ -106,16 +103,6 @@ static unsigned int snd_us428ctls_poll(struct snd_hwdep *hw, struct file *file,
 }
 
 
-static int snd_usX2Y_hwdep_open(struct snd_hwdep *hw, struct file *file)
-{
-        return 0;
-}
-
-static int snd_usX2Y_hwdep_release(struct snd_hwdep *hw, struct file *file)
-{
-        return 0;
-}
-
 static int snd_usX2Y_hwdep_dsp_status(struct snd_hwdep *hw,
                                       struct snd_hwdep_dsp_status *info)
 {
@@ -216,13 +203,12 @@ static int snd_usX2Y_hwdep_dsp_load(struct snd_hwdep *hw,
 
         if (access_ok(VERIFY_READ, dsp->image, dsp->length)) {
                 struct usb_device* dev = priv->chip.dev;
-                char *buf = kmalloc(dsp->length, GFP_KERNEL);
-                if (!buf)
-                        return -ENOMEM;
-                if (copy_from_user(buf, dsp->image, dsp->length)) {
-                        kfree(buf);
-                        return -EFAULT;
-                }
+                char *buf;
+
+                buf = memdup_user(dsp->image, dsp->length);
+                if (IS_ERR(buf))
+                        return PTR_ERR(buf);
+
                 err = usb_set_interface(dev, 0, 1);
                 if (err)
                         snd_printk(KERN_ERR "usb_set_interface error \n");
@@ -267,8 +253,6 @@ int usX2Y_hwdep_new(struct snd_card *card, struct usb_device* device)
 
         hw->iface = SNDRV_HWDEP_IFACE_USX2Y;
         hw->private_data = usX2Y(card);
-        hw->ops.open = snd_usX2Y_hwdep_open;
-        hw->ops.release = snd_usX2Y_hwdep_release;
         hw->ops.dsp_status = snd_usX2Y_hwdep_dsp_status;
         hw->ops.dsp_load = snd_usX2Y_hwdep_dsp_load;
         hw->ops.mmap = snd_us428ctls_mmap;
diff --git a/sound/usb/usx2y/usb_stream.c b/sound/usb/usx2y/usb_stream.c
index 70b96355ca4c..12ae0340adc0 100644
--- a/sound/usb/usx2y/usb_stream.c
+++ b/sound/usb/usx2y/usb_stream.c
@@ -33,32 +33,26 @@ static unsigned usb_stream_next_packet_size(struct usb_stream_kernel *sk)
 static void playback_prep_freqn(struct usb_stream_kernel *sk, struct urb *urb)
 {
         struct usb_stream *s = sk->s;
-        unsigned l = 0;
-        int pack;
-
-        urb->iso_frame_desc[0].offset = 0;
-        urb->iso_frame_desc[0].length = usb_stream_next_packet_size(sk);
-        sk->out_phase = sk->out_phase_peeked;
-        urb->transfer_buffer_length = urb->iso_frame_desc[0].length;
-
-        for (pack = 1; pack < sk->n_o_ps; pack++) {
-                l = usb_stream_next_packet_size(sk);
-                if (s->idle_outsize + urb->transfer_buffer_length + l >
-                    s->period_size)
+        int pack, lb = 0;
+
+        for (pack = 0; pack < sk->n_o_ps; pack++) {
+                int l = usb_stream_next_packet_size(sk);
+                if (s->idle_outsize + lb + l > s->period_size)
                         goto check;
 
                 sk->out_phase = sk->out_phase_peeked;
-                urb->iso_frame_desc[pack].offset = urb->transfer_buffer_length;
+                urb->iso_frame_desc[pack].offset = lb;
                 urb->iso_frame_desc[pack].length = l;
-                urb->transfer_buffer_length += l;
+                lb += l;
         }
-        snd_printdd(KERN_DEBUG "%i\n", urb->transfer_buffer_length);
+        snd_printdd(KERN_DEBUG "%i\n", lb);
 
 check:
         urb->number_of_packets = pack;
-        s->idle_outsize += urb->transfer_buffer_length - s->period_size;
+        urb->transfer_buffer_length = lb;
+        s->idle_outsize += lb - s->period_size;
         snd_printdd(KERN_DEBUG "idle=%i ul=%i ps=%i\n", s->idle_outsize,
-                    urb->transfer_buffer_length, s->period_size);
+                    lb, s->period_size);
 }
 
 static void init_pipe_urbs(struct usb_stream_kernel *sk, unsigned use_packsize,
@@ -282,21 +276,20 @@ static int usb_stream_prepare_playback(struct usb_stream_kernel *sk,
         struct usb_stream *s = sk->s;
         struct urb *io;
         struct usb_iso_packet_descriptor *id, *od;
-        int p, l = 0;
+        int p = 0, lb = 0, l = 0;
 
         io = sk->idle_outurb;
         od = io->iso_frame_desc;
-        io->transfer_buffer_length = 0;
 
-        for (p = 0; s->sync_packet < 0; ++p, ++s->sync_packet) {
+        for (; s->sync_packet < 0; ++p, ++s->sync_packet) {
                 struct urb *ii = sk->completed_inurb;
                 id = ii->iso_frame_desc +
                         ii->number_of_packets + s->sync_packet;
                 l = id->actual_length;
 
                 od[p].length = l;
-                od[p].offset = io->transfer_buffer_length;
-                io->transfer_buffer_length += l;
+                od[p].offset = lb;
+                lb += l;
         }
 
         for (;
@@ -304,38 +297,38 @@ static int usb_stream_prepare_playback(struct usb_stream_kernel *sk,
              ++p, ++s->sync_packet) {
                 l = inurb->iso_frame_desc[s->sync_packet].actual_length;
 
-                if (s->idle_outsize + io->transfer_buffer_length + l >
-                    s->period_size)
+                if (s->idle_outsize + lb + l > s->period_size)
                         goto check_ok;
 
                 od[p].length = l;
-                od[p].offset = io->transfer_buffer_length;
-                io->transfer_buffer_length += l;
+                od[p].offset = lb;
+                lb += l;
         }
 
 check_ok:
         s->sync_packet -= inurb->number_of_packets;
-        if (s->sync_packet < -2 || s->sync_packet > 0) {
+        if (unlikely(s->sync_packet < -2 || s->sync_packet > 0)) {
                 snd_printk(KERN_WARNING "invalid sync_packet = %i;"
                            " p=%i nop=%i %i %x %x %x > %x\n",
                            s->sync_packet, p, inurb->number_of_packets,
-                           s->idle_outsize + io->transfer_buffer_length + l,
-                           s->idle_outsize, io->transfer_buffer_length,  l,
+                           s->idle_outsize + lb + l,
+                           s->idle_outsize, lb,  l,
                            s->period_size);
                 return -1;
         }
-        if (io->transfer_buffer_length % s->cfg.frame_size) {
+        if (unlikely(lb % s->cfg.frame_size)) {
                 snd_printk(KERN_WARNING"invalid outsize = %i\n",
-                           io->transfer_buffer_length);
+                           lb);
                 return -1;
         }
-        s->idle_outsize += io->transfer_buffer_length - s->period_size;
+        s->idle_outsize += lb - s->period_size;
         io->number_of_packets = p;
-        if (s->idle_outsize > 0) {
-                snd_printk(KERN_WARNING "idle=%i\n", s->idle_outsize);
-                return -1;
-        }
-        return 0;
+        io->transfer_buffer_length = lb;
+        if (s->idle_outsize <= 0)
+                return 0;
+
+        snd_printk(KERN_WARNING "idle=%i\n", s->idle_outsize);
+        return -1;
 }
 
 static void prepare_inurb(int number_of_packets, struct urb *iu)
@@ -557,7 +550,7 @@ static void stream_start(struct usb_stream_kernel *sk,
                 s->idle_insize -= max_diff - max_diff_0;
                 s->idle_insize += urb_size - s->period_size;
                 if (s->idle_insize < 0) {
-                        snd_printk("%i %i %i\n",
+                        snd_printk(KERN_WARNING "%i %i %i\n",
                                    s->idle_insize, urb_size, s->period_size);
                         return;
                 } else if (s->idle_insize == 0) {
diff --git a/sound/usb/usx2y/usbusx2y.c b/sound/usb/usx2y/usbusx2y.c
index af8b84954054..5ce0da23ee96 100644
--- a/sound/usb/usx2y/usbusx2y.c
+++ b/sound/usb/usx2y/usbusx2y.c
@@ -227,9 +227,9 @@ static void i_usX2Y_In04Int(struct urb *urb)
         
         if (usX2Y->US04) {
                 if (0 == usX2Y->US04->submitted)
-                        do
+                        do {
                                 err = usb_submit_urb(usX2Y->US04->urb[usX2Y->US04->submitted++], GFP_ATOMIC);
-                        while (!err && usX2Y->US04->submitted < usX2Y->US04->len);
+                        } while (!err && usX2Y->US04->submitted < usX2Y->US04->len);
         } else
                 if (us428ctls && us428ctls->p4outLast >= 0 && us428ctls->p4outLast < N_us428_p4out_BUFS) {
                         if (us428ctls->p4outLast != us428ctls->p4outSent) {
diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaudio.c
index 9a608fa85155..dd1ab6177840 100644
--- a/sound/usb/usx2y/usbusx2yaudio.c
+++ b/sound/usb/usx2y/usbusx2yaudio.c
@@ -870,7 +870,8 @@ static struct snd_pcm_hardware snd_usX2Y_2c =
 {
         .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
                                  SNDRV_PCM_INFO_BLOCK_TRANSFER |
-                                 SNDRV_PCM_INFO_MMAP_VALID),
+                                 SNDRV_PCM_INFO_MMAP_VALID |
+                                 SNDRV_PCM_INFO_BATCH),
         .formats =                 SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_3LE,
         .rates =                   SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000,
         .rate_min =                44100,
diff --git a/sound/usb/usx2y/usx2yhwdeppcm.h b/sound/usb/usx2y/usx2yhwdeppcm.h
index c3382fdc386b..9c4fb84b2aa0 100644
--- a/sound/usb/usx2y/usx2yhwdeppcm.h
+++ b/sound/usb/usx2y/usx2yhwdeppcm.h
@@ -18,3 +18,5 @@ struct snd_usX2Y_hwdep_pcm_shm {
         volatile unsigned captured_iso_frames;
         int capture_iso_start;
 };
+
+int usX2Y_hwdep_pcm_new(struct snd_card *card);