ALSA: Kill snd_assert() in other places

Kill snd_assert() in other places, either removed or replaced with
if () with snd_BUG_ON().

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>

2 files changed, 10 insertions, 5 deletions

diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c
index b8cfb7c22768..c91f18cdc8b5 100644
--- a/sound/usb/usbaudio.c
+++ b/sound/usb/usbaudio.c
@@ -841,7 +841,8 @@ static int start_urbs(struct snd_usb_substream *subs, struct snd_pcm_runtime *ru
                 return -EBADFD;
 
         for (i = 0; i < subs->nurbs; i++) {
-                snd_assert(subs->dataurb[i].urb, return -EINVAL);
+                if (snd_BUG_ON(!subs->dataurb[i].urb))
+                        return -EINVAL;
                 if (subs->ops.prepare(subs, runtime, subs->dataurb[i].urb) < 0) {
                         snd_printk(KERN_ERR "cannot prepare datapipe for urb %d\n", i);
                         goto __error;
@@ -849,7 +850,8 @@ static int start_urbs(struct snd_usb_substream *subs, struct snd_pcm_runtime *ru
         }
         if (subs->syncpipe) {
                 for (i = 0; i < SYNC_URBS; i++) {
-                        snd_assert(subs->syncurb[i].urb, return -EINVAL);
+                        if (snd_BUG_ON(!subs->syncurb[i].urb))
+                                return -EINVAL;
                         if (subs->ops.prepare_sync(subs, runtime, subs->syncurb[i].urb) < 0) {
                                 snd_printk(KERN_ERR "cannot prepare syncpipe for urb %d\n", i);
                                 goto __error;
@@ -1321,10 +1323,12 @@ static int set_format(struct snd_usb_substream *subs, struct audioformat *fmt)
         int err;
 
         iface = usb_ifnum_to_if(dev, fmt->iface);
-        snd_assert(iface, return -EINVAL);
+        if (WARN_ON(!iface))
+                return -EINVAL;
         alts = &iface->altsetting[fmt->altset_idx];
         altsd = get_iface_desc(alts);
-        snd_assert(altsd->bAlternateSetting == fmt->altsetting, return -EINVAL);
+        if (WARN_ON(altsd->bAlternateSetting != fmt->altsetting))
+                return -EINVAL;
 
         if (fmt == subs->cur_audiofmt)
                 return 0;
diff --git a/sound/usb/usbmixer.c b/sound/usb/usbmixer.c
index 5f98bee06959..6621fad8c5f0 100644
--- a/sound/usb/usbmixer.c
+++ b/sound/usb/usbmixer.c
@@ -1389,7 +1389,8 @@ static int mixer_ctl_selector_info(struct snd_kcontrol *kcontrol, struct snd_ctl
         struct usb_mixer_elem_info *cval = kcontrol->private_data;
         char **itemlist = (char **)kcontrol->private_value;
 
-        snd_assert(itemlist, return -EINVAL);
+        if (snd_BUG_ON(!itemlist))
+                return -EINVAL;
         uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
         uinfo->count = 1;
         uinfo->value.enumerated.items = cval->max;