diff options
author | Daniel Mack <daniel@caiaq.de> | 2010-05-26 12:11:37 -0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2010-05-27 03:48:47 -0400 |
commit | 8d0912427113723c3f3a4dca631638844c4ab649 (patch) | |
tree | d2c8e8e16d7db56af1f16c5329d5d4c97024163f /sound/usb/format.c | |
parent | 74754f974b36c5a1156be46d0da05ab2c0a0960b (diff) |
ALSA: usb-audio: fix return values
-1 is not a good return value as it means -EPERM, "not permitted".
Choose -ENOTSUPP instead, which is what the code really wants to tell
its callers.
Signed-off-by: Daniel Mack <daniel@caiaq.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb/format.c')
-rw-r--r-- | sound/usb/format.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/usb/format.c b/sound/usb/format.c index caaa3ef9e622..fe29d61de19b 100644 --- a/sound/usb/format.c +++ b/sound/usb/format.c | |||
@@ -408,7 +408,7 @@ int snd_usb_parse_audio_format(struct snd_usb_audio *chip, struct audioformat *f | |||
408 | snd_printd(KERN_INFO "%d:%u:%d : format type %d is not supported yet\n", | 408 | snd_printd(KERN_INFO "%d:%u:%d : format type %d is not supported yet\n", |
409 | chip->dev->devnum, fp->iface, fp->altsetting, | 409 | chip->dev->devnum, fp->iface, fp->altsetting, |
410 | fmt->bFormatType); | 410 | fmt->bFormatType); |
411 | return -1; | 411 | return -ENOTSUPP; |
412 | } | 412 | } |
413 | fp->fmt_type = fmt->bFormatType; | 413 | fp->fmt_type = fmt->bFormatType; |
414 | if (err < 0) | 414 | if (err < 0) |
@@ -424,7 +424,7 @@ int snd_usb_parse_audio_format(struct snd_usb_audio *chip, struct audioformat *f | |||
424 | if (fmt->bFormatType == UAC_FORMAT_TYPE_I && | 424 | if (fmt->bFormatType == UAC_FORMAT_TYPE_I && |
425 | fp->rates != SNDRV_PCM_RATE_48000 && | 425 | fp->rates != SNDRV_PCM_RATE_48000 && |
426 | fp->rates != SNDRV_PCM_RATE_96000) | 426 | fp->rates != SNDRV_PCM_RATE_96000) |
427 | return -1; | 427 | return -ENOTSUPP; |
428 | } | 428 | } |
429 | #endif | 429 | #endif |
430 | return 0; | 430 | return 0; |