diff options
author | Fabio Estevam <fabio.estevam@freescale.com> | 2014-04-24 21:27:05 -0400 |
---|---|---|
committer | Mark Brown <broonie@linaro.org> | 2014-04-25 07:17:00 -0400 |
commit | a3086791ebe0c50aff0753a24db565ae0da7be18 (patch) | |
tree | 4832d66f998cd87c35659027c90f055ba4060e33 /sound/soc | |
parent | c9eaa447e77efe77b7fa4c953bd62de8297fd6c5 (diff) |
ASoC: wm8804: Use devm_regulator_bulk_get()
Using devm_regulator_bulk_get() can make the code cleaner and smaller as we
do not need to call regulator_bulk_free() in the error and remove paths.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'sound/soc')
-rw-r--r-- | sound/soc/codecs/wm8804.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/sound/soc/codecs/wm8804.c b/sound/soc/codecs/wm8804.c index ee76f0fb4299..b4c8d6086737 100644 --- a/sound/soc/codecs/wm8804.c +++ b/sound/soc/codecs/wm8804.c | |||
@@ -535,7 +535,6 @@ static int wm8804_remove(struct snd_soc_codec *codec) | |||
535 | for (i = 0; i < ARRAY_SIZE(wm8804->supplies); ++i) | 535 | for (i = 0; i < ARRAY_SIZE(wm8804->supplies); ++i) |
536 | regulator_unregister_notifier(wm8804->supplies[i].consumer, | 536 | regulator_unregister_notifier(wm8804->supplies[i].consumer, |
537 | &wm8804->disable_nb[i]); | 537 | &wm8804->disable_nb[i]); |
538 | regulator_bulk_free(ARRAY_SIZE(wm8804->supplies), wm8804->supplies); | ||
539 | return 0; | 538 | return 0; |
540 | } | 539 | } |
541 | 540 | ||
@@ -549,7 +548,7 @@ static int wm8804_probe(struct snd_soc_codec *codec) | |||
549 | for (i = 0; i < ARRAY_SIZE(wm8804->supplies); i++) | 548 | for (i = 0; i < ARRAY_SIZE(wm8804->supplies); i++) |
550 | wm8804->supplies[i].supply = wm8804_supply_names[i]; | 549 | wm8804->supplies[i].supply = wm8804_supply_names[i]; |
551 | 550 | ||
552 | ret = regulator_bulk_get(codec->dev, ARRAY_SIZE(wm8804->supplies), | 551 | ret = devm_regulator_bulk_get(codec->dev, ARRAY_SIZE(wm8804->supplies), |
553 | wm8804->supplies); | 552 | wm8804->supplies); |
554 | if (ret) { | 553 | if (ret) { |
555 | dev_err(codec->dev, "Failed to request supplies: %d\n", ret); | 554 | dev_err(codec->dev, "Failed to request supplies: %d\n", ret); |
@@ -574,7 +573,7 @@ static int wm8804_probe(struct snd_soc_codec *codec) | |||
574 | wm8804->supplies); | 573 | wm8804->supplies); |
575 | if (ret) { | 574 | if (ret) { |
576 | dev_err(codec->dev, "Failed to enable supplies: %d\n", ret); | 575 | dev_err(codec->dev, "Failed to enable supplies: %d\n", ret); |
577 | goto err_reg_get; | 576 | return ret; |
578 | } | 577 | } |
579 | 578 | ||
580 | id1 = snd_soc_read(codec, WM8804_RST_DEVID1); | 579 | id1 = snd_soc_read(codec, WM8804_RST_DEVID1); |
@@ -619,8 +618,6 @@ static int wm8804_probe(struct snd_soc_codec *codec) | |||
619 | 618 | ||
620 | err_reg_enable: | 619 | err_reg_enable: |
621 | regulator_bulk_disable(ARRAY_SIZE(wm8804->supplies), wm8804->supplies); | 620 | regulator_bulk_disable(ARRAY_SIZE(wm8804->supplies), wm8804->supplies); |
622 | err_reg_get: | ||
623 | regulator_bulk_free(ARRAY_SIZE(wm8804->supplies), wm8804->supplies); | ||
624 | return ret; | 621 | return ret; |
625 | } | 622 | } |
626 | 623 | ||