aboutsummaryrefslogtreecommitdiffstats
path: root/sound/soc
diff options
context:
space:
mode:
authorLars-Peter Clausen <lars@metafoo.de>2014-11-23 07:37:42 -0500
committerMark Brown <broonie@kernel.org>2014-11-24 13:39:55 -0500
commit77d05e7f81da95eb2b6c7ae24ae0fb3272c49282 (patch)
treee343dfeb2874f55aee1b1e298e3192a4e9c4fc22 /sound/soc
parent5d01410fe4d92081f349b013a2e7a95429e4f2c9 (diff)
ASoC: wm8993: Cleanup manual bias level transitions
Since the ASoC core now takes care of setting the bias level to SND_SOC_BIAS_OFF when removing the CODEC there is no need to do it manually anymore either. The manual transition to SND_SOC_BIAS_STANDBY at the end of CODEC probe() can also be removed as the core will automatically do this after the CODEC has been probed. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc')
-rw-r--r--sound/soc/codecs/wm8993.c12
1 files changed, 0 insertions, 12 deletions
diff --git a/sound/soc/codecs/wm8993.c b/sound/soc/codecs/wm8993.c
index 93b14eda355a..53c6fe359496 100644
--- a/sound/soc/codecs/wm8993.c
+++ b/sound/soc/codecs/wm8993.c
@@ -1486,7 +1486,6 @@ static int wm8993_probe(struct snd_soc_codec *codec)
1486{ 1486{
1487 struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec); 1487 struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec);
1488 struct snd_soc_dapm_context *dapm = &codec->dapm; 1488 struct snd_soc_dapm_context *dapm = &codec->dapm;
1489 int ret;
1490 1489
1491 wm8993->hubs_data.hp_startup_mode = 1; 1490 wm8993->hubs_data.hp_startup_mode = 1;
1492 wm8993->hubs_data.dcs_codes_l = -2; 1491 wm8993->hubs_data.dcs_codes_l = -2;
@@ -1518,10 +1517,6 @@ static int wm8993_probe(struct snd_soc_codec *codec)
1518 wm8993->pdata.micbias1_lvl, 1517 wm8993->pdata.micbias1_lvl,
1519 wm8993->pdata.micbias2_lvl); 1518 wm8993->pdata.micbias2_lvl);
1520 1519
1521 ret = wm8993_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
1522 if (ret != 0)
1523 return ret;
1524
1525 snd_soc_add_codec_controls(codec, wm8993_snd_controls, 1520 snd_soc_add_codec_controls(codec, wm8993_snd_controls,
1526 ARRAY_SIZE(wm8993_snd_controls)); 1521 ARRAY_SIZE(wm8993_snd_controls));
1527 if (wm8993->pdata.num_retune_configs != 0) { 1522 if (wm8993->pdata.num_retune_configs != 0) {
@@ -1550,12 +1545,6 @@ static int wm8993_probe(struct snd_soc_codec *codec)
1550 1545
1551} 1546}
1552 1547
1553static int wm8993_remove(struct snd_soc_codec *codec)
1554{
1555 wm8993_set_bias_level(codec, SND_SOC_BIAS_OFF);
1556 return 0;
1557}
1558
1559#ifdef CONFIG_PM 1548#ifdef CONFIG_PM
1560static int wm8993_suspend(struct snd_soc_codec *codec) 1549static int wm8993_suspend(struct snd_soc_codec *codec)
1561{ 1550{
@@ -1629,7 +1618,6 @@ static const struct regmap_config wm8993_regmap = {
1629 1618
1630static struct snd_soc_codec_driver soc_codec_dev_wm8993 = { 1619static struct snd_soc_codec_driver soc_codec_dev_wm8993 = {
1631 .probe = wm8993_probe, 1620 .probe = wm8993_probe,
1632 .remove = wm8993_remove,
1633 .suspend = wm8993_suspend, 1621 .suspend = wm8993_suspend,
1634 .resume = wm8993_resume, 1622 .resume = wm8993_resume,
1635 .set_bias_level = wm8993_set_bias_level, 1623 .set_bias_level = wm8993_set_bias_level,