[ALSA] ASoC: Clarify API for bias configuration

Currently the ASoC core configures the bias levels in the system using
a callback on codecs and machines called 'dapm_event', passing it PCI
style power levels as SNDRV_CTL_POWER_ constants. This is more obscure
than it needs to be and has caused confusion to driver authors,
especially given that DAPM is also performing power management.

Address this by renaming the callback function to 'set_bias_level' and
using constants explicitly representing the off, standby, pre-on and on
states which DAPM transitions through.

Also unexport the API for setting bias level: there are currently no
in-tree users of this API other than the core itself and it is likely
that the core would need to be extended to cater for any users.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Jarkko Nikula <jarkko.nikula@nokia.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>

1 files changed, 13 insertions, 12 deletions

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 0318d8abe3e8..a05b3450aee8 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -283,12 +283,12 @@ static void close_delayed_work(struct work_struct *work)
                 /* are we waiting on this codec DAI stream */
                 if (codec_dai->pop_wait == 1) {
 
-                        /* power down the codec to D1 if no longer active */
+                        /* Reduce power if no longer active */
                         if (codec->active == 0) {
                                 dbg("pop wq D1 %s %s\n", codec->name,
                                         codec_dai->playback.stream_name);
-                                snd_soc_dapm_device_event(socdev,
-                                        SNDRV_CTL_POWER_D1);
+                                snd_soc_dapm_set_bias_level(socdev,
+                                        SND_SOC_BIAS_PREPARE);
                         }
 
                         codec_dai->pop_wait = 0;
@@ -296,12 +296,12 @@ static void close_delayed_work(struct work_struct *work)
                                 codec_dai->playback.stream_name,
                                 SND_SOC_DAPM_STREAM_STOP);
 
-                        /* power down the codec power domain if no longer active */
+                        /* Fall into standby if no longer active */
                         if (codec->active == 0) {
                                 dbg("pop wq D3 %s %s\n", codec->name,
                                         codec_dai->playback.stream_name);
-                                snd_soc_dapm_device_event(socdev,
-                                        SNDRV_CTL_POWER_D3hot);
+                                snd_soc_dapm_set_bias_level(socdev,
+                                        SND_SOC_BIAS_STANDBY);
                         }
                 }
         }
@@ -361,8 +361,8 @@ static int soc_codec_close(struct snd_pcm_substream *substream)
                         SND_SOC_DAPM_STREAM_STOP);
 
                 if (codec->active == 0 && codec_dai->pop_wait == 0)
-                        snd_soc_dapm_device_event(socdev,
-                                                SNDRV_CTL_POWER_D3hot);
+                        snd_soc_dapm_set_bias_level(socdev,
+                                                SND_SOC_BIAS_STANDBY);
         }
 
         mutex_unlock(&pcm_mutex);
@@ -435,9 +435,10 @@ static int soc_pcm_prepare(struct snd_pcm_substream *substream)
                 }
         } else {
                 /* no delayed work - do we need to power up codec */
-                if (codec->dapm_state != SNDRV_CTL_POWER_D0) {
+                if (codec->bias_level != SND_SOC_BIAS_ON) {
 
-                        snd_soc_dapm_device_event(socdev,  SNDRV_CTL_POWER_D1);
+                        snd_soc_dapm_set_bias_level(socdev,
+                                                    SND_SOC_BIAS_PREPARE);
 
                         if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
                                 snd_soc_dapm_stream_event(codec,
@@ -448,7 +449,7 @@ static int soc_pcm_prepare(struct snd_pcm_substream *substream)
                                         codec_dai->capture.stream_name,
                                         SND_SOC_DAPM_STREAM_START);
 
-                        snd_soc_dapm_device_event(socdev, SNDRV_CTL_POWER_D0);
+                        snd_soc_dapm_set_bias_level(socdev, SND_SOC_BIAS_ON);
                         if (codec_dai->dai_ops.digital_mute)
                                 codec_dai->dai_ops.digital_mute(codec_dai, 0);
 
@@ -658,7 +659,7 @@ static int soc_suspend(struct platform_device *pdev, pm_message_t state)
 
         /* close any waiting streams and save state */
         run_delayed_work(&socdev->delayed_work);
-        codec->suspend_dapm_state = codec->dapm_state;
+        codec->suspend_bias_level = codec->bias_level;
 
         for(i = 0; i < codec->num_dai; i++) {
                 char *stream = codec->dai[i].playback.stream_name;