diff options
author | Guennadi Liakhovetski <g.liakhovetski@gmx.de> | 2010-02-03 11:37:23 -0500 |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2010-02-03 13:03:37 -0500 |
commit | 0f69d9782c6e6a7b0e60113a850845bc642c3f4e (patch) | |
tree | 6b3120ba024a949bbd0feca9fa55c0a30021b32f /sound/soc/sh | |
parent | 026384d614b827f368834860c9b623ce08439b7e (diff) |
ASoC: fix compilation breakage in sound/soc/sh/fsi.c
ctrl_outl() has become void at some point, which breaks compilation of fsi.c.
Make writing functions void, as their output is anyway not evaluated, and use
__raw_writel and __raw_readl instead of deprecated ctrl_outl and ctrl_inl
respectively.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'sound/soc/sh')
-rw-r--r-- | sound/soc/sh/fsi.c | 40 |
1 files changed, 17 insertions, 23 deletions
diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c index ebf358808db1..3c36d24a6c20 100644 --- a/sound/soc/sh/fsi.c +++ b/sound/soc/sh/fsi.c | |||
@@ -120,35 +120,35 @@ struct fsi_master { | |||
120 | 120 | ||
121 | 121 | ||
122 | ************************************************************************/ | 122 | ************************************************************************/ |
123 | static int __fsi_reg_write(u32 reg, u32 data) | 123 | static void __fsi_reg_write(u32 reg, u32 data) |
124 | { | 124 | { |
125 | /* valid data area is 24bit */ | 125 | /* valid data area is 24bit */ |
126 | data &= 0x00ffffff; | 126 | data &= 0x00ffffff; |
127 | 127 | ||
128 | return ctrl_outl(data, reg); | 128 | __raw_writel(data, reg); |
129 | } | 129 | } |
130 | 130 | ||
131 | static u32 __fsi_reg_read(u32 reg) | 131 | static u32 __fsi_reg_read(u32 reg) |
132 | { | 132 | { |
133 | return ctrl_inl(reg); | 133 | return __raw_readl(reg); |
134 | } | 134 | } |
135 | 135 | ||
136 | static int __fsi_reg_mask_set(u32 reg, u32 mask, u32 data) | 136 | static void __fsi_reg_mask_set(u32 reg, u32 mask, u32 data) |
137 | { | 137 | { |
138 | u32 val = __fsi_reg_read(reg); | 138 | u32 val = __fsi_reg_read(reg); |
139 | 139 | ||
140 | val &= ~mask; | 140 | val &= ~mask; |
141 | val |= data & mask; | 141 | val |= data & mask; |
142 | 142 | ||
143 | return __fsi_reg_write(reg, val); | 143 | __fsi_reg_write(reg, val); |
144 | } | 144 | } |
145 | 145 | ||
146 | static int fsi_reg_write(struct fsi_priv *fsi, u32 reg, u32 data) | 146 | static void fsi_reg_write(struct fsi_priv *fsi, u32 reg, u32 data) |
147 | { | 147 | { |
148 | if (reg > REG_END) | 148 | if (reg > REG_END) |
149 | return -1; | 149 | return; |
150 | 150 | ||
151 | return __fsi_reg_write((u32)(fsi->base + reg), data); | 151 | __fsi_reg_write((u32)(fsi->base + reg), data); |
152 | } | 152 | } |
153 | 153 | ||
154 | static u32 fsi_reg_read(struct fsi_priv *fsi, u32 reg) | 154 | static u32 fsi_reg_read(struct fsi_priv *fsi, u32 reg) |
@@ -159,28 +159,25 @@ static u32 fsi_reg_read(struct fsi_priv *fsi, u32 reg) | |||
159 | return __fsi_reg_read((u32)(fsi->base + reg)); | 159 | return __fsi_reg_read((u32)(fsi->base + reg)); |
160 | } | 160 | } |
161 | 161 | ||
162 | static int fsi_reg_mask_set(struct fsi_priv *fsi, u32 reg, u32 mask, u32 data) | 162 | static void fsi_reg_mask_set(struct fsi_priv *fsi, u32 reg, u32 mask, u32 data) |
163 | { | 163 | { |
164 | if (reg > REG_END) | 164 | if (reg > REG_END) |
165 | return -1; | 165 | return; |
166 | 166 | ||
167 | return __fsi_reg_mask_set((u32)(fsi->base + reg), mask, data); | 167 | __fsi_reg_mask_set((u32)(fsi->base + reg), mask, data); |
168 | } | 168 | } |
169 | 169 | ||
170 | static int fsi_master_write(struct fsi_master *master, u32 reg, u32 data) | 170 | static void fsi_master_write(struct fsi_master *master, u32 reg, u32 data) |
171 | { | 171 | { |
172 | int ret; | ||
173 | unsigned long flags; | 172 | unsigned long flags; |
174 | 173 | ||
175 | if ((reg < MREG_START) || | 174 | if ((reg < MREG_START) || |
176 | (reg > MREG_END)) | 175 | (reg > MREG_END)) |
177 | return -1; | 176 | return; |
178 | 177 | ||
179 | spin_lock_irqsave(&master->lock, flags); | 178 | spin_lock_irqsave(&master->lock, flags); |
180 | ret = __fsi_reg_write((u32)(master->base + reg), data); | 179 | __fsi_reg_write((u32)(master->base + reg), data); |
181 | spin_unlock_irqrestore(&master->lock, flags); | 180 | spin_unlock_irqrestore(&master->lock, flags); |
182 | |||
183 | return ret; | ||
184 | } | 181 | } |
185 | 182 | ||
186 | static u32 fsi_master_read(struct fsi_master *master, u32 reg) | 183 | static u32 fsi_master_read(struct fsi_master *master, u32 reg) |
@@ -199,21 +196,18 @@ static u32 fsi_master_read(struct fsi_master *master, u32 reg) | |||
199 | return ret; | 196 | return ret; |
200 | } | 197 | } |
201 | 198 | ||
202 | static int fsi_master_mask_set(struct fsi_master *master, | 199 | static void fsi_master_mask_set(struct fsi_master *master, |
203 | u32 reg, u32 mask, u32 data) | 200 | u32 reg, u32 mask, u32 data) |
204 | { | 201 | { |
205 | int ret; | ||
206 | unsigned long flags; | 202 | unsigned long flags; |
207 | 203 | ||
208 | if ((reg < MREG_START) || | 204 | if ((reg < MREG_START) || |
209 | (reg > MREG_END)) | 205 | (reg > MREG_END)) |
210 | return -1; | 206 | return; |
211 | 207 | ||
212 | spin_lock_irqsave(&master->lock, flags); | 208 | spin_lock_irqsave(&master->lock, flags); |
213 | ret = __fsi_reg_mask_set((u32)(master->base + reg), mask, data); | 209 | __fsi_reg_mask_set((u32)(master->base + reg), mask, data); |
214 | spin_unlock_irqrestore(&master->lock, flags); | 210 | spin_unlock_irqrestore(&master->lock, flags); |
215 | |||
216 | return ret; | ||
217 | } | 211 | } |
218 | 212 | ||
219 | /************************************************************************ | 213 | /************************************************************************ |