diff options
author | javier Martin <javier.martin@vista-silicon.com> | 2009-08-05 17:29:39 -0400 |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2009-08-05 17:31:55 -0400 |
commit | fbb474dedab871c7382858c374acd287dad4ab38 (patch) | |
tree | ed8f33421582b930889f613862285e277ffbdb01 /sound/soc/imx/mx1_mx2-pcm.c | |
parent | 2ccafed43a75b836a15bd36ef0acf466ba36604d (diff) |
ASoC: Fix review issues in i.MX2x PCM driver
Signed-off-by: javier Martin <javier.martin@vista-silicon.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'sound/soc/imx/mx1_mx2-pcm.c')
-rw-r--r-- | sound/soc/imx/mx1_mx2-pcm.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/sound/soc/imx/mx1_mx2-pcm.c b/sound/soc/imx/mx1_mx2-pcm.c index 94807f844131..16efd8a7a16d 100644 --- a/sound/soc/imx/mx1_mx2-pcm.c +++ b/sound/soc/imx/mx1_mx2-pcm.c | |||
@@ -126,7 +126,7 @@ static int dma_new_period(struct snd_pcm_substream *substream) | |||
126 | dma_size, dev_addr, | 126 | dma_size, dev_addr, |
127 | prtd->dma_params->transfer_type); | 127 | prtd->dma_params->transfer_type); |
128 | if (ret < 0) { | 128 | if (ret < 0) { |
129 | printk(KERN_ERR "Error configuring DMA\n"); | 129 | printk(KERN_ERR "Error %d configuring DMA\n", ret); |
130 | return ret; | 130 | return ret; |
131 | } | 131 | } |
132 | imx_dma_enable(prtd->dma_ch); | 132 | imx_dma_enable(prtd->dma_ch); |
@@ -216,7 +216,8 @@ static int mx1_mx2_pcm_hw_params(struct snd_pcm_substream *substream, | |||
216 | ret = snd_pcm_lib_malloc_pages(substream, | 216 | ret = snd_pcm_lib_malloc_pages(substream, |
217 | params_buffer_bytes(hw_params)); | 217 | params_buffer_bytes(hw_params)); |
218 | if (ret < 0) { | 218 | if (ret < 0) { |
219 | printk(KERN_ERR "%s: failed to malloc pcm pages\n", __func__); | 219 | printk(KERN_ERR "%s: Error %d failed to malloc pcm pages \n", |
220 | __func__, ret); | ||
220 | return ret; | 221 | return ret; |
221 | } | 222 | } |
222 | 223 | ||
@@ -324,7 +325,7 @@ static int mx1_mx2_pcm_open(struct snd_pcm_substream *substream) | |||
324 | prtd->dma_ch = imx_dma_request_by_prio(prtd->dma_params->name, | 325 | prtd->dma_ch = imx_dma_request_by_prio(prtd->dma_params->name, |
325 | DMA_PRIO_HIGH); | 326 | DMA_PRIO_HIGH); |
326 | if (prtd->dma_ch < 0) { | 327 | if (prtd->dma_ch < 0) { |
327 | printk(KERN_ERR "Error requesting dma channel\n"); | 328 | printk(KERN_ERR "Error %d requesting dma channel\n", ret); |
328 | return ret; | 329 | return ret; |
329 | } | 330 | } |
330 | imx_dma_config_burstlen(prtd->dma_ch, | 331 | imx_dma_config_burstlen(prtd->dma_ch, |
@@ -336,8 +337,8 @@ static int mx1_mx2_pcm_open(struct snd_pcm_substream *substream) | |||
336 | prtd->dma_params->event_id, 0); | 337 | prtd->dma_params->event_id, 0); |
337 | 338 | ||
338 | if (ret) { | 339 | if (ret) { |
339 | pr_debug(KERN_ERR "Error configuring dma channel %d\n", | 340 | pr_debug(KERN_ERR "Error %d configuring dma channel %d\n", |
340 | prtd->dma_ch); | 341 | ret, prtd->dma_ch); |
341 | return ret; | 342 | return ret; |
342 | } | 343 | } |
343 | 344 | ||
@@ -346,7 +347,7 @@ static int mx1_mx2_pcm_open(struct snd_pcm_substream *substream) | |||
346 | audio_dma_irq, NULL, | 347 | audio_dma_irq, NULL, |
347 | (void *)substream); | 348 | (void *)substream); |
348 | if (ret < 0) { | 349 | if (ret < 0) { |
349 | printk(KERN_ERR "Error setting dma callback function\n"); | 350 | printk(KERN_ERR "Error %d setting dma callback function\n", ret); |
350 | return ret; | 351 | return ret; |
351 | } | 352 | } |
352 | return 0; | 353 | return 0; |