Merge branch 'fix/wm8962' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into asoc-wm8962

Conflicts:
	sound/soc/codecs/wm8962.c

1 files changed, 14 insertions, 12 deletions

diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
index 7a7a0567e547..dfaf592d2fc9 100644
--- a/sound/soc/codecs/wm8962.c
+++ b/sound/soc/codecs/wm8962.c
@@ -1601,7 +1601,6 @@ static int wm8962_put_hp_sw(struct snd_kcontrol *kcontrol,
                             struct snd_ctl_elem_value *ucontrol)
 {
         struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-        u16 *reg_cache = codec->reg_cache;
         int ret;
 
         /* Apply the update (if any) */
@@ -1610,16 +1609,19 @@ static int wm8962_put_hp_sw(struct snd_kcontrol *kcontrol,
                 return 0;
 
         /* If the left PGA is enabled hit that VU bit... */
-        if (snd_soc_read(codec, WM8962_PWR_MGMT_2) & WM8962_HPOUTL_PGA_ENA)
-                return snd_soc_write(codec, WM8962_HPOUTL_VOLUME,
-                                     reg_cache[WM8962_HPOUTL_VOLUME]);
+        ret = snd_soc_read(codec, WM8962_PWR_MGMT_2);
+        if (ret & WM8962_HPOUTL_PGA_ENA) {
+                snd_soc_write(codec, WM8962_HPOUTL_VOLUME,
+                              snd_soc_read(codec, WM8962_HPOUTL_VOLUME));
+                return 1;
+        }
 
         /* ...otherwise the right.  The VU is stereo. */
-        if (snd_soc_read(codec, WM8962_PWR_MGMT_2) & WM8962_HPOUTR_PGA_ENA)
-                return snd_soc_write(codec, WM8962_HPOUTR_VOLUME,
-                                     reg_cache[WM8962_HPOUTR_VOLUME]);
+        if (ret & WM8962_HPOUTR_PGA_ENA)
+                snd_soc_write(codec, WM8962_HPOUTR_VOLUME,
+                              snd_soc_read(codec, WM8962_HPOUTR_VOLUME));
 
-        return 0;
+        return 1;
 }
 
 /* The VU bits for the speakers are in a different register to the mute
@@ -3375,8 +3377,7 @@ static int wm8962_probe(struct snd_soc_codec *codec)
 {
         int ret;
         struct wm8962_priv *wm8962 = snd_soc_codec_get_drvdata(codec);
-        struct wm8962_pdata *pdata = &wm8962->pdata;
-        u16 *reg_cache = codec->reg_cache;
+        struct wm8962_pdata *pdata = dev_get_platdata(codec->dev);
         int i, trigger, irq_pol;
         bool dmicclk, dmicdat;
 
@@ -3431,10 +3432,11 @@ static int wm8962_probe(struct snd_soc_codec *codec)
                                         pdata->gpio_init[i] & 0xffff);
                 }
 
+
         /* Put the speakers into mono mode? */
         if (pdata->spk_mono)
-                reg_cache[WM8962_CLASS_D_CONTROL_2]
-                        |= WM8962_SPK_MONO;
+                snd_soc_update_bits(codec, WM8962_CLASS_D_CONTROL_2,
+                                WM8962_SPK_MONO_MASK, WM8962_SPK_MONO);
 
         /* Micbias setup, detection enable and detection
          * threasholds. */