diff options
author | Fabio Estevam <fabio.estevam@freescale.com> | 2014-04-24 21:27:06 -0400 |
---|---|---|
committer | Mark Brown <broonie@linaro.org> | 2014-04-25 07:24:26 -0400 |
commit | e90c7b456b58a8cd94c8b4be2740133d163c1cba (patch) | |
tree | 817d982b1688ba912e2da575cfd5503427fe8320 /sound/soc/codecs/wm8955.c | |
parent | c9eaa447e77efe77b7fa4c953bd62de8297fd6c5 (diff) |
ASoC: wm8955: Use devm_regulator_bulk_get()
Using devm_regulator_bulk_get() can make the code cleaner and smaller as we
do not need to call regulator_bulk_free() in the error and remove paths.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'sound/soc/codecs/wm8955.c')
-rw-r--r-- | sound/soc/codecs/wm8955.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/sound/soc/codecs/wm8955.c b/sound/soc/codecs/wm8955.c index fecd4e4f4c57..b47ae8312e21 100644 --- a/sound/soc/codecs/wm8955.c +++ b/sound/soc/codecs/wm8955.c | |||
@@ -898,7 +898,7 @@ static int wm8955_probe(struct snd_soc_codec *codec) | |||
898 | for (i = 0; i < ARRAY_SIZE(wm8955->supplies); i++) | 898 | for (i = 0; i < ARRAY_SIZE(wm8955->supplies); i++) |
899 | wm8955->supplies[i].supply = wm8955_supply_names[i]; | 899 | wm8955->supplies[i].supply = wm8955_supply_names[i]; |
900 | 900 | ||
901 | ret = regulator_bulk_get(codec->dev, ARRAY_SIZE(wm8955->supplies), | 901 | ret = devm_regulator_bulk_get(codec->dev, ARRAY_SIZE(wm8955->supplies), |
902 | wm8955->supplies); | 902 | wm8955->supplies); |
903 | if (ret != 0) { | 903 | if (ret != 0) { |
904 | dev_err(codec->dev, "Failed to request supplies: %d\n", ret); | 904 | dev_err(codec->dev, "Failed to request supplies: %d\n", ret); |
@@ -909,7 +909,7 @@ static int wm8955_probe(struct snd_soc_codec *codec) | |||
909 | wm8955->supplies); | 909 | wm8955->supplies); |
910 | if (ret != 0) { | 910 | if (ret != 0) { |
911 | dev_err(codec->dev, "Failed to enable supplies: %d\n", ret); | 911 | dev_err(codec->dev, "Failed to enable supplies: %d\n", ret); |
912 | goto err_get; | 912 | return ret; |
913 | } | 913 | } |
914 | 914 | ||
915 | ret = wm8955_reset(codec); | 915 | ret = wm8955_reset(codec); |
@@ -961,17 +961,12 @@ static int wm8955_probe(struct snd_soc_codec *codec) | |||
961 | 961 | ||
962 | err_enable: | 962 | err_enable: |
963 | regulator_bulk_disable(ARRAY_SIZE(wm8955->supplies), wm8955->supplies); | 963 | regulator_bulk_disable(ARRAY_SIZE(wm8955->supplies), wm8955->supplies); |
964 | err_get: | ||
965 | regulator_bulk_free(ARRAY_SIZE(wm8955->supplies), wm8955->supplies); | ||
966 | return ret; | 964 | return ret; |
967 | } | 965 | } |
968 | 966 | ||
969 | static int wm8955_remove(struct snd_soc_codec *codec) | 967 | static int wm8955_remove(struct snd_soc_codec *codec) |
970 | { | 968 | { |
971 | struct wm8955_priv *wm8955 = snd_soc_codec_get_drvdata(codec); | ||
972 | |||
973 | wm8955_set_bias_level(codec, SND_SOC_BIAS_OFF); | 969 | wm8955_set_bias_level(codec, SND_SOC_BIAS_OFF); |
974 | regulator_bulk_free(ARRAY_SIZE(wm8955->supplies), wm8955->supplies); | ||
975 | return 0; | 970 | return 0; |
976 | } | 971 | } |
977 | 972 | ||