Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6: (252 commits)
  ASoC: Check progress when reporting periods from i.MX FIQ handler
  ASoC: Remove a unused variables from i.MX FIQ runtime data
  ALSA: hda - Add/fix ALC269 FSC and Quanta models
  ALSA: hda - Add ALC670 codec support
  OMAP4: PMIC: Add support for twl6030 codec
  ALSA: hda - remove unnecessary msleep on power state transitions
  usb/gadget/{f_audio,gmidi}.c: follow recent changes in audio.h
  ASoC: fsi: Modify over/under run error settlement
  ASoC: OMAP4: Add McPDM platform driver
  ASoC: OMAP4: Add support for McPDM
  ASoC: OMAP: data_type and sync_mode configurable in audio dma
  ALSA: hda - Add missing description in HD-Audio-Models.txt
  ALSA: add support for Macbook Air 2,1 internal speaker
  ALSA: usbaudio: consolidate header files
  ALSA: usbmixer: bail out early when parsing audio class v2 descriptors
  ALSA: usbaudio: implement basic set of class v2.0 parser
  ALSA: usbaudio: introduce new types for audio class v2
  ALSA: usbaudio: parse USB descriptors with structs
  ALSA: hda - enable snoop for Intel Cougar Point
  ALSA: hda - Remove identical definitions for macmini3 model
  ...

1 files changed, 254 insertions, 57 deletions

diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c
index 9c8903dbe647..f9f367d29a90 100644
--- a/sound/soc/codecs/tlv320dac33.c
+++ b/sound/soc/codecs/tlv320dac33.c
@@ -30,6 +30,7 @@
 #include <linux/platform_device.h>
 #include <linux/interrupt.h>
 #include <linux/gpio.h>
+#include <linux/regulator/consumer.h>
 #include <sound/core.h>
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
@@ -58,11 +59,26 @@ enum dac33_state {
         DAC33_FLUSH,
 };
 
+enum dac33_fifo_modes {
+        DAC33_FIFO_BYPASS = 0,
+        DAC33_FIFO_MODE1,
+        DAC33_FIFO_MODE7,
+        DAC33_FIFO_LAST_MODE,
+};
+
+#define DAC33_NUM_SUPPLIES 3
+static const char *dac33_supply_names[DAC33_NUM_SUPPLIES] = {
+        "AVDD",
+        "DVDD",
+        "IOVDD",
+};
+
 struct tlv320dac33_priv {
         struct mutex mutex;
         struct workqueue_struct *dac33_wq;
         struct work_struct work;
         struct snd_soc_codec codec;
+        struct regulator_bulk_data supplies[DAC33_NUM_SUPPLIES];
         int power_gpio;
         int chip_power;
         int irq;
@@ -73,8 +89,9 @@ struct tlv320dac33_priv {
                                          * this */
         unsigned int nsample_max;       /* nsample should not be higher than
                                          * this */
-        unsigned int nsample_switch;    /* Use FIFO or bypass FIFO switch */
+        enum dac33_fifo_modes fifo_mode;/* FIFO mode selection */
         unsigned int nsample;           /* burst read amount from host */
+        u8 burst_bclkdiv;               /* BCLK divider value in burst mode */
 
         enum dac33_state state;
 };
@@ -297,28 +314,49 @@ static inline void dac33_soft_power(struct snd_soc_codec *codec, int power)
         dac33_write(codec, DAC33_PWR_CTRL, reg);
 }
 
-static void dac33_hard_power(struct snd_soc_codec *codec, int power)
+static int dac33_hard_power(struct snd_soc_codec *codec, int power)
 {
         struct tlv320dac33_priv *dac33 = codec->private_data;
+        int ret;
 
         mutex_lock(&dac33->mutex);
         if (power) {
-                if (dac33->power_gpio >= 0) {
-                        gpio_set_value(dac33->power_gpio, 1);
-                        dac33->chip_power = 1;
-                        /* Restore registers */
-                        dac33_restore_regs(codec);
+                ret = regulator_bulk_enable(ARRAY_SIZE(dac33->supplies),
+                                          dac33->supplies);
+                if (ret != 0) {
+                        dev_err(codec->dev,
+                                "Failed to enable supplies: %d\n", ret);
+                                goto exit;
                 }
+
+                if (dac33->power_gpio >= 0)
+                        gpio_set_value(dac33->power_gpio, 1);
+
+                dac33->chip_power = 1;
+
+                /* Restore registers */
+                dac33_restore_regs(codec);
+
                 dac33_soft_power(codec, 1);
         } else {
                 dac33_soft_power(codec, 0);
-                if (dac33->power_gpio >= 0) {
+                if (dac33->power_gpio >= 0)
                         gpio_set_value(dac33->power_gpio, 0);
-                        dac33->chip_power = 0;
+
+                ret = regulator_bulk_disable(ARRAY_SIZE(dac33->supplies),
+                                             dac33->supplies);
+                if (ret != 0) {
+                        dev_err(codec->dev,
+                                "Failed to disable supplies: %d\n", ret);
+                        goto exit;
                 }
+
+                dac33->chip_power = 0;
         }
-        mutex_unlock(&dac33->mutex);
 
+exit:
+        mutex_unlock(&dac33->mutex);
+        return ret;
 }
 
 static int dac33_get_nsample(struct snd_kcontrol *kcontrol,
@@ -351,39 +389,48 @@ static int dac33_set_nsample(struct snd_kcontrol *kcontrol,
         return ret;
 }
 
-static int dac33_get_nsample_switch(struct snd_kcontrol *kcontrol,
+static int dac33_get_fifo_mode(struct snd_kcontrol *kcontrol,
                          struct snd_ctl_elem_value *ucontrol)
 {
         struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
         struct tlv320dac33_priv *dac33 = codec->private_data;
 
-        ucontrol->value.integer.value[0] = dac33->nsample_switch;
+        ucontrol->value.integer.value[0] = dac33->fifo_mode;
 
         return 0;
 }
 
-static int dac33_set_nsample_switch(struct snd_kcontrol *kcontrol,
+static int dac33_set_fifo_mode(struct snd_kcontrol *kcontrol,
                          struct snd_ctl_elem_value *ucontrol)
 {
         struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
         struct tlv320dac33_priv *dac33 = codec->private_data;
         int ret = 0;
 
-        if (dac33->nsample_switch == ucontrol->value.integer.value[0])
+        if (dac33->fifo_mode == ucontrol->value.integer.value[0])
                 return 0;
         /* Do not allow changes while stream is running*/
         if (codec->active)
                 return -EPERM;
 
         if (ucontrol->value.integer.value[0] < 0 ||
-            ucontrol->value.integer.value[0] > 1)
+            ucontrol->value.integer.value[0] >= DAC33_FIFO_LAST_MODE)
                 ret = -EINVAL;
         else
-                dac33->nsample_switch = ucontrol->value.integer.value[0];
+                dac33->fifo_mode = ucontrol->value.integer.value[0];
 
         return ret;
 }
 
+/* Codec operation modes */
+static const char *dac33_fifo_mode_texts[] = {
+        "Bypass", "Mode 1", "Mode 7"
+};
+
+static const struct soc_enum dac33_fifo_mode_enum =
+        SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(dac33_fifo_mode_texts),
+                            dac33_fifo_mode_texts);
+
 /*
  * DACL/R digital volume control:
  * from 0 dB to -63.5 in 0.5 dB steps
@@ -406,8 +453,8 @@ static const struct snd_kcontrol_new dac33_snd_controls[] = {
 static const struct snd_kcontrol_new dac33_nsample_snd_controls[] = {
         SOC_SINGLE_EXT("nSample", 0, 0, 5900, 0,
                  dac33_get_nsample, dac33_set_nsample),
-        SOC_SINGLE_EXT("nSample Switch", 0, 0, 1, 0,
-                 dac33_get_nsample_switch, dac33_set_nsample_switch),
+        SOC_ENUM_EXT("FIFO Mode", dac33_fifo_mode_enum,
+                 dac33_get_fifo_mode, dac33_set_fifo_mode),
 };
 
 /* Analog bypass */
@@ -469,6 +516,8 @@ static int dac33_add_widgets(struct snd_soc_codec *codec)
 static int dac33_set_bias_level(struct snd_soc_codec *codec,
                                 enum snd_soc_bias_level level)
 {
+        int ret;
+
         switch (level) {
         case SND_SOC_BIAS_ON:
                 dac33_soft_power(codec, 1);
@@ -476,12 +525,19 @@ static int dac33_set_bias_level(struct snd_soc_codec *codec,
         case SND_SOC_BIAS_PREPARE:
                 break;
         case SND_SOC_BIAS_STANDBY:
-                if (codec->bias_level == SND_SOC_BIAS_OFF)
-                        dac33_hard_power(codec, 1);
+                if (codec->bias_level == SND_SOC_BIAS_OFF) {
+                        ret = dac33_hard_power(codec, 1);
+                        if (ret != 0)
+                                return ret;
+                }
+
                 dac33_soft_power(codec, 0);
                 break;
         case SND_SOC_BIAS_OFF:
-                dac33_hard_power(codec, 0);
+                ret = dac33_hard_power(codec, 0);
+                if (ret != 0)
+                        return ret;
+
                 break;
         }
         codec->bias_level = level;
@@ -489,6 +545,51 @@ static int dac33_set_bias_level(struct snd_soc_codec *codec,
         return 0;
 }
 
+static inline void dac33_prefill_handler(struct tlv320dac33_priv *dac33)
+{
+        struct snd_soc_codec *codec;
+
+        codec = &dac33->codec;
+
+        switch (dac33->fifo_mode) {
+        case DAC33_FIFO_MODE1:
+                dac33_write16(codec, DAC33_NSAMPLE_MSB,
+                                DAC33_THRREG(dac33->nsample));
+                dac33_write16(codec, DAC33_PREFILL_MSB,
+                                DAC33_THRREG(dac33->alarm_threshold));
+                break;
+        case DAC33_FIFO_MODE7:
+                dac33_write16(codec, DAC33_PREFILL_MSB,
+                                DAC33_THRREG(10));
+                break;
+        default:
+                dev_warn(codec->dev, "Unhandled FIFO mode: %d\n",
+                                                        dac33->fifo_mode);
+                break;
+        }
+}
+
+static inline void dac33_playback_handler(struct tlv320dac33_priv *dac33)
+{
+        struct snd_soc_codec *codec;
+
+        codec = &dac33->codec;
+
+        switch (dac33->fifo_mode) {
+        case DAC33_FIFO_MODE1:
+                dac33_write16(codec, DAC33_NSAMPLE_MSB,
+                                DAC33_THRREG(dac33->nsample));
+                break;
+        case DAC33_FIFO_MODE7:
+                /* At the moment we are not using interrupts in mode7 */
+                break;
+        default:
+                dev_warn(codec->dev, "Unhandled FIFO mode: %d\n",
+                                                        dac33->fifo_mode);
+                break;
+        }
+}
+
 static void dac33_work(struct work_struct *work)
 {
         struct snd_soc_codec *codec;
@@ -502,14 +603,10 @@ static void dac33_work(struct work_struct *work)
         switch (dac33->state) {
         case DAC33_PREFILL:
                 dac33->state = DAC33_PLAYBACK;
-                dac33_write16(codec, DAC33_NSAMPLE_MSB,
-                                DAC33_THRREG(dac33->nsample));
-                dac33_write16(codec, DAC33_PREFILL_MSB,
-                                DAC33_THRREG(dac33->alarm_threshold));
+                dac33_prefill_handler(dac33);
                 break;
         case DAC33_PLAYBACK:
-                dac33_write16(codec, DAC33_NSAMPLE_MSB,
-                                DAC33_THRREG(dac33->nsample));
+                dac33_playback_handler(dac33);
                 break;
         case DAC33_IDLE:
                 break;
@@ -547,7 +644,7 @@ static void dac33_shutdown(struct snd_pcm_substream *substream,
         unsigned int pwr_ctrl;
 
         /* Stop pending workqueue */
-        if (dac33->nsample_switch)
+        if (dac33->fifo_mode)
                 cancel_work_sync(&dac33->work);
 
         mutex_lock(&dac33->mutex);
@@ -603,7 +700,7 @@ static int dac33_hw_params(struct snd_pcm_substream *substream,
 }
 
 #define CALC_OSCSET(rate, refclk) ( \
-        ((((rate * 10000) / refclk) * 4096) + 5000) / 10000)
+        ((((rate * 10000) / refclk) * 4096) + 7000) / 10000)
 #define CALC_RATIOSET(rate, refclk) ( \
         ((((refclk  * 100000) / rate) * 16384) + 50000) / 100000)
 
@@ -619,7 +716,7 @@ static int dac33_prepare_chip(struct snd_pcm_substream *substream)
         struct snd_soc_codec *codec = socdev->card->codec;
         struct tlv320dac33_priv *dac33 = codec->private_data;
         unsigned int oscset, ratioset, pwr_ctrl, reg_tmp;
-        u8 aictrl_a, fifoctrl_a;
+        u8 aictrl_a, aictrl_b, fifoctrl_a;
 
         switch (substream->runtime->rate) {
         case 44100:
@@ -637,7 +734,10 @@ static int dac33_prepare_chip(struct snd_pcm_substream *substream)
 
         aictrl_a = dac33_read_reg_cache(codec, DAC33_SER_AUDIOIF_CTRL_A);
         aictrl_a &= ~(DAC33_NCYCL_MASK | DAC33_WLEN_MASK);
+        /* Read FIFO control A, and clear FIFO flush bit */
         fifoctrl_a = dac33_read_reg_cache(codec, DAC33_FIFO_CTRL_A);
+        fifoctrl_a &= ~DAC33_FIFOFLUSH;
+
         fifoctrl_a &= ~DAC33_WIDTH;
         switch (substream->runtime->format) {
         case SNDRV_PCM_FORMAT_S16_LE:
@@ -675,7 +775,8 @@ static int dac33_prepare_chip(struct snd_pcm_substream *substream)
 
         dac33_oscwait(codec);
 
-        if (dac33->nsample_switch) {
+        if (dac33->fifo_mode) {
+                /* Generic for all FIFO modes */
                 /* 50-51 : ASRC Control registers */
                 dac33_write(codec, DAC33_ASRC_CTRL_A, (1 << 4)); /* div=2 */
                 dac33_write(codec, DAC33_ASRC_CTRL_B, 1); /* ??? */
@@ -685,38 +786,101 @@ static int dac33_prepare_chip(struct snd_pcm_substream *substream)
 
                 /* Set interrupts to high active */
                 dac33_write(codec, DAC33_INTP_CTRL_A, DAC33_INTPM_AHIGH);
-
-                dac33_write(codec, DAC33_FIFO_IRQ_MODE_B,
-                            DAC33_ATM(DAC33_FIFO_IRQ_MODE_LEVEL));
-                dac33_write(codec, DAC33_FIFO_IRQ_MASK, DAC33_MAT);
         } else {
+                /* FIFO bypass mode */
                 /* 50-51 : ASRC Control registers */
                 dac33_write(codec, DAC33_ASRC_CTRL_A, DAC33_SRCBYP);
                 dac33_write(codec, DAC33_ASRC_CTRL_B, 0); /* ??? */
         }
 
-        if (dac33->nsample_switch)
+        /* Interrupt behaviour configuration */
+        switch (dac33->fifo_mode) {
+        case DAC33_FIFO_MODE1:
+                dac33_write(codec, DAC33_FIFO_IRQ_MODE_B,
+                            DAC33_ATM(DAC33_FIFO_IRQ_MODE_LEVEL));
+                dac33_write(codec, DAC33_FIFO_IRQ_MASK, DAC33_MAT);
+                break;
+        case DAC33_FIFO_MODE7:
+                /* Disable all interrupts */
+                dac33_write(codec, DAC33_FIFO_IRQ_MASK, 0);
+                break;
+        default:
+                /* in FIFO bypass mode, the interrupts are not used */
+                break;
+        }
+
+        aictrl_b = dac33_read_reg_cache(codec, DAC33_SER_AUDIOIF_CTRL_B);
+
+        switch (dac33->fifo_mode) {
+        case DAC33_FIFO_MODE1:
+                /*
+                 * For mode1:
+                 * Disable the FIFO bypass (Enable the use of FIFO)
+                 * Select nSample mode
+                 * BCLK is only running when data is needed by DAC33
+                 */
                 fifoctrl_a &= ~DAC33_FBYPAS;
-        else
+                fifoctrl_a &= ~DAC33_FAUTO;
+                aictrl_b &= ~DAC33_BCLKON;
+                break;
+        case DAC33_FIFO_MODE7:
+                /*
+                 * For mode1:
+                 * Disable the FIFO bypass (Enable the use of FIFO)
+                 * Select Threshold mode
+                 * BCLK is only running when data is needed by DAC33
+                 */
+                fifoctrl_a &= ~DAC33_FBYPAS;
+                fifoctrl_a |= DAC33_FAUTO;
+                aictrl_b &= ~DAC33_BCLKON;
+                break;
+        default:
+                /*
+                 * For FIFO bypass mode:
+                 * Enable the FIFO bypass (Disable the FIFO use)
+                 * Set the BCLK as continous
+                 */
                 fifoctrl_a |= DAC33_FBYPAS;
-        dac33_write(codec, DAC33_FIFO_CTRL_A, fifoctrl_a);
+                aictrl_b |= DAC33_BCLKON;
+                break;
+        }
 
+        dac33_write(codec, DAC33_FIFO_CTRL_A, fifoctrl_a);
         dac33_write(codec, DAC33_SER_AUDIOIF_CTRL_A, aictrl_a);
-        reg_tmp = dac33_read_reg_cache(codec, DAC33_SER_AUDIOIF_CTRL_B);
-        if (dac33->nsample_switch)
-                reg_tmp &= ~DAC33_BCLKON;
-        else
-                reg_tmp |= DAC33_BCLKON;
-        dac33_write(codec, DAC33_SER_AUDIOIF_CTRL_B, reg_tmp);
+        dac33_write(codec, DAC33_SER_AUDIOIF_CTRL_B, aictrl_b);
 
-        if (dac33->nsample_switch) {
-                /* 20: BCLK divide ratio */
-                dac33_write(codec, DAC33_SER_AUDIOIF_CTRL_C, 3);
+        /*
+         * BCLK divide ratio
+         * 0: 1.5
+         * 1: 1
+         * 2: 2
+         * ...
+         * 254: 254
+         * 255: 255
+         */
+        if (dac33->fifo_mode)
+                dac33_write(codec, DAC33_SER_AUDIOIF_CTRL_C,
+                                                        dac33->burst_bclkdiv);
+        else
+                dac33_write(codec, DAC33_SER_AUDIOIF_CTRL_C, 32);
 
+        switch (dac33->fifo_mode) {
+        case DAC33_FIFO_MODE1:
                 dac33_write16(codec, DAC33_ATHR_MSB,
                               DAC33_THRREG(dac33->alarm_threshold));
-        } else {
-                dac33_write(codec, DAC33_SER_AUDIOIF_CTRL_C, 32);
+                break;
+        case DAC33_FIFO_MODE7:
+                /*
+                 * Configure the threshold levels, and leave 10 sample space
+                 * at the bottom, and also at the top of the FIFO
+                 */
+                dac33_write16(codec, DAC33_UTHR_MSB,
+                        DAC33_THRREG(DAC33_BUFFER_SIZE_SAMPLES - 10));
+                dac33_write16(codec, DAC33_LTHR_MSB,
+                        DAC33_THRREG(10));
+                break;
+        default:
+                break;
         }
 
         mutex_unlock(&dac33->mutex);
@@ -789,7 +953,7 @@ static int dac33_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
         case SNDRV_PCM_TRIGGER_START:
         case SNDRV_PCM_TRIGGER_RESUME:
         case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
-                if (dac33->nsample_switch) {
+                if (dac33->fifo_mode) {
                         dac33->state = DAC33_PREFILL;
                         queue_work(dac33->dac33_wq, &dac33->work);
                 }
@@ -797,7 +961,7 @@ static int dac33_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
         case SNDRV_PCM_TRIGGER_STOP:
         case SNDRV_PCM_TRIGGER_SUSPEND:
         case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
-                if (dac33->nsample_switch) {
+                if (dac33->fifo_mode) {
                         dac33->state = DAC33_FLUSH;
                         queue_work(dac33->dac33_wq, &dac33->work);
                 }
@@ -843,6 +1007,7 @@ static int dac33_set_dai_fmt(struct snd_soc_dai *codec_dai,
                              unsigned int fmt)
 {
         struct snd_soc_codec *codec = codec_dai->codec;
+        struct tlv320dac33_priv *dac33 = codec->private_data;
         u8 aictrl_a, aictrl_b;
 
         aictrl_a = dac33_read_reg_cache(codec, DAC33_SER_AUDIOIF_CTRL_A);
@@ -855,7 +1020,11 @@ static int dac33_set_dai_fmt(struct snd_soc_dai *codec_dai,
                 break;
         case SND_SOC_DAIFMT_CBS_CFS:
                 /* Codec Slave */
-                aictrl_a &= ~(DAC33_MSBCLK | DAC33_MSWCLK);
+                if (dac33->fifo_mode) {
+                        dev_err(codec->dev, "FIFO mode requires master mode\n");
+                        return -EINVAL;
+                } else
+                        aictrl_a &= ~(DAC33_MSBCLK | DAC33_MSWCLK);
                 break;
         default:
                 return -EINVAL;
@@ -959,6 +1128,9 @@ static int dac33_soc_probe(struct platform_device *pdev)
         /* power on device */
         dac33_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
 
+        /* Bias level configuration has enabled regulator an extra time */
+        regulator_bulk_disable(ARRAY_SIZE(dac33->supplies), dac33->supplies);
+
         return 0;
 
 pcm_err:
@@ -1033,13 +1205,13 @@ struct snd_soc_dai dac33_dai = {
 };
 EXPORT_SYMBOL_GPL(dac33_dai);
 
-static int dac33_i2c_probe(struct i2c_client *client,
-                           const struct i2c_device_id *id)
+static int __devinit dac33_i2c_probe(struct i2c_client *client,
+                                     const struct i2c_device_id *id)
 {
         struct tlv320dac33_platform_data *pdata;
         struct tlv320dac33_priv *dac33;
         struct snd_soc_codec *codec;
-        int ret = 0;
+        int ret, i;
 
         if (client->dev.platform_data == NULL) {
                 dev_err(&client->dev, "Platform data not set\n");
@@ -1080,10 +1252,11 @@ static int dac33_i2c_probe(struct i2c_client *client,
         i2c_set_clientdata(client, dac33);
 
         dac33->power_gpio = pdata->power_gpio;
+        dac33->burst_bclkdiv = pdata->burst_bclkdiv;
         dac33->irq = client->irq;
         dac33->nsample = NSAMPLE_MAX;
         /* Disable FIFO use by default */
-        dac33->nsample_switch = 0;
+        dac33->fifo_mode = DAC33_FIFO_BYPASS;
 
         tlv320dac33_codec = codec;
 
@@ -1130,6 +1303,24 @@ static int dac33_i2c_probe(struct i2c_client *client,
                 }
         }
 
+        for (i = 0; i < ARRAY_SIZE(dac33->supplies); i++)
+                dac33->supplies[i].supply = dac33_supply_names[i];
+
+        ret = regulator_bulk_get(codec->dev, ARRAY_SIZE(dac33->supplies),
+                                 dac33->supplies);
+
+        if (ret != 0) {
+                dev_err(codec->dev, "Failed to request supplies: %d\n", ret);
+                goto err_get;
+        }
+
+        ret = regulator_bulk_enable(ARRAY_SIZE(dac33->supplies),
+                                    dac33->supplies);
+        if (ret != 0) {
+                dev_err(codec->dev, "Failed to enable supplies: %d\n", ret);
+                goto err_enable;
+        }
+
         ret = snd_soc_register_codec(codec);
         if (ret != 0) {
                 dev_err(codec->dev, "Failed to register codec: %d\n", ret);
@@ -1149,6 +1340,10 @@ static int dac33_i2c_probe(struct i2c_client *client,
         return ret;
 
 error_codec:
+        regulator_bulk_disable(ARRAY_SIZE(dac33->supplies), dac33->supplies);
+err_enable:
+        regulator_bulk_free(ARRAY_SIZE(dac33->supplies), dac33->supplies);
+err_get:
         if (dac33->irq >= 0) {
                 free_irq(dac33->irq, &dac33->codec);
                 destroy_workqueue(dac33->dac33_wq);
@@ -1165,7 +1360,7 @@ error_reg:
         return ret;
 }
 
-static int dac33_i2c_remove(struct i2c_client *client)
+static int __devexit dac33_i2c_remove(struct i2c_client *client)
 {
         struct tlv320dac33_priv *dac33;
 
@@ -1177,6 +1372,8 @@ static int dac33_i2c_remove(struct i2c_client *client)
         if (dac33->irq >= 0)
                 free_irq(dac33->irq, &dac33->codec);
 
+        regulator_bulk_free(ARRAY_SIZE(dac33->supplies), dac33->supplies);
+
         destroy_workqueue(dac33->dac33_wq);
         snd_soc_unregister_dai(&dac33_dai);
         snd_soc_unregister_codec(&dac33->codec);