diff options
author | Axel Lin <axel.lin@gmail.com> | 2011-09-29 00:09:57 -0400 |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2011-09-29 05:53:12 -0400 |
commit | c29429f3b72fe0b593f674378e99f22d5f8bea1f (patch) | |
tree | 8d36d82bd4ff1e1cad544a4d10f35ea712b6773d /sound/soc/codecs/tlv320dac33.c | |
parent | a8fdac83a3703c7f35d4efe37a14e38aa256919b (diff) |
ASoC: tlv320dac33: Add guarding parentheses to macros
Put parentheses around macro argument uses. This avoids pitfalls
for the programmer, where the argument expansion does not give the
expected result, for example:
SAMPLES_TO_US(substream->runtime->rate, dac33->uthr - DAC33_MODE7_MARGIN + 1);
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'sound/soc/codecs/tlv320dac33.c')
-rw-r--r-- | sound/soc/codecs/tlv320dac33.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c index faa5e9fb1471..43ee3b1c757e 100644 --- a/sound/soc/codecs/tlv320dac33.c +++ b/sound/soc/codecs/tlv320dac33.c | |||
@@ -55,13 +55,13 @@ | |||
55 | #define BURST_BASEFREQ_HZ 49152000 | 55 | #define BURST_BASEFREQ_HZ 49152000 |
56 | 56 | ||
57 | #define SAMPLES_TO_US(rate, samples) \ | 57 | #define SAMPLES_TO_US(rate, samples) \ |
58 | (1000000000 / ((rate * 1000) / samples)) | 58 | (1000000000 / (((rate) * 1000) / (samples))) |
59 | 59 | ||
60 | #define US_TO_SAMPLES(rate, us) \ | 60 | #define US_TO_SAMPLES(rate, us) \ |
61 | (rate / (1000000 / (us < 1000000 ? us : 1000000))) | 61 | ((rate) / (1000000 / ((us) < 1000000 ? (us) : 1000000))) |
62 | 62 | ||
63 | #define UTHR_FROM_PERIOD_SIZE(samples, playrate, burstrate) \ | 63 | #define UTHR_FROM_PERIOD_SIZE(samples, playrate, burstrate) \ |
64 | ((samples * 5000) / ((burstrate * 5000) / (burstrate - playrate))) | 64 | (((samples)*5000) / (((burstrate)*5000) / ((burstrate) - (playrate)))) |
65 | 65 | ||
66 | static void dac33_calculate_times(struct snd_pcm_substream *substream); | 66 | static void dac33_calculate_times(struct snd_pcm_substream *substream); |
67 | static int dac33_prepare_chip(struct snd_pcm_substream *substream); | 67 | static int dac33_prepare_chip(struct snd_pcm_substream *substream); |