diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-09-13 03:52:49 -0400 |
---|---|---|
committer | Mark Brown <broonie@linaro.org> | 2013-09-13 13:36:39 -0400 |
commit | d967967e8d1116fb38bad25e58714b5dddd03cca (patch) | |
tree | 98add03945c8971fa345073a3bcd6f2ae6da497c /sound/soc/codecs/88pm860x-codec.c | |
parent | 5df498a27ab385294fdb7cad19c623d4da94a780 (diff) |
ASoC: 88pm860x: array overflow in snd_soc_put_volsw_2r_st()
This is called from snd_ctl_elem_write() with user supplied data so we
need to add some bounds checking.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Cc: stable@vger.kernel.org
Diffstat (limited to 'sound/soc/codecs/88pm860x-codec.c')
-rw-r--r-- | sound/soc/codecs/88pm860x-codec.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/sound/soc/codecs/88pm860x-codec.c b/sound/soc/codecs/88pm860x-codec.c index 8af04343cc1a..259d1ac4492f 100644 --- a/sound/soc/codecs/88pm860x-codec.c +++ b/sound/soc/codecs/88pm860x-codec.c | |||
@@ -349,6 +349,9 @@ static int snd_soc_put_volsw_2r_st(struct snd_kcontrol *kcontrol, | |||
349 | val = ucontrol->value.integer.value[0]; | 349 | val = ucontrol->value.integer.value[0]; |
350 | val2 = ucontrol->value.integer.value[1]; | 350 | val2 = ucontrol->value.integer.value[1]; |
351 | 351 | ||
352 | if (val >= ARRAY_SIZE(st_table) || val2 >= ARRAY_SIZE(st_table)) | ||
353 | return -EINVAL; | ||
354 | |||
352 | err = snd_soc_update_bits(codec, reg, 0x3f, st_table[val].m); | 355 | err = snd_soc_update_bits(codec, reg, 0x3f, st_table[val].m); |
353 | if (err < 0) | 356 | if (err < 0) |
354 | return err; | 357 | return err; |