diff options
author | Jeff Garzik <jeff@garzik.org> | 2006-10-06 15:00:58 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2006-10-06 15:00:58 -0400 |
commit | c7bec5aba52392aa8d675b8722735caf4a8b7265 (patch) | |
tree | 8087cfd2866e63fba25e18ba1fa0f374c27be4f0 /sound/pci | |
parent | c31f28e778ab299a5035ea2bda64f245b8915d7c (diff) |
Various drivers' irq handlers: kill dead code, needless casts
- Eliminate casts to/from void*
- Eliminate checks for conditions that never occur. These typically
fall into two classes:
1) Checking for 'dev_id == NULL', then it is never called with
NULL as an argument.
2) Checking for invalid irq number, when the only caller (the
system) guarantees the irq handler is called with the proper
'irq' number argument.
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'sound/pci')
-rw-r--r-- | sound/pci/korg1212/korg1212.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/sound/pci/korg1212/korg1212.c b/sound/pci/korg1212/korg1212.c index 398aa10a06e8..fa8cd8cecc21 100644 --- a/sound/pci/korg1212/korg1212.c +++ b/sound/pci/korg1212/korg1212.c | |||
@@ -1124,9 +1124,6 @@ static irqreturn_t snd_korg1212_interrupt(int irq, void *dev_id) | |||
1124 | u32 doorbellValue; | 1124 | u32 doorbellValue; |
1125 | struct snd_korg1212 *korg1212 = dev_id; | 1125 | struct snd_korg1212 *korg1212 = dev_id; |
1126 | 1126 | ||
1127 | if(irq != korg1212->irq) | ||
1128 | return IRQ_NONE; | ||
1129 | |||
1130 | doorbellValue = readl(korg1212->inDoorbellPtr); | 1127 | doorbellValue = readl(korg1212->inDoorbellPtr); |
1131 | 1128 | ||
1132 | if (!doorbellValue) | 1129 | if (!doorbellValue) |
@@ -1140,7 +1137,6 @@ static irqreturn_t snd_korg1212_interrupt(int irq, void *dev_id) | |||
1140 | 1137 | ||
1141 | korg1212->inIRQ++; | 1138 | korg1212->inIRQ++; |
1142 | 1139 | ||
1143 | |||
1144 | switch (doorbellValue) { | 1140 | switch (doorbellValue) { |
1145 | case K1212_DB_DSPDownloadDone: | 1141 | case K1212_DB_DSPDownloadDone: |
1146 | K1212_DEBUG_PRINTK("K1212_DEBUG: IRQ DNLD count - %ld, %x, [%s].\n", | 1142 | K1212_DEBUG_PRINTK("K1212_DEBUG: IRQ DNLD count - %ld, %x, [%s].\n", |