diff options
author | Dylan Reid <dgreid@chromium.org> | 2014-03-02 23:44:00 -0500 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2014-03-03 03:53:21 -0500 |
commit | 778bde6f59e062a44df5e82646db71c9ef84c18a (patch) | |
tree | f83ce3c3edc931d77d615b83920c7e7f970cccdd /sound/pci | |
parent | 7c3e438add2710f9a92017e2d942081db4f88909 (diff) |
ALSA: hda - Rename reg access ops in hda_controller_ops
Using readl, writel, etc. resulted in some architectures, such as
s390, expanding the member names into zpci_writel. Obviously not the
intended result.
Fixes s390 build breakage introduced by "4083081 - ALSA: hda - Allow
different ops to read/write registers"
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci')
-rw-r--r-- | sound/pci/hda/hda_intel.c | 12 | ||||
-rw-r--r-- | sound/pci/hda/hda_priv.h | 36 |
2 files changed, 24 insertions, 24 deletions
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index b26eff3edfc1..149c00b00320 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c | |||
@@ -1537,12 +1537,12 @@ static void pcm_mmap_prepare(struct snd_pcm_substream *substream, | |||
1537 | } | 1537 | } |
1538 | 1538 | ||
1539 | static const struct hda_controller_ops pci_hda_ops = { | 1539 | static const struct hda_controller_ops pci_hda_ops = { |
1540 | .writel = pci_azx_writel, | 1540 | .reg_writel = pci_azx_writel, |
1541 | .readl = pci_azx_readl, | 1541 | .reg_readl = pci_azx_readl, |
1542 | .writew = pci_azx_writew, | 1542 | .reg_writew = pci_azx_writew, |
1543 | .readw = pci_azx_readw, | 1543 | .reg_readw = pci_azx_readw, |
1544 | .writeb = pci_azx_writeb, | 1544 | .reg_writeb = pci_azx_writeb, |
1545 | .readb = pci_azx_readb, | 1545 | .reg_readb = pci_azx_readb, |
1546 | .disable_msi_reset_irq = disable_msi_reset_irq, | 1546 | .disable_msi_reset_irq = disable_msi_reset_irq, |
1547 | .dma_alloc_pages = dma_alloc_pages, | 1547 | .dma_alloc_pages = dma_alloc_pages, |
1548 | .dma_free_pages = dma_free_pages, | 1548 | .dma_free_pages = dma_free_pages, |
diff --git a/sound/pci/hda/hda_priv.h b/sound/pci/hda/hda_priv.h index bf3cb33e0dd3..198fa825fa0e 100644 --- a/sound/pci/hda/hda_priv.h +++ b/sound/pci/hda/hda_priv.h | |||
@@ -290,12 +290,12 @@ struct azx; | |||
290 | /* Functions to read/write to hda registers. */ | 290 | /* Functions to read/write to hda registers. */ |
291 | struct hda_controller_ops { | 291 | struct hda_controller_ops { |
292 | /* Register Access */ | 292 | /* Register Access */ |
293 | void (*writel)(u32 value, u32 *addr); | 293 | void (*reg_writel)(u32 value, u32 *addr); |
294 | u32 (*readl)(u32 *addr); | 294 | u32 (*reg_readl)(u32 *addr); |
295 | void (*writew)(u16 value, u16 *addr); | 295 | void (*reg_writew)(u16 value, u16 *addr); |
296 | u16 (*readw)(u16 *addr); | 296 | u16 (*reg_readw)(u16 *addr); |
297 | void (*writeb)(u8 value, u8 *addr); | 297 | void (*reg_writeb)(u8 value, u8 *addr); |
298 | u8 (*readb)(u8 *addr); | 298 | u8 (*reg_readb)(u8 *addr); |
299 | /* Disable msi if supported, PCI only */ | 299 | /* Disable msi if supported, PCI only */ |
300 | int (*disable_msi_reset_irq)(struct azx *); | 300 | int (*disable_msi_reset_irq)(struct azx *); |
301 | /* Allocation ops */ | 301 | /* Allocation ops */ |
@@ -435,29 +435,29 @@ struct azx { | |||
435 | */ | 435 | */ |
436 | 436 | ||
437 | #define azx_writel(chip, reg, value) \ | 437 | #define azx_writel(chip, reg, value) \ |
438 | ((chip)->ops->writel(value, (chip)->remap_addr + ICH6_REG_##reg)) | 438 | ((chip)->ops->reg_writel(value, (chip)->remap_addr + ICH6_REG_##reg)) |
439 | #define azx_readl(chip, reg) \ | 439 | #define azx_readl(chip, reg) \ |
440 | ((chip)->ops->readl((chip)->remap_addr + ICH6_REG_##reg)) | 440 | ((chip)->ops->reg_readl((chip)->remap_addr + ICH6_REG_##reg)) |
441 | #define azx_writew(chip, reg, value) \ | 441 | #define azx_writew(chip, reg, value) \ |
442 | ((chip)->ops->writew(value, (chip)->remap_addr + ICH6_REG_##reg)) | 442 | ((chip)->ops->reg_writew(value, (chip)->remap_addr + ICH6_REG_##reg)) |
443 | #define azx_readw(chip, reg) \ | 443 | #define azx_readw(chip, reg) \ |
444 | ((chip)->ops->readw((chip)->remap_addr + ICH6_REG_##reg)) | 444 | ((chip)->ops->reg_readw((chip)->remap_addr + ICH6_REG_##reg)) |
445 | #define azx_writeb(chip, reg, value) \ | 445 | #define azx_writeb(chip, reg, value) \ |
446 | ((chip)->ops->writeb(value, (chip)->remap_addr + ICH6_REG_##reg)) | 446 | ((chip)->ops->reg_writeb(value, (chip)->remap_addr + ICH6_REG_##reg)) |
447 | #define azx_readb(chip, reg) \ | 447 | #define azx_readb(chip, reg) \ |
448 | ((chip)->ops->readb((chip)->remap_addr + ICH6_REG_##reg)) | 448 | ((chip)->ops->reg_readb((chip)->remap_addr + ICH6_REG_##reg)) |
449 | 449 | ||
450 | #define azx_sd_writel(chip, dev, reg, value) \ | 450 | #define azx_sd_writel(chip, dev, reg, value) \ |
451 | ((chip)->ops->writel(value, (dev)->sd_addr + ICH6_REG_##reg)) | 451 | ((chip)->ops->reg_writel(value, (dev)->sd_addr + ICH6_REG_##reg)) |
452 | #define azx_sd_readl(chip, dev, reg) \ | 452 | #define azx_sd_readl(chip, dev, reg) \ |
453 | ((chip)->ops->readl((dev)->sd_addr + ICH6_REG_##reg)) | 453 | ((chip)->ops->reg_readl((dev)->sd_addr + ICH6_REG_##reg)) |
454 | #define azx_sd_writew(chip, dev, reg, value) \ | 454 | #define azx_sd_writew(chip, dev, reg, value) \ |
455 | ((chip)->ops->writew(value, (dev)->sd_addr + ICH6_REG_##reg)) | 455 | ((chip)->ops->reg_writew(value, (dev)->sd_addr + ICH6_REG_##reg)) |
456 | #define azx_sd_readw(chip, dev, reg) \ | 456 | #define azx_sd_readw(chip, dev, reg) \ |
457 | ((chip)->ops->readw((dev)->sd_addr + ICH6_REG_##reg)) | 457 | ((chip)->ops->reg_readw((dev)->sd_addr + ICH6_REG_##reg)) |
458 | #define azx_sd_writeb(chip, dev, reg, value) \ | 458 | #define azx_sd_writeb(chip, dev, reg, value) \ |
459 | ((chip)->ops->writeb(value, (dev)->sd_addr + ICH6_REG_##reg)) | 459 | ((chip)->ops->reg_writeb(value, (dev)->sd_addr + ICH6_REG_##reg)) |
460 | #define azx_sd_readb(chip, dev, reg) \ | 460 | #define azx_sd_readb(chip, dev, reg) \ |
461 | ((chip)->ops->readb((dev)->sd_addr + ICH6_REG_##reg)) | 461 | ((chip)->ops->reg_readb((dev)->sd_addr + ICH6_REG_##reg)) |
462 | 462 | ||
463 | #endif /* __SOUND_HDA_PRIV_H */ | 463 | #endif /* __SOUND_HDA_PRIV_H */ |