aboutsummaryrefslogtreecommitdiffstats
path: root/sound/pci
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2008-06-10 11:53:35 -0400
committerJaroslav Kysela <perex@perex.cz>2008-06-13 10:47:23 -0400
commita6a950a8a8e1431e8527809339e089ac926a7d34 (patch)
treeea9ff916ee9a8f1a58cb2afaeb634a932876736b /sound/pci
parent8c53b96f229aa6e27f17855cbbf8e4243868a3a9 (diff)
ALSA: hda - Add a warning if pending IRQ is found
The pending IRQ handling is a very hackish workaround and should be avoided as much as possible via a larger bdl_pos_adj option value. Put a warning message if this situation occurs so that the user may have a chance to notice that something is wrong. Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Diffstat (limited to 'sound/pci')
-rw-r--r--sound/pci/hda/hda_intel.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 9b2dc0669b94..ec4ae2d94000 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -374,6 +374,7 @@ struct azx {
374 unsigned int single_cmd :1; 374 unsigned int single_cmd :1;
375 unsigned int polling_mode :1; 375 unsigned int polling_mode :1;
376 unsigned int msi :1; 376 unsigned int msi :1;
377 unsigned int irq_pending_warned :1;
377 378
378 /* for debugging */ 379 /* for debugging */
379 unsigned int last_cmd; /* last issued command (to sync) */ 380 unsigned int last_cmd; /* last issued command (to sync) */
@@ -1562,6 +1563,14 @@ static void azx_irq_pending_work(struct work_struct *work)
1562 struct azx *chip = container_of(work, struct azx, irq_pending_work); 1563 struct azx *chip = container_of(work, struct azx, irq_pending_work);
1563 int i, pending; 1564 int i, pending;
1564 1565
1566 if (!chip->irq_pending_warned) {
1567 printk(KERN_WARNING
1568 "hda-intel: IRQ timing workaround is activated "
1569 "for card #%d. Suggest a bigger bdl_pos_adj.\n",
1570 chip->card->number);
1571 chip->irq_pending_warned = 1;
1572 }
1573
1565 for (;;) { 1574 for (;;) {
1566 pending = 0; 1575 pending = 0;
1567 spin_lock_irq(&chip->reg_lock); 1576 spin_lock_irq(&chip->reg_lock);