diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-08-19 03:02:55 -0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2012-08-20 04:57:51 -0400 |
commit | ae970eb45d8a1ea4506be23c3f776225b9575d0e (patch) | |
tree | d810033861da7c505e7a837b52d069d87db7d025 /sound/pci/sis7019.c | |
parent | 4d8ce1c9966663bad69e738952179f3cc52710bf (diff) |
ALSA: sound/pci/sis7019.c: fix error return code
Initialize rc before returning on failure, as done elsewhere in the
function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/sis7019.c')
-rw-r--r-- | sound/pci/sis7019.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sound/pci/sis7019.c b/sound/pci/sis7019.c index 512434efcc31..805ab6e9a78f 100644 --- a/sound/pci/sis7019.c +++ b/sound/pci/sis7019.c | |||
@@ -1377,8 +1377,9 @@ static int __devinit sis_chip_create(struct snd_card *card, | |||
1377 | if (rc) | 1377 | if (rc) |
1378 | goto error_out_cleanup; | 1378 | goto error_out_cleanup; |
1379 | 1379 | ||
1380 | if (request_irq(pci->irq, sis_interrupt, IRQF_SHARED, KBUILD_MODNAME, | 1380 | rc = request_irq(pci->irq, sis_interrupt, IRQF_SHARED, KBUILD_MODNAME, |
1381 | sis)) { | 1381 | sis); |
1382 | if (rc) { | ||
1382 | dev_err(&pci->dev, "unable to allocate irq %d\n", sis->irq); | 1383 | dev_err(&pci->dev, "unable to allocate irq %d\n", sis->irq); |
1383 | goto error_out_cleanup; | 1384 | goto error_out_cleanup; |
1384 | } | 1385 | } |