[ALSA] Fix possible races at free_irq in PCI drivers

The irq handler of PCI drivers must be released before releasing other
resources since the handler for a shared irq can be still called and
may access the freed resource again.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

1 files changed, 1 insertions, 3 deletions

diff --git a/sound/pci/nm256/nm256.c b/sound/pci/nm256/nm256.c
index 7ac654e381da..7efb838d18a6 100644
--- a/sound/pci/nm256/nm256.c
+++ b/sound/pci/nm256/nm256.c
@@ -1439,7 +1439,7 @@ static int snd_nm256_free(struct nm256 *chip)
                 snd_nm256_capture_stop(chip);
 
         if (chip->irq >= 0)
-                synchronize_irq(chip->irq);
+                free_irq(chip->irq, chip);
 
         if (chip->cport)
                 iounmap(chip->cport);
@@ -1447,8 +1447,6 @@ static int snd_nm256_free(struct nm256 *chip)
                 iounmap(chip->buffer);
         release_and_free_resource(chip->res_cport);
         release_and_free_resource(chip->res_buffer);
-        if (chip->irq >= 0)
-                free_irq(chip->irq, chip);
 
         pci_disable_device(chip->pci);
         kfree(chip->ac97_regs);