aboutsummaryrefslogtreecommitdiffstats
path: root/sound/pci/ice1712
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2008-11-01 06:01:50 -0400
committerTakashi Iwai <tiwai@suse.de>2008-11-01 06:03:52 -0400
commit4074ea21493fe668501bfc7548d10657ca6f14c2 (patch)
treec702fd64d2f68ef6555514d4ae44a1d1a4c0a929 /sound/pci/ice1712
parent9cbbb3ac628227ec5b65fc043539949db606cd17 (diff)
ALSA: ice1724 - Fix IRQ register initialization
The IRQMASK register has to be set to zero expclitily at the initialization otherwise you'll get no interrupts properly at later operations. Also, removed the old commented out codes. Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/ice1712')
-rw-r--r--sound/pci/ice1712/ice1724.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c
index 79a9cd0881f7..40725dfdc864 100644
--- a/sound/pci/ice1712/ice1724.c
+++ b/sound/pci/ice1712/ice1724.c
@@ -2353,7 +2353,6 @@ static int __devinit snd_vt1724_create(struct snd_card *card,
2353{ 2353{
2354 struct snd_ice1712 *ice; 2354 struct snd_ice1712 *ice;
2355 int err; 2355 int err;
2356 /* unsigned char mask; */
2357 static struct snd_device_ops ops = { 2356 static struct snd_device_ops ops = {
2358 .dev_free = snd_vt1724_dev_free, 2357 .dev_free = snd_vt1724_dev_free,
2359 }; 2358 };
@@ -2414,11 +2413,9 @@ static int __devinit snd_vt1724_create(struct snd_card *card,
2414 return -EIO; 2413 return -EIO;
2415 } 2414 }
2416 2415
2417 /* unmask used interrupts */ 2416 /* clear interrupts -- otherwise you'll get irq problems later */
2418#if 0 /* these are enabled/disabled dynamically */ 2417 outb(0, ICEREG1724(ice, IRQMASK));
2419 mask = VT1724_IRQ_MPU_RX | VT1724_IRQ_MPU_TX; 2418
2420 outb(mask, ICEREG1724(ice, IRQMASK));
2421#endif
2422 /* don't handle FIFO overrun/underruns (just yet), 2419 /* don't handle FIFO overrun/underruns (just yet),
2423 * since they cause machine lockups 2420 * since they cause machine lockups
2424 */ 2421 */