diff options
author | Takashi Iwai <tiwai@suse.de> | 2008-01-13 06:03:05 -0500 |
---|---|---|
committer | Jaroslav Kysela <perex@perex.cz> | 2008-01-31 11:29:56 -0500 |
commit | 52a1d4f9d6e40c2473a85105cb5e055914a4779d (patch) | |
tree | 787d943ccdce9a74a872d2151377d128f934b16c /sound/pci/hda | |
parent | 5795b9e64588192b2b1123fed5f9ecaf0ecef5ba (diff) |
[ALSA] hda-codec - Remove obsolete FIXME's
Removed 'FIXME' comments that have been already fixed.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Diffstat (limited to 'sound/pci/hda')
-rw-r--r-- | sound/pci/hda/patch_analog.c | 4 | ||||
-rw-r--r-- | sound/pci/hda/patch_cmedia.c | 1 | ||||
-rw-r--r-- | sound/pci/hda/patch_realtek.c | 20 | ||||
-rw-r--r-- | sound/pci/hda/patch_via.c | 3 |
4 files changed, 0 insertions, 28 deletions
diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c index b0755407be9d..12959314d3a3 100644 --- a/sound/pci/hda/patch_analog.c +++ b/sound/pci/hda/patch_analog.c | |||
@@ -1962,7 +1962,6 @@ static struct snd_kcontrol_new ad1988_capture_mixers[] = { | |||
1962 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 1962 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
1963 | /* The multiple "Capture Source" controls confuse alsamixer | 1963 | /* The multiple "Capture Source" controls confuse alsamixer |
1964 | * So call somewhat different.. | 1964 | * So call somewhat different.. |
1965 | * FIXME: the controls appear in the "playback" view! | ||
1966 | */ | 1965 | */ |
1967 | /* .name = "Capture Source", */ | 1966 | /* .name = "Capture Source", */ |
1968 | .name = "Input Source", | 1967 | .name = "Input Source", |
@@ -2978,7 +2977,6 @@ static struct snd_kcontrol_new ad1884_base_mixers[] = { | |||
2978 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 2977 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
2979 | /* The multiple "Capture Source" controls confuse alsamixer | 2978 | /* The multiple "Capture Source" controls confuse alsamixer |
2980 | * So call somewhat different.. | 2979 | * So call somewhat different.. |
2981 | * FIXME: the controls appear in the "playback" view! | ||
2982 | */ | 2980 | */ |
2983 | /* .name = "Capture Source", */ | 2981 | /* .name = "Capture Source", */ |
2984 | .name = "Input Source", | 2982 | .name = "Input Source", |
@@ -3153,7 +3151,6 @@ static struct snd_kcontrol_new ad1984_thinkpad_mixers[] = { | |||
3153 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 3151 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
3154 | /* The multiple "Capture Source" controls confuse alsamixer | 3152 | /* The multiple "Capture Source" controls confuse alsamixer |
3155 | * So call somewhat different.. | 3153 | * So call somewhat different.. |
3156 | * FIXME: the controls appear in the "playback" view! | ||
3157 | */ | 3154 | */ |
3158 | /* .name = "Capture Source", */ | 3155 | /* .name = "Capture Source", */ |
3159 | .name = "Input Source", | 3156 | .name = "Input Source", |
@@ -3352,7 +3349,6 @@ static struct snd_kcontrol_new ad1882_base_mixers[] = { | |||
3352 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 3349 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
3353 | /* The multiple "Capture Source" controls confuse alsamixer | 3350 | /* The multiple "Capture Source" controls confuse alsamixer |
3354 | * So call somewhat different.. | 3351 | * So call somewhat different.. |
3355 | * FIXME: the controls appear in the "playback" view! | ||
3356 | */ | 3352 | */ |
3357 | /* .name = "Capture Source", */ | 3353 | /* .name = "Capture Source", */ |
3358 | .name = "Input Source", | 3354 | .name = "Input Source", |
diff --git a/sound/pci/hda/patch_cmedia.c b/sound/pci/hda/patch_cmedia.c index 02e31e4d95c4..3d6097ba1d68 100644 --- a/sound/pci/hda/patch_cmedia.c +++ b/sound/pci/hda/patch_cmedia.c | |||
@@ -185,7 +185,6 @@ static struct snd_kcontrol_new cmi9880_basic_mixer[] = { | |||
185 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 185 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
186 | /* The multiple "Capture Source" controls confuse alsamixer | 186 | /* The multiple "Capture Source" controls confuse alsamixer |
187 | * So call somewhat different.. | 187 | * So call somewhat different.. |
188 | * FIXME: the controls appear in the "playback" view! | ||
189 | */ | 188 | */ |
190 | /* .name = "Capture Source", */ | 189 | /* .name = "Capture Source", */ |
191 | .name = "Input Source", | 190 | .name = "Input Source", |
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 9aa2b5821e07..948b5767bba6 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c | |||
@@ -1080,7 +1080,6 @@ static struct snd_kcontrol_new alc880_capture_mixer[] = { | |||
1080 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 1080 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
1081 | /* The multiple "Capture Source" controls confuse alsamixer | 1081 | /* The multiple "Capture Source" controls confuse alsamixer |
1082 | * So call somewhat different.. | 1082 | * So call somewhat different.. |
1083 | * FIXME: the controls appear in the "playback" view! | ||
1084 | */ | 1083 | */ |
1085 | /* .name = "Capture Source", */ | 1084 | /* .name = "Capture Source", */ |
1086 | .name = "Input Source", | 1085 | .name = "Input Source", |
@@ -1102,7 +1101,6 @@ static struct snd_kcontrol_new alc880_capture_alt_mixer[] = { | |||
1102 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 1101 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
1103 | /* The multiple "Capture Source" controls confuse alsamixer | 1102 | /* The multiple "Capture Source" controls confuse alsamixer |
1104 | * So call somewhat different.. | 1103 | * So call somewhat different.. |
1105 | * FIXME: the controls appear in the "playback" view! | ||
1106 | */ | 1104 | */ |
1107 | /* .name = "Capture Source", */ | 1105 | /* .name = "Capture Source", */ |
1108 | .name = "Input Source", | 1106 | .name = "Input Source", |
@@ -1297,7 +1295,6 @@ static struct snd_kcontrol_new alc880_z71v_mixer[] = { | |||
1297 | }; | 1295 | }; |
1298 | 1296 | ||
1299 | 1297 | ||
1300 | /* FIXME! */ | ||
1301 | /* | 1298 | /* |
1302 | * ALC880 F1734 model | 1299 | * ALC880 F1734 model |
1303 | * | 1300 | * |
@@ -1323,7 +1320,6 @@ static struct snd_kcontrol_new alc880_f1734_mixer[] = { | |||
1323 | }; | 1320 | }; |
1324 | 1321 | ||
1325 | 1322 | ||
1326 | /* FIXME! */ | ||
1327 | /* | 1323 | /* |
1328 | * ALC880 ASUS model | 1324 | * ALC880 ASUS model |
1329 | * | 1325 | * |
@@ -1360,7 +1356,6 @@ static struct snd_kcontrol_new alc880_asus_mixer[] = { | |||
1360 | { } /* end */ | 1356 | { } /* end */ |
1361 | }; | 1357 | }; |
1362 | 1358 | ||
1363 | /* FIXME! */ | ||
1364 | /* | 1359 | /* |
1365 | * ALC880 ASUS W1V model | 1360 | * ALC880 ASUS W1V model |
1366 | * | 1361 | * |
@@ -1398,7 +1393,6 @@ static struct snd_kcontrol_new alc880_tcl_s700_mixer[] = { | |||
1398 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 1393 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
1399 | /* The multiple "Capture Source" controls confuse alsamixer | 1394 | /* The multiple "Capture Source" controls confuse alsamixer |
1400 | * So call somewhat different.. | 1395 | * So call somewhat different.. |
1401 | * FIXME: the controls appear in the "playback" view! | ||
1402 | */ | 1396 | */ |
1403 | /* .name = "Capture Source", */ | 1397 | /* .name = "Capture Source", */ |
1404 | .name = "Input Source", | 1398 | .name = "Input Source", |
@@ -1912,7 +1906,6 @@ static void alc880_uniwill_p53_unsol_event(struct hda_codec *codec, | |||
1912 | alc880_uniwill_p53_dcvol_automute(codec); | 1906 | alc880_uniwill_p53_dcvol_automute(codec); |
1913 | } | 1907 | } |
1914 | 1908 | ||
1915 | /* FIXME! */ | ||
1916 | /* | 1909 | /* |
1917 | * F1734 pin configuration: | 1910 | * F1734 pin configuration: |
1918 | * HP = 0x14, speaker-out = 0x15, mic = 0x18 | 1911 | * HP = 0x14, speaker-out = 0x15, mic = 0x18 |
@@ -1941,7 +1934,6 @@ static struct hda_verb alc880_pin_f1734_init_verbs[] = { | |||
1941 | { } | 1934 | { } |
1942 | }; | 1935 | }; |
1943 | 1936 | ||
1944 | /* FIXME! */ | ||
1945 | /* | 1937 | /* |
1946 | * ASUS pin configuration: | 1938 | * ASUS pin configuration: |
1947 | * HP/front = 0x14, surr = 0x15, clfe = 0x16, mic = 0x18, line = 0x1a | 1939 | * HP/front = 0x14, surr = 0x15, clfe = 0x16, mic = 0x18, line = 0x1a |
@@ -2088,7 +2080,6 @@ static struct hda_channel_mode alc880_lg_ch_modes[3] = { | |||
2088 | }; | 2080 | }; |
2089 | 2081 | ||
2090 | static struct snd_kcontrol_new alc880_lg_mixer[] = { | 2082 | static struct snd_kcontrol_new alc880_lg_mixer[] = { |
2091 | /* FIXME: it's not really "master" but front channels */ | ||
2092 | HDA_CODEC_VOLUME("Front Playback Volume", 0x0f, 0x0, HDA_OUTPUT), | 2083 | HDA_CODEC_VOLUME("Front Playback Volume", 0x0f, 0x0, HDA_OUTPUT), |
2093 | HDA_BIND_MUTE("Front Playback Switch", 0x0f, 2, HDA_INPUT), | 2084 | HDA_BIND_MUTE("Front Playback Switch", 0x0f, 2, HDA_INPUT), |
2094 | HDA_CODEC_VOLUME("Surround Playback Volume", 0x0c, 0x0, HDA_OUTPUT), | 2085 | HDA_CODEC_VOLUME("Surround Playback Volume", 0x0c, 0x0, HDA_OUTPUT), |
@@ -3926,7 +3917,6 @@ static struct snd_kcontrol_new alc260_capture_mixer[] = { | |||
3926 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 3917 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
3927 | /* The multiple "Capture Source" controls confuse alsamixer | 3918 | /* The multiple "Capture Source" controls confuse alsamixer |
3928 | * So call somewhat different.. | 3919 | * So call somewhat different.. |
3929 | * FIXME: the controls appear in the "playback" view! | ||
3930 | */ | 3920 | */ |
3931 | /* .name = "Capture Source", */ | 3921 | /* .name = "Capture Source", */ |
3932 | .name = "Input Source", | 3922 | .name = "Input Source", |
@@ -3945,7 +3935,6 @@ static struct snd_kcontrol_new alc260_capture_alt_mixer[] = { | |||
3945 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 3935 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
3946 | /* The multiple "Capture Source" controls confuse alsamixer | 3936 | /* The multiple "Capture Source" controls confuse alsamixer |
3947 | * So call somewhat different.. | 3937 | * So call somewhat different.. |
3948 | * FIXME: the controls appear in the "playback" view! | ||
3949 | */ | 3938 | */ |
3950 | /* .name = "Capture Source", */ | 3939 | /* .name = "Capture Source", */ |
3951 | .name = "Input Source", | 3940 | .name = "Input Source", |
@@ -5801,7 +5790,6 @@ static struct snd_kcontrol_new alc882_capture_alt_mixer[] = { | |||
5801 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 5790 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
5802 | /* The multiple "Capture Source" controls confuse alsamixer | 5791 | /* The multiple "Capture Source" controls confuse alsamixer |
5803 | * So call somewhat different.. | 5792 | * So call somewhat different.. |
5804 | * FIXME: the controls appear in the "playback" view! | ||
5805 | */ | 5793 | */ |
5806 | /* .name = "Capture Source", */ | 5794 | /* .name = "Capture Source", */ |
5807 | .name = "Input Source", | 5795 | .name = "Input Source", |
@@ -5824,7 +5812,6 @@ static struct snd_kcontrol_new alc882_capture_mixer[] = { | |||
5824 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 5812 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
5825 | /* The multiple "Capture Source" controls confuse alsamixer | 5813 | /* The multiple "Capture Source" controls confuse alsamixer |
5826 | * So call somewhat different.. | 5814 | * So call somewhat different.. |
5827 | * FIXME: the controls appear in the "playback" view! | ||
5828 | */ | 5815 | */ |
5829 | /* .name = "Capture Source", */ | 5816 | /* .name = "Capture Source", */ |
5830 | .name = "Input Source", | 5817 | .name = "Input Source", |
@@ -7403,7 +7390,6 @@ static struct snd_kcontrol_new alc883_capture_mixer[] = { | |||
7403 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 7390 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
7404 | /* The multiple "Capture Source" controls confuse alsamixer | 7391 | /* The multiple "Capture Source" controls confuse alsamixer |
7405 | * So call somewhat different.. | 7392 | * So call somewhat different.. |
7406 | * FIXME: the controls appear in the "playback" view! | ||
7407 | */ | 7393 | */ |
7408 | /* .name = "Capture Source", */ | 7394 | /* .name = "Capture Source", */ |
7409 | .name = "Input Source", | 7395 | .name = "Input Source", |
@@ -9548,7 +9534,6 @@ static struct snd_kcontrol_new alc268_capture_alt_mixer[] = { | |||
9548 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 9534 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
9549 | /* The multiple "Capture Source" controls confuse alsamixer | 9535 | /* The multiple "Capture Source" controls confuse alsamixer |
9550 | * So call somewhat different.. | 9536 | * So call somewhat different.. |
9551 | * FIXME: the controls appear in the "playback" view! | ||
9552 | */ | 9537 | */ |
9553 | /* .name = "Capture Source", */ | 9538 | /* .name = "Capture Source", */ |
9554 | .name = "Input Source", | 9539 | .name = "Input Source", |
@@ -9569,7 +9554,6 @@ static struct snd_kcontrol_new alc268_capture_mixer[] = { | |||
9569 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 9554 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
9570 | /* The multiple "Capture Source" controls confuse alsamixer | 9555 | /* The multiple "Capture Source" controls confuse alsamixer |
9571 | * So call somewhat different.. | 9556 | * So call somewhat different.. |
9572 | * FIXME: the controls appear in the "playback" view! | ||
9573 | */ | 9557 | */ |
9574 | /* .name = "Capture Source", */ | 9558 | /* .name = "Capture Source", */ |
9575 | .name = "Input Source", | 9559 | .name = "Input Source", |
@@ -10055,7 +10039,6 @@ static struct snd_kcontrol_new alc269_capture_mixer[] = { | |||
10055 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 10039 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
10056 | /* The multiple "Capture Source" controls confuse alsamixer | 10040 | /* The multiple "Capture Source" controls confuse alsamixer |
10057 | * So call somewhat different.. | 10041 | * So call somewhat different.. |
10058 | * FIXME: the controls appear in the "playback" view! | ||
10059 | */ | 10042 | */ |
10060 | /* .name = "Capture Source", */ | 10043 | /* .name = "Capture Source", */ |
10061 | .name = "Input Source", | 10044 | .name = "Input Source", |
@@ -11188,7 +11171,6 @@ static struct snd_kcontrol_new alc861_capture_mixer[] = { | |||
11188 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 11171 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
11189 | /* The multiple "Capture Source" controls confuse alsamixer | 11172 | /* The multiple "Capture Source" controls confuse alsamixer |
11190 | * So call somewhat different.. | 11173 | * So call somewhat different.. |
11191 | *FIXME: the controls appear in the "playback" view! | ||
11192 | */ | 11174 | */ |
11193 | /* .name = "Capture Source", */ | 11175 | /* .name = "Capture Source", */ |
11194 | .name = "Input Source", | 11176 | .name = "Input Source", |
@@ -11675,7 +11657,6 @@ static struct snd_kcontrol_new alc861vd_capture_mixer[] = { | |||
11675 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 11657 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
11676 | /* The multiple "Capture Source" controls confuse alsamixer | 11658 | /* The multiple "Capture Source" controls confuse alsamixer |
11677 | * So call somewhat different.. | 11659 | * So call somewhat different.. |
11678 | *FIXME: the controls appear in the "playback" view! | ||
11679 | */ | 11660 | */ |
11680 | /* .name = "Capture Source", */ | 11661 | /* .name = "Capture Source", */ |
11681 | .name = "Input Source", | 11662 | .name = "Input Source", |
@@ -12916,7 +12897,6 @@ static struct snd_kcontrol_new alc662_capture_mixer[] = { | |||
12916 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 12897 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
12917 | /* The multiple "Capture Source" controls confuse alsamixer | 12898 | /* The multiple "Capture Source" controls confuse alsamixer |
12918 | * So call somewhat different.. | 12899 | * So call somewhat different.. |
12919 | * FIXME: the controls appear in the "playback" view! | ||
12920 | */ | 12900 | */ |
12921 | /* .name = "Capture Source", */ | 12901 | /* .name = "Capture Source", */ |
12922 | .name = "Input Source", | 12902 | .name = "Input Source", |
diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c index 423b4999ee4a..d4dc5596c946 100644 --- a/sound/pci/hda/patch_via.c +++ b/sound/pci/hda/patch_via.c | |||
@@ -306,7 +306,6 @@ static struct snd_kcontrol_new vt1708_capture_mixer[] = { | |||
306 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 306 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
307 | /* The multiple "Capture Source" controls confuse alsamixer | 307 | /* The multiple "Capture Source" controls confuse alsamixer |
308 | * So call somewhat different.. | 308 | * So call somewhat different.. |
309 | * FIXME: the controls appear in the "playback" view! | ||
310 | */ | 309 | */ |
311 | /* .name = "Capture Source", */ | 310 | /* .name = "Capture Source", */ |
312 | .name = "Input Source", | 311 | .name = "Input Source", |
@@ -928,7 +927,6 @@ static struct snd_kcontrol_new vt1709_capture_mixer[] = { | |||
928 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 927 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
929 | /* The multiple "Capture Source" controls confuse alsamixer | 928 | /* The multiple "Capture Source" controls confuse alsamixer |
930 | * So call somewhat different.. | 929 | * So call somewhat different.. |
931 | * FIXME: the controls appear in the "playback" view! | ||
932 | */ | 930 | */ |
933 | /* .name = "Capture Source", */ | 931 | /* .name = "Capture Source", */ |
934 | .name = "Input Source", | 932 | .name = "Input Source", |
@@ -1477,7 +1475,6 @@ static struct snd_kcontrol_new vt1708B_capture_mixer[] = { | |||
1477 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, | 1475 | .iface = SNDRV_CTL_ELEM_IFACE_MIXER, |
1478 | /* The multiple "Capture Source" controls confuse alsamixer | 1476 | /* The multiple "Capture Source" controls confuse alsamixer |
1479 | * So call somewhat different.. | 1477 | * So call somewhat different.. |
1480 | * FIXME: the controls appear in the "playback" view! | ||
1481 | */ | 1478 | */ |
1482 | /* .name = "Capture Source", */ | 1479 | /* .name = "Capture Source", */ |
1483 | .name = "Input Source", | 1480 | .name = "Input Source", |