ALSA: hda - Move the call of snd_hda_parse_pin_defcfg() from snd_hda_gen_parse_auto_config()

In some cases, we want to manipulate the auto_pin_cfg table before
passing to snd_hda_gen_parse_auto_config() (e.g. Realtek SSID check
code fiddles with the headphone pin).   Also passing ignore_pins just
for snd_hda_parse_pin_defcfg() isn't good.

In this patch, snd_hda_gen_parse_auto_config() is changed to receive
the auto_pin_cfg table to be parsed.  The passed auto_pin_cfg table
must have been initialized (typically by calling
snd_hda_gen_parse_auto_config()) beforehand by the caller.

Also together with this change, spec->parse_flags is also removed.
Since this was referred only at the place calling
snd_hda_parse_pin_defcfg(), no longer needed to be kept in spec.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

1 files changed, 15 insertions, 9 deletions

diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c
index 49e968c8140b..e512cab22e91 100644
--- a/sound/pci/hda/hda_generic.c
+++ b/sound/pci/hda/hda_generic.c
@@ -2785,21 +2785,23 @@ static int check_auto_mic_availability(struct hda_codec *codec)
 }
 
 
-/* parse the BIOS configuration and set up the hda_gen_spec */
-/* return 1 if successful, 0 if the proper config is not found,
+/*
+ * Parse the given BIOS configuration and set up the hda_gen_spec
+ *
+ * return 1 if successful, 0 if the proper config is not found,
  * or a negative error code
  */
 int snd_hda_gen_parse_auto_config(struct hda_codec *codec,
-                                  const hda_nid_t *ignore_nids)
+                                  struct auto_pin_cfg *cfg)
 {
         struct hda_gen_spec *spec = codec->spec;
-        struct auto_pin_cfg *cfg = &spec->autocfg;
         int err;
 
-        err = snd_hda_parse_pin_defcfg(codec, cfg, ignore_nids,
-                                       spec->parse_flags);
-        if (err < 0)
-                return err;
+        if (cfg != &spec->autocfg) {
+                spec->autocfg = *cfg;
+                cfg = &spec->autocfg;
+        }
+
         if (!cfg->line_outs) {
                 if (cfg->dig_outs || cfg->dig_in_pin) {
                         spec->multiout.max_channels = 2;
@@ -3586,7 +3588,11 @@ int snd_hda_parse_generic_codec(struct hda_codec *codec)
         snd_hda_gen_spec_init(spec);
         codec->spec = spec;
 
-        err = snd_hda_gen_parse_auto_config(codec, NULL);
+        err = snd_hda_parse_pin_defcfg(codec, &spec->autocfg, NULL, 0);
+        if (err < 0)
+                return err;
+
+        err = snd_hda_gen_parse_auto_config(codec, &spec->autocfg);
         if (err < 0)
                 goto error;