diff options
author | Adrian Bunk <bunk@stusta.de> | 2006-03-14 03:44:19 -0500 |
---|---|---|
committer | Jaroslav Kysela <perex@suse.cz> | 2006-03-22 04:38:23 -0500 |
commit | 202728d783a0fc180e7141d18186eeae167218a1 (patch) | |
tree | d24ca9a920cd92247b2f52f6512a73c317e545fb /sound/pci/cs46xx | |
parent | 3e964432f56f05a8ef639902796e476456b230ad (diff) |
[ALSA] fix some memory leaks
Modules: Generic drivers,ES18xx driver,CS46xx driver
This patch fixes two memory leaks spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/cs46xx')
-rw-r--r-- | sound/pci/cs46xx/dsp_spos.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/sound/pci/cs46xx/dsp_spos.c b/sound/pci/cs46xx/dsp_spos.c index 8726a68051e7..f407d2a5ce3b 100644 --- a/sound/pci/cs46xx/dsp_spos.c +++ b/sound/pci/cs46xx/dsp_spos.c | |||
@@ -237,7 +237,7 @@ struct dsp_spos_instance *cs46xx_dsp_spos_create (struct snd_cs46xx * chip) | |||
237 | 237 | ||
238 | if (ins->symbol_table.symbols == NULL) { | 238 | if (ins->symbol_table.symbols == NULL) { |
239 | cs46xx_dsp_spos_destroy(chip); | 239 | cs46xx_dsp_spos_destroy(chip); |
240 | return NULL; | 240 | goto error; |
241 | } | 241 | } |
242 | 242 | ||
243 | ins->code.offset = 0; | 243 | ins->code.offset = 0; |
@@ -246,7 +246,7 @@ struct dsp_spos_instance *cs46xx_dsp_spos_create (struct snd_cs46xx * chip) | |||
246 | 246 | ||
247 | if (ins->code.data == NULL) { | 247 | if (ins->code.data == NULL) { |
248 | cs46xx_dsp_spos_destroy(chip); | 248 | cs46xx_dsp_spos_destroy(chip); |
249 | return NULL; | 249 | goto error; |
250 | } | 250 | } |
251 | 251 | ||
252 | ins->nscb = 0; | 252 | ins->nscb = 0; |
@@ -257,7 +257,7 @@ struct dsp_spos_instance *cs46xx_dsp_spos_create (struct snd_cs46xx * chip) | |||
257 | 257 | ||
258 | if (ins->modules == NULL) { | 258 | if (ins->modules == NULL) { |
259 | cs46xx_dsp_spos_destroy(chip); | 259 | cs46xx_dsp_spos_destroy(chip); |
260 | return NULL; | 260 | goto error; |
261 | } | 261 | } |
262 | 262 | ||
263 | /* default SPDIF input sample rate | 263 | /* default SPDIF input sample rate |
@@ -280,6 +280,10 @@ struct dsp_spos_instance *cs46xx_dsp_spos_create (struct snd_cs46xx * chip) | |||
280 | /* left and right validity bits */ (1 << 13) | (1 << 12); | 280 | /* left and right validity bits */ (1 << 13) | (1 << 12); |
281 | 281 | ||
282 | return ins; | 282 | return ins; |
283 | |||
284 | error: | ||
285 | kfree(ins); | ||
286 | return NULL; | ||
283 | } | 287 | } |
284 | 288 | ||
285 | void cs46xx_dsp_spos_destroy (struct snd_cs46xx * chip) | 289 | void cs46xx_dsp_spos_destroy (struct snd_cs46xx * chip) |