diff options
author | Takashi Iwai <tiwai@suse.de> | 2014-02-25 09:54:30 -0500 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2014-02-26 10:45:24 -0500 |
commit | 179bb7f16abdcca6cfb18d34de2e209947c893e5 (patch) | |
tree | 49785986addaa101eb5d30b85feb5e0417ead4ed /sound/pci/aw2 | |
parent | 5f1e69373172100d1a9be7ea36cad0a8d8081b7c (diff) |
ALSA: aw2: Use standard printk helpers
Convert with dev_err() and co from snd_printk(), etc.
A couple of prints are difficult to convert with dev_err() so they are
converted to pr_err() at least.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/aw2')
-rw-r--r-- | sound/pci/aw2/aw2-alsa.c | 42 | ||||
-rw-r--r-- | sound/pci/aw2/aw2-saa7146.c | 6 |
2 files changed, 22 insertions, 26 deletions
diff --git a/sound/pci/aw2/aw2-alsa.c b/sound/pci/aw2/aw2-alsa.c index e9dabee42805..120d0d320a60 100644 --- a/sound/pci/aw2/aw2-alsa.c +++ b/sound/pci/aw2/aw2-alsa.c | |||
@@ -262,7 +262,7 @@ static int snd_aw2_create(struct snd_card *card, | |||
262 | /* check PCI availability (32bit DMA) */ | 262 | /* check PCI availability (32bit DMA) */ |
263 | if ((pci_set_dma_mask(pci, DMA_BIT_MASK(32)) < 0) || | 263 | if ((pci_set_dma_mask(pci, DMA_BIT_MASK(32)) < 0) || |
264 | (pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(32)) < 0)) { | 264 | (pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(32)) < 0)) { |
265 | printk(KERN_ERR "aw2: Impossible to set 32bit mask DMA\n"); | 265 | dev_err(card->dev, "Impossible to set 32bit mask DMA\n"); |
266 | pci_disable_device(pci); | 266 | pci_disable_device(pci); |
267 | return -ENXIO; | 267 | return -ENXIO; |
268 | } | 268 | } |
@@ -290,7 +290,7 @@ static int snd_aw2_create(struct snd_card *card, | |||
290 | pci_resource_len(pci, 0)); | 290 | pci_resource_len(pci, 0)); |
291 | 291 | ||
292 | if (chip->iobase_virt == NULL) { | 292 | if (chip->iobase_virt == NULL) { |
293 | printk(KERN_ERR "aw2: unable to remap memory region"); | 293 | dev_err(card->dev, "unable to remap memory region"); |
294 | pci_release_regions(pci); | 294 | pci_release_regions(pci); |
295 | pci_disable_device(pci); | 295 | pci_disable_device(pci); |
296 | kfree(chip); | 296 | kfree(chip); |
@@ -302,7 +302,7 @@ static int snd_aw2_create(struct snd_card *card, | |||
302 | 302 | ||
303 | if (request_irq(pci->irq, snd_aw2_saa7146_interrupt, | 303 | if (request_irq(pci->irq, snd_aw2_saa7146_interrupt, |
304 | IRQF_SHARED, KBUILD_MODNAME, chip)) { | 304 | IRQF_SHARED, KBUILD_MODNAME, chip)) { |
305 | printk(KERN_ERR "aw2: Cannot grab irq %d\n", pci->irq); | 305 | dev_err(card->dev, "Cannot grab irq %d\n", pci->irq); |
306 | 306 | ||
307 | iounmap(chip->iobase_virt); | 307 | iounmap(chip->iobase_virt); |
308 | pci_release_regions(chip->pci); | 308 | pci_release_regions(chip->pci); |
@@ -324,9 +324,8 @@ static int snd_aw2_create(struct snd_card *card, | |||
324 | 324 | ||
325 | *rchip = chip; | 325 | *rchip = chip; |
326 | 326 | ||
327 | printk(KERN_INFO | 327 | dev_info(card->dev, |
328 | "Audiowerk 2 sound card (saa7146 chipset) detected and " | 328 | "Audiowerk 2 sound card (saa7146 chipset) detected and managed\n"); |
329 | "managed\n"); | ||
330 | return 0; | 329 | return 0; |
331 | } | 330 | } |
332 | 331 | ||
@@ -399,7 +398,7 @@ static int snd_aw2_pcm_playback_open(struct snd_pcm_substream *substream) | |||
399 | { | 398 | { |
400 | struct snd_pcm_runtime *runtime = substream->runtime; | 399 | struct snd_pcm_runtime *runtime = substream->runtime; |
401 | 400 | ||
402 | snd_printdd(KERN_DEBUG "aw2: Playback_open\n"); | 401 | dev_dbg(substream->pcm->card->dev, "Playback_open\n"); |
403 | runtime->hw = snd_aw2_playback_hw; | 402 | runtime->hw = snd_aw2_playback_hw; |
404 | return 0; | 403 | return 0; |
405 | } | 404 | } |
@@ -415,7 +414,7 @@ static int snd_aw2_pcm_capture_open(struct snd_pcm_substream *substream) | |||
415 | { | 414 | { |
416 | struct snd_pcm_runtime *runtime = substream->runtime; | 415 | struct snd_pcm_runtime *runtime = substream->runtime; |
417 | 416 | ||
418 | snd_printdd(KERN_DEBUG "aw2: Capture_open\n"); | 417 | dev_dbg(substream->pcm->card->dev, "Capture_open\n"); |
419 | runtime->hw = snd_aw2_capture_hw; | 418 | runtime->hw = snd_aw2_capture_hw; |
420 | return 0; | 419 | return 0; |
421 | } | 420 | } |
@@ -603,7 +602,7 @@ static int snd_aw2_new_pcm(struct aw2 *chip) | |||
603 | err = snd_pcm_new(chip->card, "Audiowerk2 analog playback", 0, 1, 0, | 602 | err = snd_pcm_new(chip->card, "Audiowerk2 analog playback", 0, 1, 0, |
604 | &pcm_playback_ana); | 603 | &pcm_playback_ana); |
605 | if (err < 0) { | 604 | if (err < 0) { |
606 | printk(KERN_ERR "aw2: snd_pcm_new error (0x%X)\n", err); | 605 | dev_err(chip->card->dev, "snd_pcm_new error (0x%X)\n", err); |
607 | return err; | 606 | return err; |
608 | } | 607 | } |
609 | 608 | ||
@@ -633,14 +632,15 @@ static int snd_aw2_new_pcm(struct aw2 *chip) | |||
633 | (chip->pci), | 632 | (chip->pci), |
634 | 64 * 1024, 64 * 1024); | 633 | 64 * 1024, 64 * 1024); |
635 | if (err) | 634 | if (err) |
636 | printk(KERN_ERR "aw2: snd_pcm_lib_preallocate_pages_for_all " | 635 | dev_err(chip->card->dev, |
637 | "error (0x%X)\n", err); | 636 | "snd_pcm_lib_preallocate_pages_for_all error (0x%X)\n", |
637 | err); | ||
638 | 638 | ||
639 | err = snd_pcm_new(chip->card, "Audiowerk2 digital playback", 1, 1, 0, | 639 | err = snd_pcm_new(chip->card, "Audiowerk2 digital playback", 1, 1, 0, |
640 | &pcm_playback_num); | 640 | &pcm_playback_num); |
641 | 641 | ||
642 | if (err < 0) { | 642 | if (err < 0) { |
643 | printk(KERN_ERR "aw2: snd_pcm_new error (0x%X)\n", err); | 643 | dev_err(chip->card->dev, "snd_pcm_new error (0x%X)\n", err); |
644 | return err; | 644 | return err; |
645 | } | 645 | } |
646 | /* Creation ok */ | 646 | /* Creation ok */ |
@@ -669,17 +669,15 @@ static int snd_aw2_new_pcm(struct aw2 *chip) | |||
669 | (chip->pci), | 669 | (chip->pci), |
670 | 64 * 1024, 64 * 1024); | 670 | 64 * 1024, 64 * 1024); |
671 | if (err) | 671 | if (err) |
672 | printk(KERN_ERR | 672 | dev_err(chip->card->dev, |
673 | "aw2: snd_pcm_lib_preallocate_pages_for_all error " | 673 | "snd_pcm_lib_preallocate_pages_for_all error (0x%X)\n", |
674 | "(0x%X)\n", err); | 674 | err); |
675 | |||
676 | |||
677 | 675 | ||
678 | err = snd_pcm_new(chip->card, "Audiowerk2 capture", 2, 0, 1, | 676 | err = snd_pcm_new(chip->card, "Audiowerk2 capture", 2, 0, 1, |
679 | &pcm_capture); | 677 | &pcm_capture); |
680 | 678 | ||
681 | if (err < 0) { | 679 | if (err < 0) { |
682 | printk(KERN_ERR "aw2: snd_pcm_new error (0x%X)\n", err); | 680 | dev_err(chip->card->dev, "snd_pcm_new error (0x%X)\n", err); |
683 | return err; | 681 | return err; |
684 | } | 682 | } |
685 | 683 | ||
@@ -709,15 +707,15 @@ static int snd_aw2_new_pcm(struct aw2 *chip) | |||
709 | (chip->pci), | 707 | (chip->pci), |
710 | 64 * 1024, 64 * 1024); | 708 | 64 * 1024, 64 * 1024); |
711 | if (err) | 709 | if (err) |
712 | printk(KERN_ERR | 710 | dev_err(chip->card->dev, |
713 | "aw2: snd_pcm_lib_preallocate_pages_for_all error " | 711 | "snd_pcm_lib_preallocate_pages_for_all error (0x%X)\n", |
714 | "(0x%X)\n", err); | 712 | err); |
715 | 713 | ||
716 | 714 | ||
717 | /* Create control */ | 715 | /* Create control */ |
718 | err = snd_ctl_add(chip->card, snd_ctl_new1(&aw2_control, chip)); | 716 | err = snd_ctl_add(chip->card, snd_ctl_new1(&aw2_control, chip)); |
719 | if (err < 0) { | 717 | if (err < 0) { |
720 | printk(KERN_ERR "aw2: snd_ctl_add error (0x%X)\n", err); | 718 | dev_err(chip->card->dev, "snd_ctl_add error (0x%X)\n", err); |
721 | return err; | 719 | return err; |
722 | } | 720 | } |
723 | 721 | ||
diff --git a/sound/pci/aw2/aw2-saa7146.c b/sound/pci/aw2/aw2-saa7146.c index 4439636971eb..6d24e9536777 100644 --- a/sound/pci/aw2/aw2-saa7146.c +++ b/sound/pci/aw2/aw2-saa7146.c | |||
@@ -204,8 +204,7 @@ void snd_aw2_saa7146_pcm_init_playback(struct snd_aw2_saa7146 *chip, | |||
204 | /* Define upper limit for DMA access */ | 204 | /* Define upper limit for DMA access */ |
205 | WRITEREG(dma_addr + buffer_size, ProtA1_out); | 205 | WRITEREG(dma_addr + buffer_size, ProtA1_out); |
206 | } else { | 206 | } else { |
207 | printk(KERN_ERR | 207 | pr_err("aw2: snd_aw2_saa7146_pcm_init_playback: " |
208 | "aw2: snd_aw2_saa7146_pcm_init_playback: " | ||
209 | "Substream number is not 0 or 1 -> not managed\n"); | 208 | "Substream number is not 0 or 1 -> not managed\n"); |
210 | } | 209 | } |
211 | } | 210 | } |
@@ -251,8 +250,7 @@ void snd_aw2_saa7146_pcm_init_capture(struct snd_aw2_saa7146 *chip, | |||
251 | /* Define upper limit for DMA access */ | 250 | /* Define upper limit for DMA access */ |
252 | WRITEREG(dma_addr + buffer_size, ProtA1_in); | 251 | WRITEREG(dma_addr + buffer_size, ProtA1_in); |
253 | } else { | 252 | } else { |
254 | printk(KERN_ERR | 253 | pr_err("aw2: snd_aw2_saa7146_pcm_init_capture: " |
255 | "aw2: snd_aw2_saa7146_pcm_init_capture: " | ||
256 | "Substream number is not 0 -> not managed\n"); | 254 | "Substream number is not 0 -> not managed\n"); |
257 | } | 255 | } |
258 | } | 256 | } |