diff options
| author | Jesper Juhl <juhl-lkml@dif.dk> | 2005-05-30 11:30:32 -0400 |
|---|---|---|
| committer | Jaroslav Kysela <perex@suse.cz> | 2005-06-22 06:27:43 -0400 |
| commit | 4d572776d4dfa2d5385a2ec3acec3cc059149e13 (patch) | |
| tree | b25ff1baa8d106561d9f07045bbfea6ac330c714 /sound/isa | |
| parent | 6fd8b87f0e1e5de436ba020bd5806fe9ad738269 (diff) | |
[ALSA] Remove redundant NULL checks before kfree
Timer Midlevel,ALSA sequencer,ALSA<-OSS sequencer,Digigram VX core
I2C tea6330t,GUS Library,VIA82xx driver,VIA82xx-modem driver
CA0106 driver,CS46xx driver,EMU10K1/EMU10K2 driver,YMFPCI driver
Digigram VX Pocket driver,Common EMU synth,USB generic driver,USB USX2Y
Checking a pointer for NULL before calling kfree() on it is redundant,
kfree() deals with NULL pointers just fine.
This patch removes such checks from sound/
This patch also makes another, but closely related, change.
It avoids casting pointers about to be kfree()'ed.
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/isa')
| -rw-r--r-- | sound/isa/gus/gus_pcm.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/isa/gus/gus_pcm.c b/sound/isa/gus/gus_pcm.c index 8995ad9c516d..b75066ab46fc 100644 --- a/sound/isa/gus/gus_pcm.c +++ b/sound/isa/gus/gus_pcm.c | |||
| @@ -656,8 +656,7 @@ static snd_pcm_hardware_t snd_gf1_pcm_capture = | |||
| 656 | 656 | ||
| 657 | static void snd_gf1_pcm_playback_free(snd_pcm_runtime_t *runtime) | 657 | static void snd_gf1_pcm_playback_free(snd_pcm_runtime_t *runtime) |
| 658 | { | 658 | { |
| 659 | gus_pcm_private_t * pcmp = runtime->private_data; | 659 | kfree(runtime->private_data); |
| 660 | kfree(pcmp); | ||
| 661 | } | 660 | } |
| 662 | 661 | ||
| 663 | static int snd_gf1_pcm_playback_open(snd_pcm_substream_t *substream) | 662 | static int snd_gf1_pcm_playback_open(snd_pcm_substream_t *substream) |