diff options
author | David Howells <dhowells@redhat.com> | 2006-10-05 09:55:46 -0400 |
---|---|---|
committer | David Howells <dhowells@warthog.cambridge.redhat.com> | 2006-10-05 10:10:12 -0400 |
commit | 7d12e780e003f93433d49ce78cfedf4b4c52adc5 (patch) | |
tree | 6748550400445c11a306b132009f3001e3525df8 /sound/isa/sb | |
parent | da482792a6d1a3fbaaa25fae867b343fb4db3246 (diff) |
IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
of passing regs around manually through all ~1800 interrupt handlers in the
Linux kernel.
The regs pointer is used in few places, but it potentially costs both stack
space and code to pass it around. On the FRV arch, removing the regs parameter
from all the genirq function results in a 20% speed up of the IRQ exit path
(ie: from leaving timer_interrupt() to leaving do_IRQ()).
Where appropriate, an arch may override the generic storage facility and do
something different with the variable. On FRV, for instance, the address is
maintained in GR28 at all times inside the kernel as part of general exception
handling.
Having looked over the code, it appears that the parameter may be handed down
through up to twenty or so layers of functions. Consider a USB character
device attached to a USB hub, attached to a USB controller that posts its
interrupts through a cascaded auxiliary interrupt controller. A character
device driver may want to pass regs to the sysrq handler through the input
layer which adds another few layers of parameter passing.
I've build this code with allyesconfig for x86_64 and i386. I've runtested the
main part of the code on FRV and i386, though I can't test most of the drivers.
I've also done partial conversion for powerpc and MIPS - these at least compile
with minimal configurations.
This will affect all archs. Mostly the changes should be relatively easy.
Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
struct pt_regs *old_regs = set_irq_regs(regs);
And put the old one back at the end:
set_irq_regs(old_regs);
Don't pass regs through to generic_handle_irq() or __do_IRQ().
In timer_interrupt(), this sort of change will be necessary:
- update_process_times(user_mode(regs));
- profile_tick(CPU_PROFILING, regs);
+ update_process_times(user_mode(get_irq_regs()));
+ profile_tick(CPU_PROFILING);
I'd like to move update_process_times()'s use of get_irq_regs() into itself,
except that i386, alone of the archs, uses something other than user_mode().
Some notes on the interrupt handling in the drivers:
(*) input_dev() is now gone entirely. The regs pointer is no longer stored in
the input_dev struct.
(*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
something different depending on whether it's been supplied with a regs
pointer or not.
(*) Various IRQ handler function pointers have been moved to type
irq_handler_t.
Signed-Off-By: David Howells <dhowells@redhat.com>
(cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
Diffstat (limited to 'sound/isa/sb')
-rw-r--r-- | sound/isa/sb/es968.c | 3 | ||||
-rw-r--r-- | sound/isa/sb/sb16_main.c | 4 | ||||
-rw-r--r-- | sound/isa/sb/sb8.c | 2 | ||||
-rw-r--r-- | sound/isa/sb/sb_common.c | 2 |
4 files changed, 5 insertions, 6 deletions
diff --git a/sound/isa/sb/es968.c b/sound/isa/sb/es968.c index d4d65b84265a..d4b218726ce7 100644 --- a/sound/isa/sb/es968.c +++ b/sound/isa/sb/es968.c | |||
@@ -70,8 +70,7 @@ MODULE_DEVICE_TABLE(pnp_card, snd_es968_pnpids); | |||
70 | 70 | ||
71 | #define DRIVER_NAME "snd-card-es968" | 71 | #define DRIVER_NAME "snd-card-es968" |
72 | 72 | ||
73 | static irqreturn_t snd_card_es968_interrupt(int irq, void *dev_id, | 73 | static irqreturn_t snd_card_es968_interrupt(int irq, void *dev_id) |
74 | struct pt_regs *regs) | ||
75 | { | 74 | { |
76 | struct snd_sb *chip = dev_id; | 75 | struct snd_sb *chip = dev_id; |
77 | 76 | ||
diff --git a/sound/isa/sb/sb16_main.c b/sound/isa/sb/sb16_main.c index f183f1845a36..383911b9e74d 100644 --- a/sound/isa/sb/sb16_main.c +++ b/sound/isa/sb/sb16_main.c | |||
@@ -395,7 +395,7 @@ static int snd_sb16_capture_trigger(struct snd_pcm_substream *substream, | |||
395 | return result; | 395 | return result; |
396 | } | 396 | } |
397 | 397 | ||
398 | irqreturn_t snd_sb16dsp_interrupt(int irq, void *dev_id, struct pt_regs *regs) | 398 | irqreturn_t snd_sb16dsp_interrupt(int irq, void *dev_id) |
399 | { | 399 | { |
400 | struct snd_sb *chip = dev_id; | 400 | struct snd_sb *chip = dev_id; |
401 | unsigned char status; | 401 | unsigned char status; |
@@ -405,7 +405,7 @@ irqreturn_t snd_sb16dsp_interrupt(int irq, void *dev_id, struct pt_regs *regs) | |||
405 | status = snd_sbmixer_read(chip, SB_DSP4_IRQSTATUS); | 405 | status = snd_sbmixer_read(chip, SB_DSP4_IRQSTATUS); |
406 | spin_unlock(&chip->mixer_lock); | 406 | spin_unlock(&chip->mixer_lock); |
407 | if ((status & SB_IRQTYPE_MPUIN) && chip->rmidi_callback) | 407 | if ((status & SB_IRQTYPE_MPUIN) && chip->rmidi_callback) |
408 | chip->rmidi_callback(irq, chip->rmidi->private_data, regs); | 408 | chip->rmidi_callback(irq, chip->rmidi->private_data); |
409 | if (status & SB_IRQTYPE_8BIT) { | 409 | if (status & SB_IRQTYPE_8BIT) { |
410 | ok = 0; | 410 | ok = 0; |
411 | if (chip->mode & SB_MODE_PLAYBACK_8) { | 411 | if (chip->mode & SB_MODE_PLAYBACK_8) { |
diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c index 141400c01426..268ebd34703e 100644 --- a/sound/isa/sb/sb8.c +++ b/sound/isa/sb/sb8.c | |||
@@ -63,7 +63,7 @@ struct snd_sb8 { | |||
63 | struct snd_sb *chip; | 63 | struct snd_sb *chip; |
64 | }; | 64 | }; |
65 | 65 | ||
66 | static irqreturn_t snd_sb8_interrupt(int irq, void *dev_id, struct pt_regs *regs) | 66 | static irqreturn_t snd_sb8_interrupt(int irq, void *dev_id) |
67 | { | 67 | { |
68 | struct snd_sb *chip = dev_id; | 68 | struct snd_sb *chip = dev_id; |
69 | 69 | ||
diff --git a/sound/isa/sb/sb_common.c b/sound/isa/sb/sb_common.c index f17de2bdd9e0..c62a9e3d2ae4 100644 --- a/sound/isa/sb/sb_common.c +++ b/sound/isa/sb/sb_common.c | |||
@@ -205,7 +205,7 @@ static int snd_sbdsp_dev_free(struct snd_device *device) | |||
205 | int snd_sbdsp_create(struct snd_card *card, | 205 | int snd_sbdsp_create(struct snd_card *card, |
206 | unsigned long port, | 206 | unsigned long port, |
207 | int irq, | 207 | int irq, |
208 | irqreturn_t (*irq_handler)(int, void *, struct pt_regs *), | 208 | irq_handler_t irq_handler, |
209 | int dma8, | 209 | int dma8, |
210 | int dma16, | 210 | int dma16, |
211 | unsigned short hardware, | 211 | unsigned short hardware, |