[ALSA] Remove redundant NULL checks before kfree

Timer Midlevel,ALSA sequencer,ALSA<-OSS sequencer,Digigram VX core
I2C tea6330t,GUS Library,VIA82xx driver,VIA82xx-modem driver
CA0106 driver,CS46xx driver,EMU10K1/EMU10K2 driver,YMFPCI driver
Digigram VX Pocket driver,Common EMU synth,USB generic driver,USB USX2Y
Checking a pointer for NULL before calling kfree() on it is redundant,
kfree() deals with NULL pointers just fine.
This patch removes such checks from sound/

This patch also makes another, but closely related, change.
It avoids casting pointers about to be kfree()'ed.

Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

1 files changed, 4 insertions, 8 deletions

diff --git a/sound/drivers/vx/vx_pcm.c b/sound/drivers/vx/vx_pcm.c
index 98587176b327..af381b15fe5c 100644
--- a/sound/drivers/vx/vx_pcm.c
+++ b/sound/drivers/vx/vx_pcm.c
@@ -1264,14 +1264,10 @@ static void snd_vx_pcm_free(snd_pcm_t *pcm)
 {
         vx_core_t *chip = pcm->private_data;
         chip->pcm[pcm->device] = NULL;
-        if (chip->playback_pipes) {
-                kfree(chip->playback_pipes);
-                chip->playback_pipes = NULL;
-        }
-        if (chip->capture_pipes) {
-                kfree(chip->capture_pipes);
-                chip->capture_pipes = NULL;
-        }
+        kfree(chip->playback_pipes);
+        chip->playback_pipes = NULL;
+        kfree(chip->capture_pipes);
+        chip->capture_pipes = NULL;
 }
 
 /*