diff options
author | Julia Lawall <julia@diku.dk> | 2007-11-28 05:58:56 -0500 |
---|---|---|
committer | Jaroslav Kysela <perex@perex.cz> | 2008-01-31 11:29:30 -0500 |
commit | df1deb67532ea26f1a033a5f48bf34b30bec8e1d (patch) | |
tree | cebdf47a832ee63a9deeba4751d556219b627fd3 /sound/core | |
parent | 1005f66fd7175916db013dc98ca6b7cec26e5f81 (diff) |
[ALSA] sound/core/memalloc.c: Add missing pci_dev_put
There should be a pci_dev_put when breaking out of a loop that iterates
over calls to pci_get_device and similar functions.
In this case, the return under the initial if needs a pci_dev_put in the
same way that the return under the subsequent for loop has a pci_dev_put.
This was fixed using the following semantic patch.
// <smpl>
@@
type T;
identifier d;
expression e;
@@
T *d;
...
while ((d = \(pci_get_device\|pci_get_device_reverse\|pci_get_subsys\|pci_get_class\)(..., d)) != NULL)
{... when != pci_dev_put(d)
when != e = d
(
return d;
|
+ pci_dev_put(d);
? return ...;
)
...}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Diffstat (limited to 'sound/core')
-rw-r--r-- | sound/core/memalloc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/core/memalloc.c b/sound/core/memalloc.c index 9b4992eab479..920e5780c228 100644 --- a/sound/core/memalloc.c +++ b/sound/core/memalloc.c | |||
@@ -568,6 +568,7 @@ static ssize_t snd_mem_proc_write(struct file *file, const char __user * buffer, | |||
568 | if (pci_set_dma_mask(pci, mask) < 0 || | 568 | if (pci_set_dma_mask(pci, mask) < 0 || |
569 | pci_set_consistent_dma_mask(pci, mask) < 0) { | 569 | pci_set_consistent_dma_mask(pci, mask) < 0) { |
570 | printk(KERN_ERR "snd-page-alloc: cannot set DMA mask %lx for pci %04x:%04x\n", mask, vendor, device); | 570 | printk(KERN_ERR "snd-page-alloc: cannot set DMA mask %lx for pci %04x:%04x\n", mask, vendor, device); |
571 | pci_dev_put(pci); | ||
571 | return count; | 572 | return count; |
572 | } | 573 | } |
573 | } | 574 | } |