diff options
author | Takashi Iwai <tiwai@suse.de> | 2014-07-16 11:45:27 -0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2014-07-21 03:07:46 -0400 |
commit | 589008106b9b64153554c8f3f120ee512b134bb5 (patch) | |
tree | 087d7b1197dcc6933a87f82d84f955345b126c74 /sound/core | |
parent | 5646eda5851e6cfdfa22d41895e3f5daffa643d3 (diff) |
ALSA: pcm: Introduce protocol version field to sw_params
For controlling the new fields more strictly, add sw_params.proto
field indicating the protocol version of the user-space. User-space
should fill the SNDRV_PCM_VERSION value it's built with, then kernel
can know whether the new fields should be evaluated or not.
And now tstamp_type field is evaluated only when the valid value is
set there. This avoids the wrong override of tstamp_type to zero,
which is SNDRV_PCM_TSTAMP_TYPE_GETTIMEOFDAY.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core')
-rw-r--r-- | sound/core/pcm_native.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 81dedc381efd..8cd2f930ad0b 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c | |||
@@ -543,7 +543,8 @@ static int snd_pcm_sw_params(struct snd_pcm_substream *substream, | |||
543 | 543 | ||
544 | if (params->tstamp_mode > SNDRV_PCM_TSTAMP_LAST) | 544 | if (params->tstamp_mode > SNDRV_PCM_TSTAMP_LAST) |
545 | return -EINVAL; | 545 | return -EINVAL; |
546 | if (params->tstamp_type > SNDRV_PCM_TSTAMP_TYPE_LAST) | 546 | if (params->proto >= SNDRV_PROTOCOL_VERSION(2, 0, 12) && |
547 | params->tstamp_type > SNDRV_PCM_TSTAMP_TYPE_LAST) | ||
547 | return -EINVAL; | 548 | return -EINVAL; |
548 | if (params->avail_min == 0) | 549 | if (params->avail_min == 0) |
549 | return -EINVAL; | 550 | return -EINVAL; |
@@ -559,7 +560,8 @@ static int snd_pcm_sw_params(struct snd_pcm_substream *substream, | |||
559 | err = 0; | 560 | err = 0; |
560 | snd_pcm_stream_lock_irq(substream); | 561 | snd_pcm_stream_lock_irq(substream); |
561 | runtime->tstamp_mode = params->tstamp_mode; | 562 | runtime->tstamp_mode = params->tstamp_mode; |
562 | runtime->tstamp_type = params->tstamp_type; | 563 | if (params->proto >= SNDRV_PROTOCOL_VERSION(2, 0, 12)) |
564 | runtime->tstamp_type = params->tstamp_type; | ||
563 | runtime->period_step = params->period_step; | 565 | runtime->period_step = params->period_step; |
564 | runtime->control->avail_min = params->avail_min; | 566 | runtime->control->avail_min = params->avail_min; |
565 | runtime->start_threshold = params->start_threshold; | 567 | runtime->start_threshold = params->start_threshold; |