[ALSA] Remove snd_runtime_check() macro

Remove snd_runtime_check() macro.
This macro worsens the readability of codes.  They should be either
normal if() or removable asserts.

Also, the assert displays stack-dump, instead of only the last caller
pointer.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

8 files changed, 60 insertions, 36 deletions

diff --git a/sound/core/control.c b/sound/core/control.c
index 736edf358e05..212c46a94376 100644
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -144,7 +144,7 @@ void snd_ctl_notify(snd_card_t *card, unsigned int mask, snd_ctl_elem_id_t *id)
         snd_ctl_file_t *ctl;
         snd_kctl_event_t *ev;
         
-        snd_runtime_check(card != NULL && id != NULL, return);
+        snd_assert(card != NULL && id != NULL, return);
         read_lock(&card->ctl_files_rwlock);
 #if defined(CONFIG_SND_MIXER_OSS) || defined(CONFIG_SND_MIXER_OSS_MODULE)
         card->mixer_oss_change_count++;
@@ -193,8 +193,8 @@ snd_kcontrol_t *snd_ctl_new(snd_kcontrol_t * control, unsigned int access)
         snd_kcontrol_t *kctl;
         unsigned int idx;
         
-        snd_runtime_check(control != NULL, return NULL);
-        snd_runtime_check(control->count > 0, return NULL);
+        snd_assert(control != NULL, return NULL);
+        snd_assert(control->count > 0, return NULL);
         kctl = kzalloc(sizeof(*kctl) + sizeof(snd_kcontrol_volatile_t) * control->count, GFP_KERNEL);
         if (kctl == NULL)
                 return NULL;
@@ -220,7 +220,7 @@ snd_kcontrol_t *snd_ctl_new1(const snd_kcontrol_new_t * ncontrol, void *private_
         snd_kcontrol_t kctl;
         unsigned int access;
         
-        snd_runtime_check(ncontrol != NULL, return NULL);
+        snd_assert(ncontrol != NULL, return NULL);
         snd_assert(ncontrol->info != NULL, return NULL);
         memset(&kctl, 0, sizeof(kctl));
         kctl.id.iface = ncontrol->iface;
@@ -309,7 +309,7 @@ int snd_ctl_add(snd_card_t * card, snd_kcontrol_t * kcontrol)
         snd_ctl_elem_id_t id;
         unsigned int idx;
 
-        snd_runtime_check(card != NULL && kcontrol != NULL, return -EINVAL);
+        snd_assert(card != NULL && kcontrol != NULL, return -EINVAL);
         snd_assert(kcontrol->info != NULL, return -EINVAL);
         id = kcontrol->id;
         down_write(&card->controls_rwsem);
@@ -355,7 +355,7 @@ int snd_ctl_remove(snd_card_t * card, snd_kcontrol_t * kcontrol)
         snd_ctl_elem_id_t id;
         unsigned int idx;
 
-        snd_runtime_check(card != NULL && kcontrol != NULL, return -EINVAL);
+        snd_assert(card != NULL && kcontrol != NULL, return -EINVAL);
         list_del(&kcontrol->list);
         card->controls_count -= kcontrol->count;
         id = kcontrol->id;
@@ -468,7 +468,7 @@ snd_kcontrol_t *snd_ctl_find_numid(snd_card_t * card, unsigned int numid)
         struct list_head *list;
         snd_kcontrol_t *kctl;
 
-        snd_runtime_check(card != NULL && numid != 0, return NULL);
+        snd_assert(card != NULL && numid != 0, return NULL);
         list_for_each(list, &card->controls) {
                 kctl = snd_kcontrol(list);
                 if (kctl->id.numid <= numid && kctl->id.numid + kctl->count > numid)
@@ -494,7 +494,7 @@ snd_kcontrol_t *snd_ctl_find_id(snd_card_t * card, snd_ctl_elem_id_t *id)
         struct list_head *list;
         snd_kcontrol_t *kctl;
 
-        snd_runtime_check(card != NULL && id != NULL, return NULL);
+        snd_assert(card != NULL && id != NULL, return NULL);
         if (id->numid != 0)
                 return snd_ctl_find_numid(card, id->numid);
         list_for_each(list, &card->controls) {
@@ -1215,7 +1215,7 @@ static int _snd_ctl_unregister_ioctl(snd_kctl_ioctl_func_t fcn, struct list_head
         struct list_head *list;
         snd_kctl_ioctl_t *p;
 
-        snd_runtime_check(fcn != NULL, return -EINVAL);
+        snd_assert(fcn != NULL, return -EINVAL);
         down_write(&snd_ioctl_rwsem);
         list_for_each(list, lists) {
                 p = list_entry(list, snd_kctl_ioctl_t, list);
diff --git a/sound/core/init.c b/sound/core/init.c
index 41e224986f35..b98f7c6310c5 100644
--- a/sound/core/init.c
+++ b/sound/core/init.c
@@ -420,7 +420,7 @@ int snd_card_register(snd_card_t * card)
         int err;
         snd_info_entry_t *entry;
 
-        snd_runtime_check(card != NULL, return -EINVAL);
+        snd_assert(card != NULL, return -EINVAL);
         if ((err = snd_device_register_all(card)) < 0)
                 return err;
         write_lock(&snd_card_rwlock);
@@ -524,7 +524,8 @@ int __init snd_card_info_init(void)
         snd_info_entry_t *entry;
 
         entry = snd_info_create_module_entry(THIS_MODULE, "cards", NULL);
-        snd_runtime_check(entry != NULL, return -ENOMEM);
+        if (! entry)
+                return -ENOMEM;
         entry->c.text.read_size = PAGE_SIZE;
         entry->c.text.read = snd_card_info_read;
         if (snd_info_register(entry) < 0) {
diff --git a/sound/core/oss/mixer_oss.c b/sound/core/oss/mixer_oss.c
index 69e1059112d1..b2497cec2079 100644
--- a/sound/core/oss/mixer_oss.c
+++ b/sound/core/oss/mixer_oss.c
@@ -521,9 +521,13 @@ static void snd_mixer_oss_get_volume1_vol(snd_mixer_oss_file_t *fmixer,
         uctl = kzalloc(sizeof(*uctl), GFP_KERNEL);
         if (uinfo == NULL || uctl == NULL)
                 goto __unalloc;
-        snd_runtime_check(!kctl->info(kctl, uinfo), goto __unalloc);
-        snd_runtime_check(!kctl->get(kctl, uctl), goto __unalloc);
-        snd_runtime_check(uinfo->type != SNDRV_CTL_ELEM_TYPE_BOOLEAN || uinfo->value.integer.min != 0 || uinfo->value.integer.max != 1, goto __unalloc);
+        if (kctl->info(kctl, uinfo))
+                goto __unalloc;
+        if (kctl->get(kctl, uctl))
+                goto __unalloc;
+        if (uinfo->type == SNDRV_CTL_ELEM_TYPE_BOOLEAN &&
+            uinfo->value.integer.min == 0 && uinfo->value.integer.max == 1)
+                goto __unalloc;
         *left = snd_mixer_oss_conv1(uctl->value.integer.value[0], uinfo->value.integer.min, uinfo->value.integer.max, &pslot->volume[0]);
         if (uinfo->count > 1)
                 *right = snd_mixer_oss_conv1(uctl->value.integer.value[1], uinfo->value.integer.min, uinfo->value.integer.max, &pslot->volume[1]);
@@ -555,8 +559,10 @@ static void snd_mixer_oss_get_volume1_sw(snd_mixer_oss_file_t *fmixer,
         uctl = kzalloc(sizeof(*uctl), GFP_KERNEL);
         if (uinfo == NULL || uctl == NULL)
                 goto __unalloc;
-        snd_runtime_check(!kctl->info(kctl, uinfo), goto __unalloc);
-        snd_runtime_check(!kctl->get(kctl, uctl), goto __unalloc);
+        if (kctl->info(kctl, uinfo))
+                goto __unalloc;
+        if (kctl->get(kctl, uctl))
+                goto __unalloc;
         if (!uctl->value.integer.value[0]) {
                 *left = 0;
                 if (uinfo->count == 1)
@@ -616,12 +622,16 @@ static void snd_mixer_oss_put_volume1_vol(snd_mixer_oss_file_t *fmixer,
         uctl = kzalloc(sizeof(*uctl), GFP_KERNEL);
         if (uinfo == NULL || uctl == NULL)
                 goto __unalloc;
-        snd_runtime_check(!kctl->info(kctl, uinfo), goto __unalloc);
-        snd_runtime_check(uinfo->type != SNDRV_CTL_ELEM_TYPE_BOOLEAN || uinfo->value.integer.min != 0 || uinfo->value.integer.max != 1, goto __unalloc);
+        if (kctl->info(kctl, uinfo))
+                goto __unalloc;
+        if (uinfo->type == SNDRV_CTL_ELEM_TYPE_BOOLEAN &&
+            uinfo->value.integer.min == 0 && uinfo->value.integer.max == 1)
+                goto __unalloc;
         uctl->value.integer.value[0] = snd_mixer_oss_conv2(left, uinfo->value.integer.min, uinfo->value.integer.max);
         if (uinfo->count > 1)
                 uctl->value.integer.value[1] = snd_mixer_oss_conv2(right, uinfo->value.integer.min, uinfo->value.integer.max);
-        snd_runtime_check((res = kctl->put(kctl, uctl)) >= 0, goto __unalloc);
+        if ((res = kctl->put(kctl, uctl)) < 0)
+                goto __unalloc;
         if (res > 0)
                 snd_ctl_notify(card, SNDRV_CTL_EVENT_MASK_VALUE, &kctl->id);
       __unalloc:
@@ -653,7 +663,8 @@ static void snd_mixer_oss_put_volume1_sw(snd_mixer_oss_file_t *fmixer,
         uctl = kzalloc(sizeof(*uctl), GFP_KERNEL);
         if (uinfo == NULL || uctl == NULL)
                 goto __unalloc;
-        snd_runtime_check(!kctl->info(kctl, uinfo), goto __unalloc);
+        if (kctl->info(kctl, uinfo))
+                goto __unalloc;
         if (uinfo->count > 1) {
                 uctl->value.integer.value[0] = left > 0 ? 1 : 0;
                 uctl->value.integer.value[route ? 3 : 1] = right > 0 ? 1 : 0;
@@ -664,7 +675,8 @@ static void snd_mixer_oss_put_volume1_sw(snd_mixer_oss_file_t *fmixer,
         } else {
                 uctl->value.integer.value[0] = (left > 0 || right > 0) ? 1 : 0;
         }
-        snd_runtime_check((res = kctl->put(kctl, uctl)) >= 0, goto __unalloc);
+        if ((res = kctl->put(kctl, uctl)) < 0)
+                goto __unalloc;
         if (res > 0)
                 snd_ctl_notify(card, SNDRV_CTL_EVENT_MASK_VALUE, &kctl->id);
       __unalloc:
@@ -776,9 +788,14 @@ static int snd_mixer_oss_get_recsrc2(snd_mixer_oss_file_t *fmixer, unsigned int
         }
         down_read(&card->controls_rwsem);
         kctl = snd_mixer_oss_test_id(mixer, "Capture Source", 0);
-        snd_runtime_check(kctl != NULL, err = -ENOENT; goto __unlock);
-        snd_runtime_check(!(err = kctl->info(kctl, uinfo)), goto __unlock);
-        snd_runtime_check(!(err = kctl->get(kctl, uctl)), goto __unlock);
+        if (! kctl) {
+                err = -ENOENT;
+                goto __unlock;
+        }
+        if ((err = kctl->info(kctl, uinfo)) < 0)
+                goto __unlock;
+        if ((err = kctl->get(kctl, uctl)) < 0)
+                goto __unlock;
         for (idx = 0; idx < 32; idx++) {
                 if (!(mixer->mask_recsrc & (1 << idx)))
                         continue;
@@ -821,8 +838,12 @@ static int snd_mixer_oss_put_recsrc2(snd_mixer_oss_file_t *fmixer, unsigned int
         }
         down_read(&card->controls_rwsem);
         kctl = snd_mixer_oss_test_id(mixer, "Capture Source", 0);
-        snd_runtime_check(kctl != NULL, err = -ENOENT; goto __unlock);
-        snd_runtime_check(!(err = kctl->info(kctl, uinfo)), goto __unlock);
+        if (! kctl) {
+                err = -ENOENT;
+                goto __unlock;
+        }
+        if ((err = kctl->info(kctl, uinfo)) < 0)
+                goto __unlock;
         for (idx = 0; idx < 32; idx++) {
                 if (!(mixer->mask_recsrc & (1 << idx)))
                         continue;
@@ -836,10 +857,11 @@ static int snd_mixer_oss_put_recsrc2(snd_mixer_oss_file_t *fmixer, unsigned int
                         break;
                 slot = NULL;
         }
-        snd_runtime_check(slot != NULL, goto __unlock);
+        if (! slot)
+                goto __unlock;
         for (idx = 0; idx < uinfo->count; idx++)
                 uctl->value.enumerated.item[idx] = slot->capture_item;
-        snd_runtime_check((err = kctl->put(kctl, uctl)) >= 0, );
+        err = kctl->put(kctl, uctl);
         if (err > 0)
                 snd_ctl_notify(fmixer->card, SNDRV_CTL_EVENT_MASK_VALUE, &kctl->id);
         err = 0;
@@ -1008,7 +1030,8 @@ static int snd_mixer_oss_build_input(snd_mixer_oss_t *mixer, struct snd_mixer_os
         up_read(&mixer->card->controls_rwsem);
         if (slot.present != 0) {
                 pslot = (struct slot *)kmalloc(sizeof(slot), GFP_KERNEL);
-                snd_runtime_check(pslot != NULL, return -ENOMEM);
+                if (! pslot)
+                        return -ENOMEM;
                 *pslot = slot;
                 pslot->signature = SNDRV_MIXER_OSS_SIGNATURE;
                 pslot->assigned = ptr;
diff --git a/sound/core/pcm.c b/sound/core/pcm.c
index 1be470e942ef..184e74b75ba9 100644
--- a/sound/core/pcm.c
+++ b/sound/core/pcm.c
@@ -273,7 +273,8 @@ static void snd_pcm_proc_info_read(snd_pcm_substream_t *substream, snd_info_buff
         snd_pcm_info_t *info;
         int err;
 
-        snd_runtime_check(substream, return);
+        if (! substream)
+                return;
 
         info = kmalloc(sizeof(*info), GFP_KERNEL);
         if (! info) {
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index 0503980c23d9..dfc5f45f2748 100644
--- a/sound/core/pcm_lib.c
+++ b/sound/core/pcm_lib.c
@@ -156,9 +156,8 @@ static inline snd_pcm_uframes_t snd_pcm_update_hw_ptr_pos(snd_pcm_substream_t *s
 #ifdef CONFIG_SND_DEBUG
         if (pos >= runtime->buffer_size) {
                 snd_printk(KERN_ERR  "BUG: stream = %i, pos = 0x%lx, buffer size = 0x%lx, period size = 0x%lx\n", substream->stream, pos, runtime->buffer_size, runtime->period_size);
-        } else
+        }
 #endif
-        snd_runtime_check(pos < runtime->buffer_size, return 0);
         pos -= pos % runtime->min_align;
         return pos;
 }
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index e97b2d162cc7..e6e2b70314c0 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -2053,7 +2053,8 @@ static int snd_pcm_open(struct inode *inode, struct file *file)
         snd_pcm_file_t *pcm_file;
         wait_queue_t wait;
 
-        snd_runtime_check(device >= SNDRV_MINOR_PCM_PLAYBACK && device < SNDRV_MINOR_DEVICES, return -ENXIO);
+        if (device < SNDRV_MINOR_PCM_PLAYBACK || device >= SNDRV_MINOR_DEVICES)
+                return -ENXIO;
         pcm = snd_pcm_devices[(cardnum * SNDRV_PCM_DEVICES) + (device % SNDRV_MINOR_PCMS)];
         if (pcm == NULL) {
                 err = -ENODEV;
diff --git a/sound/core/seq/seq_midi.c b/sound/core/seq/seq_midi.c
index b4674ae3bc30..f89f40f44876 100644
--- a/sound/core/seq/seq_midi.c
+++ b/sound/core/seq/seq_midi.c
@@ -449,11 +449,9 @@ snd_seq_midisynth_unregister_port(snd_seq_device_t *dev)
         client->ports_per_device[device] = 0;
         msynth = client->ports[device];
         client->ports[device] = NULL;
-        snd_runtime_check(msynth != NULL || ports <= 0, goto __skip);
         for (p = 0; p < ports; p++)
                 snd_seq_midisynth_delete(&msynth[p]);
         kfree(msynth);
-      __skip:
         client->num_ports--;
         if (client->num_ports <= 0) {
                 snd_seq_delete_kernel_client(client->seq_client);
diff --git a/sound/core/timer.c b/sound/core/timer.c
index 22b104624084..128916c66085 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -879,7 +879,8 @@ void snd_timer_notify(snd_timer_t *timer, enum sndrv_timer_event event, struct t
         snd_timer_instance_t *ti, *ts;
         struct list_head *p, *n;
 
-        snd_runtime_check(timer->hw.flags & SNDRV_TIMER_HW_SLAVE, return);      
+        if (! (timer->hw.flags & SNDRV_TIMER_HW_SLAVE))
+                return;
         snd_assert(event >= SNDRV_TIMER_EVENT_MSTART && event <= SNDRV_TIMER_EVENT_MRESUME, return);
         spin_lock_irqsave(&timer->lock, flags);
         if (event == SNDRV_TIMER_EVENT_MSTART ||