diff options
author | Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> | 2011-09-25 04:49:09 -0400 |
---|---|---|
committer | James Morris <jmorris@namei.org> | 2011-09-25 20:46:19 -0400 |
commit | 778c4a4d60d932c1df6d270dcbc88365823c3963 (patch) | |
tree | 1c042bff1f11cf4e5d7267329091d878aba3d4d7 /security | |
parent | 6bce98edc3365a8f780ff3944ac7992544c194fe (diff) |
TOMOYO: Fix make namespacecheck warnings.
Commit efe836ab "TOMOYO: Add built-in policy support." introduced
tomoyo_load_builtin_policy() but was by error called from nowhere.
Commit b22b8b9f "TOMOYO: Rename meminfo to stat and show more statistics."
introduced tomoyo_update_stat() but was by error not called from
tomoyo_assign_domain().
Also, mark tomoyo_io_printf() and tomoyo_path_permission() static functions,
as reported by "make namespacecheck".
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'security')
-rw-r--r-- | security/tomoyo/common.c | 6 | ||||
-rw-r--r-- | security/tomoyo/common.h | 4 | ||||
-rw-r--r-- | security/tomoyo/domain.c | 1 | ||||
-rw-r--r-- | security/tomoyo/file.c | 4 | ||||
-rw-r--r-- | security/tomoyo/securityfs_if.c | 1 |
5 files changed, 9 insertions, 7 deletions
diff --git a/security/tomoyo/common.c b/security/tomoyo/common.c index 0994948f3edc..2e2802060eef 100644 --- a/security/tomoyo/common.c +++ b/security/tomoyo/common.c | |||
@@ -262,13 +262,17 @@ static void tomoyo_set_string(struct tomoyo_io_buffer *head, const char *string) | |||
262 | WARN_ON(1); | 262 | WARN_ON(1); |
263 | } | 263 | } |
264 | 264 | ||
265 | static void tomoyo_io_printf(struct tomoyo_io_buffer *head, const char *fmt, | ||
266 | ...) __printf(2, 3); | ||
267 | |||
265 | /** | 268 | /** |
266 | * tomoyo_io_printf - printf() to "struct tomoyo_io_buffer" structure. | 269 | * tomoyo_io_printf - printf() to "struct tomoyo_io_buffer" structure. |
267 | * | 270 | * |
268 | * @head: Pointer to "struct tomoyo_io_buffer". | 271 | * @head: Pointer to "struct tomoyo_io_buffer". |
269 | * @fmt: The printf()'s format string, followed by parameters. | 272 | * @fmt: The printf()'s format string, followed by parameters. |
270 | */ | 273 | */ |
271 | void tomoyo_io_printf(struct tomoyo_io_buffer *head, const char *fmt, ...) | 274 | static void tomoyo_io_printf(struct tomoyo_io_buffer *head, const char *fmt, |
275 | ...) | ||
272 | { | 276 | { |
273 | va_list args; | 277 | va_list args; |
274 | size_t len; | 278 | size_t len; |
diff --git a/security/tomoyo/common.h b/security/tomoyo/common.h index a2bc33fc60b6..1a19ad3e67ea 100644 --- a/security/tomoyo/common.h +++ b/security/tomoyo/common.h | |||
@@ -978,8 +978,6 @@ int tomoyo_path_number_perm(const u8 operation, struct path *path, | |||
978 | unsigned long number); | 978 | unsigned long number); |
979 | int tomoyo_path_perm(const u8 operation, struct path *path, | 979 | int tomoyo_path_perm(const u8 operation, struct path *path, |
980 | const char *target); | 980 | const char *target); |
981 | int tomoyo_path_permission(struct tomoyo_request_info *r, u8 operation, | ||
982 | const struct tomoyo_path_info *filename); | ||
983 | int tomoyo_poll_control(struct file *file, poll_table *wait); | 981 | int tomoyo_poll_control(struct file *file, poll_table *wait); |
984 | int tomoyo_poll_log(struct file *file, poll_table *wait); | 982 | int tomoyo_poll_log(struct file *file, poll_table *wait); |
985 | int tomoyo_socket_bind_permission(struct socket *sock, struct sockaddr *addr, | 983 | int tomoyo_socket_bind_permission(struct socket *sock, struct sockaddr *addr, |
@@ -1041,8 +1039,6 @@ void tomoyo_del_condition(struct list_head *element); | |||
1041 | void tomoyo_fill_path_info(struct tomoyo_path_info *ptr); | 1039 | void tomoyo_fill_path_info(struct tomoyo_path_info *ptr); |
1042 | void tomoyo_get_attributes(struct tomoyo_obj_info *obj); | 1040 | void tomoyo_get_attributes(struct tomoyo_obj_info *obj); |
1043 | void tomoyo_init_policy_namespace(struct tomoyo_policy_namespace *ns); | 1041 | void tomoyo_init_policy_namespace(struct tomoyo_policy_namespace *ns); |
1044 | void tomoyo_io_printf(struct tomoyo_io_buffer *head, const char *fmt, ...) | ||
1045 | __printf(2, 3); | ||
1046 | void tomoyo_load_policy(const char *filename); | 1042 | void tomoyo_load_policy(const char *filename); |
1047 | void tomoyo_memory_free(void *ptr); | 1043 | void tomoyo_memory_free(void *ptr); |
1048 | void tomoyo_normalize_line(unsigned char *buffer); | 1044 | void tomoyo_normalize_line(unsigned char *buffer); |
diff --git a/security/tomoyo/domain.c b/security/tomoyo/domain.c index 860390ee1fbe..70acf7aebbda 100644 --- a/security/tomoyo/domain.c +++ b/security/tomoyo/domain.c | |||
@@ -567,6 +567,7 @@ out: | |||
567 | tomoyo_write_log(&r, "use_profile %u\n", | 567 | tomoyo_write_log(&r, "use_profile %u\n", |
568 | entry->profile); | 568 | entry->profile); |
569 | tomoyo_write_log(&r, "use_group %u\n", entry->group); | 569 | tomoyo_write_log(&r, "use_group %u\n", entry->group); |
570 | tomoyo_update_stat(TOMOYO_STAT_POLICY_UPDATES); | ||
570 | } | 571 | } |
571 | } | 572 | } |
572 | return entry; | 573 | return entry; |
diff --git a/security/tomoyo/file.c b/security/tomoyo/file.c index b280c1bd652d..400390790745 100644 --- a/security/tomoyo/file.c +++ b/security/tomoyo/file.c | |||
@@ -555,8 +555,8 @@ static int tomoyo_update_path2_acl(const u8 perm, | |||
555 | * | 555 | * |
556 | * Caller holds tomoyo_read_lock(). | 556 | * Caller holds tomoyo_read_lock(). |
557 | */ | 557 | */ |
558 | int tomoyo_path_permission(struct tomoyo_request_info *r, u8 operation, | 558 | static int tomoyo_path_permission(struct tomoyo_request_info *r, u8 operation, |
559 | const struct tomoyo_path_info *filename) | 559 | const struct tomoyo_path_info *filename) |
560 | { | 560 | { |
561 | int error; | 561 | int error; |
562 | 562 | ||
diff --git a/security/tomoyo/securityfs_if.c b/security/tomoyo/securityfs_if.c index d08296a4882b..2672ac4f3beb 100644 --- a/security/tomoyo/securityfs_if.c +++ b/security/tomoyo/securityfs_if.c | |||
@@ -265,6 +265,7 @@ static int __init tomoyo_initerface_init(void) | |||
265 | TOMOYO_VERSION); | 265 | TOMOYO_VERSION); |
266 | securityfs_create_file("self_domain", 0666, tomoyo_dir, NULL, | 266 | securityfs_create_file("self_domain", 0666, tomoyo_dir, NULL, |
267 | &tomoyo_self_operations); | 267 | &tomoyo_self_operations); |
268 | tomoyo_load_builtin_policy(); | ||
268 | return 0; | 269 | return 0; |
269 | } | 270 | } |
270 | 271 | ||