aboutsummaryrefslogtreecommitdiffstats
path: root/security
diff options
context:
space:
mode:
authorDavid Howells <dhowells@redhat.com>2010-02-25 20:56:16 -0500
committerJames Morris <jmorris@namei.org>2010-02-25 22:54:23 -0500
commitef57471a73b67a7b65fd8708fd55c77cb7c619af (patch)
tree0cb8f8dea197999d79bf69d192719be69cd36244 /security
parent1fcdc7c527010b144d3951f9ce25faedf264933c (diff)
SELinux: Make selinux_kernel_create_files_as() shouldn't just always return 0
Make selinux_kernel_create_files_as() return an error when it gets one, rather than unconditionally returning 0. Without this, cachefiles doesn't return an error if the SELinux policy doesn't let it create files with the label of the directory at the base of the cache. Signed-off-by: David Howells <dhowells@redhat.com> Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'security')
-rw-r--r--security/selinux/hooks.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index dc7660074b99..5feecb41009d 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -3329,7 +3329,7 @@ static int selinux_kernel_create_files_as(struct cred *new, struct inode *inode)
3329 3329
3330 if (ret == 0) 3330 if (ret == 0)
3331 tsec->create_sid = isec->sid; 3331 tsec->create_sid = isec->sid;
3332 return 0; 3332 return ret;
3333} 3333}
3334 3334
3335static int selinux_kernel_module_request(char *kmod_name) 3335static int selinux_kernel_module_request(char *kmod_name)