diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-03-13 06:14:22 -0500 |
|---|---|---|
| committer | James Morris <jmorris@namei.org> | 2010-03-14 16:51:29 -0400 |
| commit | 181427a7e01beab76c789414334375839f026128 (patch) | |
| tree | 3a50a93331b536b80d9c393a034489c9678d8a13 /security | |
| parent | bca14dd14f3b0c5e3e2d1d314679f85b67871365 (diff) | |
tomoyo: fix potential use after free
The original code returns a freed pointer. This function is expected to
return NULL on errors.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'security')
| -rw-r--r-- | security/tomoyo/common.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/security/tomoyo/common.c b/security/tomoyo/common.c index ff51f1026b57..ef89947a774b 100644 --- a/security/tomoyo/common.c +++ b/security/tomoyo/common.c | |||
| @@ -886,6 +886,7 @@ static struct tomoyo_profile *tomoyo_find_or_assign_new_profile(const unsigned | |||
| 886 | ptr = kmalloc(sizeof(*ptr), GFP_KERNEL); | 886 | ptr = kmalloc(sizeof(*ptr), GFP_KERNEL); |
| 887 | if (!tomoyo_memory_ok(ptr)) { | 887 | if (!tomoyo_memory_ok(ptr)) { |
| 888 | kfree(ptr); | 888 | kfree(ptr); |
| 889 | ptr = NULL; | ||
| 889 | goto ok; | 890 | goto ok; |
| 890 | } | 891 | } |
| 891 | for (i = 0; i < TOMOYO_MAX_CONTROL_INDEX; i++) | 892 | for (i = 0; i < TOMOYO_MAX_CONTROL_INDEX; i++) |