aboutsummaryrefslogtreecommitdiffstats
path: root/security
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2008-11-07 01:43:03 -0500
committerDavid S. Miller <davem@davemloft.net>2008-11-07 01:43:03 -0500
commit9eeda9abd1faf489f3df9a1f557975f4c8650363 (patch)
tree3e0a58e25b776cfbee193195460324dccb1886c7 /security
parent61c9eaf90081cbe6dc4f389e0056bff76eca19ec (diff)
parent4bab0ea1d42dd1927af9df6fbf0003fc00617c50 (diff)
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
Conflicts: drivers/net/wireless/ath5k/base.c net/8021q/vlan_core.c
Diffstat (limited to 'security')
-rw-r--r--security/commoncap.c6
-rw-r--r--security/selinux/hooks.c8
2 files changed, 8 insertions, 6 deletions
diff --git a/security/commoncap.c b/security/commoncap.c
index 399bfdb9e2da..3976613db829 100644
--- a/security/commoncap.c
+++ b/security/commoncap.c
@@ -279,10 +279,10 @@ static int get_file_caps(struct linux_binprm *bprm)
279 struct vfs_cap_data vcaps; 279 struct vfs_cap_data vcaps;
280 struct inode *inode; 280 struct inode *inode;
281 281
282 if (bprm->file->f_vfsmnt->mnt_flags & MNT_NOSUID) { 282 bprm_clear_caps(bprm);
283 bprm_clear_caps(bprm); 283
284 if (bprm->file->f_vfsmnt->mnt_flags & MNT_NOSUID)
284 return 0; 285 return 0;
285 }
286 286
287 dentry = dget(bprm->file->f_dentry); 287 dentry = dget(bprm->file->f_dentry);
288 inode = dentry->d_inode; 288 inode = dentry->d_inode;
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index aedf02b1345a..f3c4bc12fea3 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -2126,14 +2126,16 @@ static inline void flush_unauthorized_files(struct files_struct *files)
2126 tty = get_current_tty(); 2126 tty = get_current_tty();
2127 if (tty) { 2127 if (tty) {
2128 file_list_lock(); 2128 file_list_lock();
2129 file = list_entry(tty->tty_files.next, typeof(*file), f_u.fu_list); 2129 if (!list_empty(&tty->tty_files)) {
2130 if (file) { 2130 struct inode *inode;
2131
2131 /* Revalidate access to controlling tty. 2132 /* Revalidate access to controlling tty.
2132 Use inode_has_perm on the tty inode directly rather 2133 Use inode_has_perm on the tty inode directly rather
2133 than using file_has_perm, as this particular open 2134 than using file_has_perm, as this particular open
2134 file may belong to another process and we are only 2135 file may belong to another process and we are only
2135 interested in the inode-based check here. */ 2136 interested in the inode-based check here. */
2136 struct inode *inode = file->f_path.dentry->d_inode; 2137 file = list_first_entry(&tty->tty_files, struct file, f_u.fu_list);
2138 inode = file->f_path.dentry->d_inode;
2137 if (inode_has_perm(current, inode, 2139 if (inode_has_perm(current, inode,
2138 FILE__READ | FILE__WRITE, NULL)) { 2140 FILE__READ | FILE__WRITE, NULL)) {
2139 drop_tty = 1; 2141 drop_tty = 1;