diff options
author | Serge E. Hallyn <serue@us.ibm.com> | 2009-02-02 18:07:33 -0500 |
---|---|---|
committer | James Morris <jmorris@namei.org> | 2009-02-02 19:02:51 -0500 |
commit | faa3aad75a959f55e7783f4dc7840253c7506571 (patch) | |
tree | 88e6c94cda322ff2b32f72bb8d96f9675cdad8aa /security | |
parent | 5626d3e86141390c8efc7bcb929b6a4b58b00480 (diff) |
securityfs: fix long-broken securityfs_create_file comment
If there is an error creating a file through securityfs_create_file,
NULL is not returned, rather the error is propagated.
Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'security')
-rw-r--r-- | security/inode.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/security/inode.c b/security/inode.c index efea5a605466..b41e708147ae 100644 --- a/security/inode.c +++ b/security/inode.c | |||
@@ -205,12 +205,11 @@ static int create_by_name(const char *name, mode_t mode, | |||
205 | * This function returns a pointer to a dentry if it succeeds. This | 205 | * This function returns a pointer to a dentry if it succeeds. This |
206 | * pointer must be passed to the securityfs_remove() function when the file is | 206 | * pointer must be passed to the securityfs_remove() function when the file is |
207 | * to be removed (no automatic cleanup happens if your module is unloaded, | 207 | * to be removed (no automatic cleanup happens if your module is unloaded, |
208 | * you are responsible here). If an error occurs, %NULL is returned. | 208 | * you are responsible here). If an error occurs, the function will return |
209 | * the erorr value (via ERR_PTR). | ||
209 | * | 210 | * |
210 | * If securityfs is not enabled in the kernel, the value %-ENODEV is | 211 | * If securityfs is not enabled in the kernel, the value %-ENODEV is |
211 | * returned. It is not wise to check for this value, but rather, check for | 212 | * returned. |
212 | * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling | ||
213 | * code. | ||
214 | */ | 213 | */ |
215 | struct dentry *securityfs_create_file(const char *name, mode_t mode, | 214 | struct dentry *securityfs_create_file(const char *name, mode_t mode, |
216 | struct dentry *parent, void *data, | 215 | struct dentry *parent, void *data, |