[PATCH] keys: Discard key spinlock and use RCU for key payload

The attached patch changes the key implementation in a number of ways:

 (1) It removes the spinlock from the key structure.

 (2) The key flags are now accessed using atomic bitops instead of
     write-locking the key spinlock and using C bitwise operators.

     The three instantiation flags are dealt with with the construction
     semaphore held during the request_key/instantiate/negate sequence, thus
     rendering the spinlock superfluous.

     The key flags are also now bit numbers not bit masks.

 (3) The key payload is now accessed using RCU. This permits the recursive
     keyring search algorithm to be simplified greatly since no locks need be
     taken other than the usual RCU preemption disablement. Searching now does
     not require any locks or semaphores to be held; merely that the starting
     keyring be pinned.

 (4) The keyring payload now includes an RCU head so that it can be disposed
     of by call_rcu(). This requires that the payload be copied on unlink to
     prevent introducing races in copy-down vs search-up.

 (5) The user key payload is now a structure with the data following it. It
     includes an RCU head like the keyring payload and for the same reason. It
     also contains a data length because the data length in the key may be
     changed on another CPU whilst an RCU protected read is in progress on the
     payload. This would then see the supposed RCU payload and the on-key data
     length getting out of sync.

     I'm tempted to drop the key's datalen entirely, except that it's used in
     conjunction with quota management and so is a little tricky to get rid
     of.

 (6) Update the keys documentation.

Signed-Off-By: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

1 files changed, 15 insertions, 17 deletions

diff --git a/security/keys/request_key.c b/security/keys/request_key.c
index 9705b1aeba5d..1f6c0940297f 100644
--- a/security/keys/request_key.c
+++ b/security/keys/request_key.c
@@ -105,7 +105,7 @@ static struct key *__request_key_construction(struct key_type *type,
         struct key_construction cons;
         struct timespec now;
         struct key *key;
-        int ret, negative;
+        int ret, negated;
 
         /* create a key and add it to the queue */
         key = key_alloc(type, description,
@@ -113,9 +113,7 @@ static struct key *__request_key_construction(struct key_type *type,
         if (IS_ERR(key))
                 goto alloc_failed;
 
-        write_lock(&key->lock);
-        key->flags |= KEY_FLAG_USER_CONSTRUCT;
-        write_unlock(&key->lock);
+        set_bit(KEY_FLAG_USER_CONSTRUCT, &key->flags);
 
         cons.key = key;
         list_add_tail(&cons.link, &key->user->consq);
@@ -130,7 +128,7 @@ static struct key *__request_key_construction(struct key_type *type,
 
         /* if the key wasn't instantiated, then we want to give an error */
         ret = -ENOKEY;
-        if (!(key->flags & KEY_FLAG_INSTANTIATED))
+        if (!test_bit(KEY_FLAG_INSTANTIATED, &key->flags))
                 goto request_failed;
 
         down_write(&key_construction_sem);
@@ -139,7 +137,7 @@ static struct key *__request_key_construction(struct key_type *type,
 
         /* also give an error if the key was negatively instantiated */
  check_not_negative:
-        if (key->flags & KEY_FLAG_NEGATIVE) {
+        if (test_bit(KEY_FLAG_NEGATIVE, &key->flags)) {
                 key_put(key);
                 key = ERR_PTR(-ENOKEY);
         }
@@ -152,24 +150,23 @@ static struct key *__request_key_construction(struct key_type *type,
          * - remove from construction queue
          * - mark the key as dead
          */
-        negative = 0;
+        negated = 0;
         down_write(&key_construction_sem);
 
         list_del(&cons.link);
 
-        write_lock(&key->lock);
-        key->flags &= ~KEY_FLAG_USER_CONSTRUCT;
-
         /* check it didn't get instantiated between the check and the down */
-        if (!(key->flags & KEY_FLAG_INSTANTIATED)) {
-                key->flags |= KEY_FLAG_INSTANTIATED | KEY_FLAG_NEGATIVE;
-                negative = 1;
+        if (!test_bit(KEY_FLAG_INSTANTIATED, &key->flags)) {
+                set_bit(KEY_FLAG_NEGATIVE, &key->flags);
+                set_bit(KEY_FLAG_INSTANTIATED, &key->flags);
+                negated = 1;
         }
 
-        write_unlock(&key->lock);
+        clear_bit(KEY_FLAG_USER_CONSTRUCT, &key->flags);
+
         up_write(&key_construction_sem);
 
-        if (!negative)
+        if (!negated)
                 goto check_not_negative; /* surprisingly, the key got
                                           * instantiated */
 
@@ -250,7 +247,7 @@ static struct key *request_key_construction(struct key_type *type,
 
         for (;;) {
                 set_current_state(TASK_UNINTERRUPTIBLE);
-                if (!(ckey->flags & KEY_FLAG_USER_CONSTRUCT))
+                if (!test_bit(KEY_FLAG_USER_CONSTRUCT, &ckey->flags))
                         break;
                 schedule();
         }
@@ -339,7 +336,8 @@ int key_validate(struct key *key)
         if (key) {
                 /* check it's still accessible */
                 ret = -EKEYREVOKED;
-                if (key->flags & (KEY_FLAG_REVOKED | KEY_FLAG_DEAD))
+                if (test_bit(KEY_FLAG_REVOKED, &key->flags) ||
+                    test_bit(KEY_FLAG_DEAD, &key->flags))
                         goto error;
 
                 /* check it hasn't expired */