[PATCH] keys: Discard key spinlock and use RCU for key payload

The attached patch changes the key implementation in a number of ways:

 (1) It removes the spinlock from the key structure.

 (2) The key flags are now accessed using atomic bitops instead of
     write-locking the key spinlock and using C bitwise operators.

     The three instantiation flags are dealt with with the construction
     semaphore held during the request_key/instantiate/negate sequence, thus
     rendering the spinlock superfluous.

     The key flags are also now bit numbers not bit masks.

 (3) The key payload is now accessed using RCU. This permits the recursive
     keyring search algorithm to be simplified greatly since no locks need be
     taken other than the usual RCU preemption disablement. Searching now does
     not require any locks or semaphores to be held; merely that the starting
     keyring be pinned.

 (4) The keyring payload now includes an RCU head so that it can be disposed
     of by call_rcu(). This requires that the payload be copied on unlink to
     prevent introducing races in copy-down vs search-up.

 (5) The user key payload is now a structure with the data following it. It
     includes an RCU head like the keyring payload and for the same reason. It
     also contains a data length because the data length in the key may be
     changed on another CPU whilst an RCU protected read is in progress on the
     payload. This would then see the supposed RCU payload and the on-key data
     length getting out of sync.

     I'm tempted to drop the key's datalen entirely, except that it's used in
     conjunction with quota management and so is a little tricky to get rid
     of.

 (6) Update the keys documentation.

Signed-Off-By: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

1 files changed, 13 insertions, 8 deletions

diff --git a/security/keys/proc.c b/security/keys/proc.c
index 91343b85c39c..c55cf1fd0826 100644
--- a/security/keys/proc.c
+++ b/security/keys/proc.c
@@ -140,7 +140,7 @@ static int proc_keys_show(struct seq_file *m, void *v)
 
         now = current_kernel_time();
 
-        read_lock(&key->lock);
+        rcu_read_lock();
 
         /* come up with a suitable timeout value */
         if (key->expiry == 0) {
@@ -164,14 +164,17 @@ static int proc_keys_show(struct seq_file *m, void *v)
                         sprintf(xbuf, "%luw", timo / (60*60*24*7));
         }
 
+#define showflag(KEY, LETTER, FLAG) \
+        (test_bit(FLAG, &(KEY)->flags) ? LETTER : '-')
+
         seq_printf(m, "%08x %c%c%c%c%c%c %5d %4s %06x %5d %5d %-9.9s ",
                    key->serial,
-                   key->flags & KEY_FLAG_INSTANTIATED   ? 'I' : '-',
-                   key->flags & KEY_FLAG_REVOKED        ? 'R' : '-',
-                   key->flags & KEY_FLAG_DEAD           ? 'D' : '-',
-                   key->flags & KEY_FLAG_IN_QUOTA       ? 'Q' : '-',
-                   key->flags & KEY_FLAG_USER_CONSTRUCT ? 'U' : '-',
-                   key->flags & KEY_FLAG_NEGATIVE       ? 'N' : '-',
+                   showflag(key, 'I', KEY_FLAG_INSTANTIATED),
+                   showflag(key, 'R', KEY_FLAG_REVOKED),
+                   showflag(key, 'D', KEY_FLAG_DEAD),
+                   showflag(key, 'Q', KEY_FLAG_IN_QUOTA),
+                   showflag(key, 'U', KEY_FLAG_USER_CONSTRUCT),
+                   showflag(key, 'N', KEY_FLAG_NEGATIVE),
                    atomic_read(&key->usage),
                    xbuf,
                    key->perm,
@@ -179,11 +182,13 @@ static int proc_keys_show(struct seq_file *m, void *v)
                    key->gid,
                    key->type->name);
 
+#undef showflag
+
         if (key->type->describe)
                 key->type->describe(key, m);
         seq_putc(m, '\n');
 
-        read_unlock(&key->lock);
+        rcu_read_unlock();
 
         return 0;