aboutsummaryrefslogtreecommitdiffstats
path: root/security/dummy.c
diff options
context:
space:
mode:
authorH. Peter Anvin <hpa@zytor.com>2007-12-29 19:20:25 -0500
committerJames Morris <jmorris@namei.org>2008-01-24 19:29:50 -0500
commitbced95283e9434611cbad8f2ff903cd396eaea72 (patch)
tree5d56afc7a5f239ebc53a1800a508f16b8d8701b0 /security/dummy.c
parent42d7896ebc5f7268b1fe6bbd20f2282e20ae7895 (diff)
security: remove security_sb_post_mountroot hook
The security_sb_post_mountroot() hook is long-since obsolete, and is fundamentally broken: it is never invoked if someone uses initramfs. This is particularly damaging, because the existence of this hook has been used as motivation for not using initramfs. Stephen Smalley confirmed on 2007-07-19 that this hook was originally used by SELinux but can now be safely removed: http://marc.info/?l=linux-kernel&m=118485683612916&w=2 Cc: Stephen Smalley <sds@tycho.nsa.gov> Cc: James Morris <jmorris@namei.org> Cc: Eric Paris <eparis@parisplace.org> Cc: Chris Wright <chrisw@sous-sol.org> Signed-off-by: H. Peter Anvin <hpa@zytor.com> Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'security/dummy.c')
-rw-r--r--security/dummy.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/security/dummy.c b/security/dummy.c
index a3b29d0d00e5..8e34e03415f8 100644
--- a/security/dummy.c
+++ b/security/dummy.c
@@ -225,11 +225,6 @@ static void dummy_sb_post_remount (struct vfsmount *mnt, unsigned long flags,
225} 225}
226 226
227 227
228static void dummy_sb_post_mountroot (void)
229{
230 return;
231}
232
233static void dummy_sb_post_addmount (struct vfsmount *mnt, struct nameidata *nd) 228static void dummy_sb_post_addmount (struct vfsmount *mnt, struct nameidata *nd)
234{ 229{
235 return; 230 return;
@@ -1017,7 +1012,6 @@ void security_fixup_ops (struct security_operations *ops)
1017 set_to_dummy_if_null(ops, sb_umount_close); 1012 set_to_dummy_if_null(ops, sb_umount_close);
1018 set_to_dummy_if_null(ops, sb_umount_busy); 1013 set_to_dummy_if_null(ops, sb_umount_busy);
1019 set_to_dummy_if_null(ops, sb_post_remount); 1014 set_to_dummy_if_null(ops, sb_post_remount);
1020 set_to_dummy_if_null(ops, sb_post_mountroot);
1021 set_to_dummy_if_null(ops, sb_post_addmount); 1015 set_to_dummy_if_null(ops, sb_post_addmount);
1022 set_to_dummy_if_null(ops, sb_pivotroot); 1016 set_to_dummy_if_null(ops, sb_pivotroot);
1023 set_to_dummy_if_null(ops, sb_post_pivotroot); 1017 set_to_dummy_if_null(ops, sb_post_pivotroot);