diff options
author | Dustin Kirkland <dustin.kirkland@us.ibm.com> | 2005-11-16 10:53:13 -0500 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2006-03-20 14:08:54 -0500 |
commit | 7306a0b9b3e2056a616c84841288ca2431a05627 (patch) | |
tree | d3f61ef43c7079790d6b8ef9bf307689a7d9ea16 /security/dummy.c | |
parent | 8c8570fb8feef2bc166bee75a85748b25cda22d9 (diff) |
[PATCH] Miscellaneous bug and warning fixes
This patch fixes a couple of bugs revealed in new features recently
added to -mm1:
* fixes warnings due to inconsistent use of const struct inode *inode
* fixes bug that prevent a kernel from booting with audit on, and SELinux off
due to a missing function in security/dummy.c
* fixes a bug that throws spurious audit_panic() messages due to a missing
return just before an error_path label
* some reasonable house cleaning in audit_ipc_context(),
audit_inode_context(), and audit_log_task_context()
Signed-off-by: Dustin Kirkland <dustin.kirkland@us.ibm.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Diffstat (limited to 'security/dummy.c')
-rw-r--r-- | security/dummy.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/security/dummy.c b/security/dummy.c index 6febe7d39fa0..0a553d39729f 100644 --- a/security/dummy.c +++ b/security/dummy.c | |||
@@ -378,7 +378,7 @@ static int dummy_inode_removexattr (struct dentry *dentry, char *name) | |||
378 | return 0; | 378 | return 0; |
379 | } | 379 | } |
380 | 380 | ||
381 | static int dummy_inode_getsecurity(struct inode *inode, const char *name, void *buffer, size_t size, int err) | 381 | static int dummy_inode_getsecurity(const struct inode *inode, const char *name, void *buffer, size_t size, int err) |
382 | { | 382 | { |
383 | return -EOPNOTSUPP; | 383 | return -EOPNOTSUPP; |
384 | } | 384 | } |
@@ -393,6 +393,11 @@ static int dummy_inode_listsecurity(struct inode *inode, char *buffer, size_t bu | |||
393 | return 0; | 393 | return 0; |
394 | } | 394 | } |
395 | 395 | ||
396 | static const char *dummy_inode_xattr_getsuffix(void) | ||
397 | { | ||
398 | return NULL; | ||
399 | } | ||
400 | |||
396 | static int dummy_file_permission (struct file *file, int mask) | 401 | static int dummy_file_permission (struct file *file, int mask) |
397 | { | 402 | { |
398 | return 0; | 403 | return 0; |
@@ -930,6 +935,7 @@ void security_fixup_ops (struct security_operations *ops) | |||
930 | set_to_dummy_if_null(ops, inode_getxattr); | 935 | set_to_dummy_if_null(ops, inode_getxattr); |
931 | set_to_dummy_if_null(ops, inode_listxattr); | 936 | set_to_dummy_if_null(ops, inode_listxattr); |
932 | set_to_dummy_if_null(ops, inode_removexattr); | 937 | set_to_dummy_if_null(ops, inode_removexattr); |
938 | set_to_dummy_if_null(ops, inode_xattr_getsuffix); | ||
933 | set_to_dummy_if_null(ops, inode_getsecurity); | 939 | set_to_dummy_if_null(ops, inode_getsecurity); |
934 | set_to_dummy_if_null(ops, inode_setsecurity); | 940 | set_to_dummy_if_null(ops, inode_setsecurity); |
935 | set_to_dummy_if_null(ops, inode_listsecurity); | 941 | set_to_dummy_if_null(ops, inode_listsecurity); |