Merge v2.6.37-rc8 into powerpc/next

1 files changed, 13 insertions, 36 deletions

diff --git a/security/apparmor/path.c b/security/apparmor/path.c
index 96bab9469d48..36cc0cc39e78 100644
--- a/security/apparmor/path.c
+++ b/security/apparmor/path.c
@@ -59,40 +59,21 @@ static int d_namespace_path(struct path *path, char *buf, int buflen,
 {
         struct path root, tmp;
         char *res;
-        int deleted, connected;
-        int error = 0;
+        int connected, error = 0;
 
-        /* Get the root we want to resolve too */
+        /* Get the root we want to resolve too, released below */
         if (flags & PATH_CHROOT_REL) {
                 /* resolve paths relative to chroot */
-                read_lock(&current->fs->lock);
-                root = current->fs->root;
-                /* released below */
-                path_get(&root);
-                read_unlock(&current->fs->lock);
+                get_fs_root(current->fs, &root);
         } else {
                 /* resolve paths relative to namespace */
                 root.mnt = current->nsproxy->mnt_ns->root;
                 root.dentry = root.mnt->mnt_root;
-                /* released below */
                 path_get(&root);
         }
 
-        spin_lock(&dcache_lock);
-        /* There is a race window between path lookup here and the
-         * need to strip the " (deleted) string that __d_path applies
-         * Detect the race and relookup the path
-         *
-         * The stripping of (deleted) is a hack that could be removed
-         * with an updated __d_path
-         */
-        do {
-                tmp = root;
-                deleted = d_unlinked(path->dentry);
-                res = __d_path(path, &tmp, buf, buflen);
-
-        } while (deleted != d_unlinked(path->dentry));
-        spin_unlock(&dcache_lock);
+        tmp = root;
+        res = __d_path(path, &tmp, buf, buflen);
 
         *name = res;
         /* handle error conditions - and still allow a partial path to
@@ -103,21 +84,17 @@ static int d_namespace_path(struct path *path, char *buf, int buflen,
                 *name = buf;
                 goto out;
         }
-        if (deleted) {
-                /* On some filesystems, newly allocated dentries appear to the
-                 * security_path hooks as a deleted dentry except without an
-                 * inode allocated.
-                 *
-                 * Remove the appended deleted text and return as string for
-                 * normal mediation, or auditing.  The (deleted) string is
-                 * guaranteed to be added in this case, so just strip it.
-                 */
-                buf[buflen - 11] = 0;   /* - (len(" (deleted)") +\0) */
 
-                if (path->dentry->d_inode && !(flags & PATH_MEDIATE_DELETED)) {
+        /* Handle two cases:
+         * 1. A deleted dentry && profile is not allowing mediation of deleted
+         * 2. On some filesystems, newly allocated dentries appear to the
+         *    security_path hooks as a deleted dentry except without an inode
+         *    allocated.
+         */
+        if (d_unlinked(path->dentry) && path->dentry->d_inode &&
+            !(flags & PATH_MEDIATE_DELETED)) {
                         error = -ENOENT;
                         goto out;
-                }
         }
 
         /* Determine if the path is connected to the expected root */