diff options
author | Christian Engelmayer <cengelma@gmx.at> | 2014-04-27 22:04:32 -0400 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2014-04-27 22:18:34 -0400 |
commit | 2ee41e62ba5b952e9d9fcba6f7079a0c608bb849 (patch) | |
tree | f04675dda077b17953fd1360763f0f8b8fd74b8f /scripts | |
parent | ec6931b281797b69e6cf109f9cc94d5a2bf994e0 (diff) |
modpost: Fix resource leak in read_dump()
Function read_dump() memory maps the input via grab_file(), but fails to call
the corresponding unmap function. Add the missing call to release_file().
Detected by Coverity: CID 1192419
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'scripts')
-rw-r--r-- | scripts/mod/modpost.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 066355673930..ea3e2bdf1825 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c | |||
@@ -2113,8 +2113,10 @@ static void read_dump(const char *fname, unsigned int kernel) | |||
2113 | s->preloaded = 1; | 2113 | s->preloaded = 1; |
2114 | sym_update_crc(symname, mod, crc, export_no(export)); | 2114 | sym_update_crc(symname, mod, crc, export_no(export)); |
2115 | } | 2115 | } |
2116 | release_file(file, size); | ||
2116 | return; | 2117 | return; |
2117 | fail: | 2118 | fail: |
2119 | release_file(file, size); | ||
2118 | fatal("parse error in symbol dump file\n"); | 2120 | fatal("parse error in symbol dump file\n"); |
2119 | } | 2121 | } |
2120 | 2122 | ||