diff options
| author | Fabian Frederick <fabf@skynet.be> | 2015-04-09 16:58:04 -0400 |
|---|---|---|
| committer | Michal Marek <mmarek@suse.cz> | 2015-04-15 08:21:31 -0400 |
| commit | 33236415ece63d5689411f3ddb676eeb93af2698 (patch) | |
| tree | a2f62547e4d316850af24653761ed650bb269993 /scripts | |
| parent | 99b2cdde83726a89daadbfd1264fb9a3b91eed0b (diff) | |
scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning
if()/BUG conversion to BUG_ON must be avoided when there's side effect
in condition. The reason being BUG_ON won't execute the condition when
CONFIG_BUG is not defined.
Inspired-by: J. Bruce Fields <bfields@fieldses.org>
Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Michal Marek <mmarek@suse.cz>
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/coccinelle/misc/bugon.cocci | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/coccinelle/misc/bugon.cocci b/scripts/coccinelle/misc/bugon.cocci index 3b7eec24fb5a..27c97f1f2767 100644 --- a/scripts/coccinelle/misc/bugon.cocci +++ b/scripts/coccinelle/misc/bugon.cocci | |||
| @@ -57,6 +57,6 @@ coccilib.org.print_todo(p[0], "WARNING use BUG_ON") | |||
| 57 | p << r.p; | 57 | p << r.p; |
| 58 | @@ | 58 | @@ |
| 59 | 59 | ||
| 60 | msg="WARNING: Use BUG_ON" | 60 | msg="WARNING: Use BUG_ON instead of if condition followed by BUG.\nPlease make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)" |
| 61 | coccilib.report.print_report(p[0], msg) | 61 | coccilib.report.print_report(p[0], msg) |
| 62 | 62 | ||